From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 5BEAE3858405 for ; Thu, 28 Oct 2021 20:40:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BEAE3858405 Received: by mail-pl1-x62f.google.com with SMTP id y1so5258350plk.10 for ; Thu, 28 Oct 2021 13:40:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xYjWgGf4ifc8Q2zRdmcXpGUhtIBtVFt+6PjyPT0S+HE=; b=q0X0IlsIpZEa2rQPxfgdD4+52PKqq6dzWCqYpBK6HkxFu7I4PJy0bGTDHYpVVh1tRc TqEkIqU14ti+mk5kgxiXWIId8SticXOaLEtCvRqG86ElztT7M3ppP9YzCLaygsQcwh66 wbOZP4GDm3V7IN2H9ziescFl7xriaMoWXlTY1UfxWetZ7dfpM27GHRI/uCzUCaJpR+Dq wxfrSEpqNAmygIn/PfkDs8QoyyK6qcDhlIqzs9NhTrFUygAOxY+C0lIn/yO4UoHxHA3S Edze77uWUZEMok002OscIC5IEBljfBeGyfExxdfStO9qMocSJcKE6Q+owFRMyhrBiglj 8x1Q== X-Gm-Message-State: AOAM5314olyWznYIAT9uYc8LP44PwCxe9mopDJ69DhYJ08WqfQ24xsJn IoTOMXDfiBmsB/tTxE7osZd6lp/e2Ent51x7B3jGRXx9 X-Google-Smtp-Source: ABdhPJxYoR6uwuW9qbFmZ4emD9MLuIJ+RnhDoeCel+Ie8TRoaYaYimr4E8mtqQO7pLjtOn2PoKPmotZ8EXxKwu5gIs8= X-Received: by 2002:a17:903:1111:b0:13f:d1d7:fb67 with SMTP id n17-20020a170903111100b0013fd1d7fb67mr5720549plh.85.1635453628528; Thu, 28 Oct 2021 13:40:28 -0700 (PDT) MIME-Version: 1.0 References: <20211028194738.82344-1-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 28 Oct 2021 13:39:52 -0700 Message-ID: Subject: Re: [PATCH v1] x86_64: Add memcmpeq.S to fix disable-multi-arch build To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2021 20:40:31 -0000 On Thu, Oct 28, 2021 at 1:22 PM Noah Goldstein wrote: > > On Thu, Oct 28, 2021 at 3:19 PM H.J. Lu wrote: > > > > On Thu, Oct 28, 2021 at 12:47 PM Noah Goldstein wrote: > > > > > > The following commit: > > > > > > commit cf4fd28ea453d1a9cec93939bc88b58ccef5437a > > > Author: Noah Goldstein > > > Date: Tue Oct 26 19:43:18 2021 -0500 > > > > > > Broke --disable-multi-arch build for x86_64 because x86_64/memcmpeq.S > > > was not defined outside of multiarch and the alias for __memcmpeq in > > > x86_64/memcmp.S was removed. > > > > > > This commit fixes that issue by adding x86_64/memcmpeq.S. > > > > > > make xcheck passes on x86_64 with and without --disable-multi-arch > > > --- > > > sysdeps/x86_64/memcmpeq.S | 23 +++++++++++++++++++++++ > > > 1 file changed, 23 insertions(+) > > > create mode 100644 sysdeps/x86_64/memcmpeq.S > > > > > > diff --git a/sysdeps/x86_64/memcmpeq.S b/sysdeps/x86_64/memcmpeq.S > > > new file mode 100644 > > > index 0000000000..f3dd1d0085 > > > --- /dev/null > > > +++ b/sysdeps/x86_64/memcmpeq.S > > > @@ -0,0 +1,23 @@ > > > +/* __memcmpeq optimized with SSE2. > > > + Copyright (C) 2017-2021 Free Software Foundation, Inc. > > > + This file is part of the GNU C Library. > > > + > > > + The GNU C Library is free software; you can redistribute it and/or > > > + modify it under the terms of the GNU Lesser General Public > > > + License as published by the Free Software Foundation; either > > > + version 2.1 of the License, or (at your option) any later version. > > > + > > > + The GNU C Library is distributed in the hope that it will be useful, > > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > > + Lesser General Public License for more details. > > > + > > > + You should have received a copy of the GNU Lesser General Public > > > + License along with the GNU C Library; if not, see > > > + . */ > > > + > > > +#ifndef memcmp > > > +# define memcmp __memcmpeq > > > +#endif > > > > Why is this needed? Does the simple > > > > #define memcmp __memcmpeq > > > > work? > > It's not inherently needed. > > Generally just think it's easier to protect these > definitions so it's easier to include the file. > > Do you want me to remove it? Yes, please remove it. OK with that change. Thanks. > > > > > +#define USE_AS_MEMCMPEQ 1 > > > +#include "multiarch/memcmp-sse2.S" > > > -- > > > 2.25.1 > > > > > > > > > -- > > H.J. -- H.J.