From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91395-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 80385 invoked by alias); 3 Apr 2018 22:14:20 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 80372 invoked by uid 89); 3 Apr 2018 22:14:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1423
X-HELO: mail-oi0-f53.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=FLSJCp46AFgSeVjzLQ+Ei4RZyP3UpdfIm+AznfjNfI0=;
        b=ksVOVNyobSG1aFA3fYmddnxAG9//7teiW4TbJpRN4MTxyKvOBZ7XEF70bu2+X+MmXW
         od0cftIjoKvs7I/bQ0icUd+9S/Fdo5w7m8uOah9829s7bp+Pleeu6W0PE+6nm3QJ2MFE
         MKLM3NlHo+Jzs5oEBMZrygRL5qyXb8p3imaq29dzv+nPu1qoobdiEp5fzDKG12n62yQQ
         0DKNDg35KlpDFXA8GmhhTjIBNS1qjK++axXqQA5xofF918lATuaHKqywVHYZQ3eisL6h
         ZvPQ1utrBo594QtcwHrRYdGaEXAex8CsTdDplSmtvBTYRm+uywboc8P8bsz5PmeAwCpF
         N0iw==
X-Gm-Message-State: ALQs6tAwh+MTWB7gy/r3fGvNWgt+BiIduYaGB8l9+okty9D2nUvXBOln
	8xHdlB9ovCfmYdasN4eGWoeTfa+3TOSOWyAd2Nw=
X-Google-Smtp-Source: AIpwx48tJV1QNaL27swqbIWNYTTAfEd73WAaPHyfPRE3v9oY7ou7rVVeg8gtAS7BhObPailiYtRmpbhYb989neGCBEs=
X-Received: by 2002:aca:c743:: with SMTP id x64-v6mr9124739oif.100.1522793657003;
 Tue, 03 Apr 2018 15:14:17 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20180403215502.gecm7xl2gnw7xwxc@var.youpi.perso.aquilenet.fr>
References: <20180403003817.21337-1-samuel.thibault@ens-lyon.org>
 <mvmo9j07lsi.fsf@suse.de> <20180403082029.g3bfw4upbti67wwz@var.youpi.perso.aquilenet.fr>
 <CAMe9rOoAeQbv6b-1hSTQ9b-EgiC5ErHO3UkS-aZFCFYLn7_xOQ@mail.gmail.com>
 <20180403210755.rbbjx7mou47mp3er@var.youpi.perso.aquilenet.fr>
 <CAMe9rOo_aDsrtY-QfFz-yAp+0-Qg7MW0jGKns7GVjKZ_fTr1=Q@mail.gmail.com>
 <20180403212413.n64u3uvhcem3db47@var.youpi.perso.aquilenet.fr>
 <CAMe9rOqqimSKb+nxR3daeqataHabDHMm-XLWG+_0V7WW2WrtXw@mail.gmail.com> <20180403215502.gecm7xl2gnw7xwxc@var.youpi.perso.aquilenet.fr>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 03 Apr 2018 22:14:00 -0000
Message-ID: <CAMe9rOp2nwcXSDDVbcemu71U2O6PnqjrUGufPbkHJ8FNc+bVNQ@mail.gmail.com>
Subject: Re: [hurd,commited] hurd: Avoid more libc.so local PLTs
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Andreas Schwab <schwab@suse.de>, GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2018-04/txt/msg00090.txt.bz2

On Tue, Apr 3, 2018 at 2:55 PM, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> H.J. Lu, on mar. 03 avril 2018 14:41:27 -0700, wrote:
>> On Tue, Apr 3, 2018 at 2:24 PM, Samuel Thibault
>> <samuel.thibault@ens-lyon.org> wrote:
>> > H.J. Lu, on mar. 03 avril 2018 14:16:50 -0700, wrote:
>> >> On Tue, Apr 3, 2018 at 2:07 PM, Samuel Thibault
>> >> <samuel.thibault@ens-lyon.org> wrote:
>> >> > Hello,
>> >> >
>> >> > H.J. Lu, on mar. 03 avril 2018 12:26:33 -0700, wrote:
>> >> >> __libc_longjmp and __libc_siglongjmp are private external functions provided for
>> >> >> libpthread.  They should never be called inside libc.
>> >> >
>> >> > I'm sorry for asking, but are these conventions documented somewhere?
>> >> > These look like magic to me otherwise:
>> >>
>> >> I don't believe they are well documented.
>> >
>> > Ok, then I need an answer to my question:
>> >
>> >> > why shouldn't they ever be called from libc?
>> >
>> > The existing hurd code does use them for catching signals, so I need to
>> > know how to fix it.
>>
>> Use something similar to
>>
>> libc_hidden_proto (_setjmp)
>> libc_hidden_proto (__sigsetjmp)
>
> So I'd just add hidden protos & defs to longjmp and siglongjmp?
>

setjmp/longjmp.c has

weak_alias (__libc_siglongjmp, _longjmp)
weak_alias (__libc_siglongjmp, longjmp)

Will

libc_hidden_proto (_longjmp)

work for you?


-- 
H.J.