From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by sourceware.org (Postfix) with ESMTPS id 0D78F3857C4F for ; Tue, 30 Apr 2024 20:13:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D78F3857C4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D78F3857C4F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1134 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714508001; cv=none; b=ojt/Wfh8o/i+JAm+R1W1aoB2EFO3zzsP1H64ubXC1fnY7EL9vw+xV3OasLsnKtyIoQAtN1SjB04yJ/MqhKpAiJZiyZLjry8D7mEpSd+Ui/LJb4eKDY9j7bxX7U89WeJJ89eoA9c0+VTUHzhF5AaWwgotGJopBwnVWxmhK3lgcb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714508001; c=relaxed/simple; bh=Q7VjZDCGZr6naNAOX4C0Ko3TbSyQ4TwZbQKtUDLlPJA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=KKb4uepz1sAuh6r7SCtXWDDvx45iOaCP6raf0SSbicsnG6sU74DDKORWTPwb0yzHXlf8LVZKz4J4FEw5WbFjVsXXlvwRCSpM5SwZGU7I653m0TjiiB0OZrFsJ6FX8SkOpvrmYD9T4Kx9X9xKJJGwBOS4cI9csrxktHpRT1f+NrY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-61be613d903so19887097b3.0 for ; Tue, 30 Apr 2024 13:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714507999; x=1715112799; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9m0SIAjC/fXui0J3KwU88Hp6WO/0sUOUf8RgaVwINgc=; b=S/1zcYqzbdCBMaLLBwTWV4ANySf7oStnM2xL+R7Zq9Y5So2/jXvisw22toMIRzG/wy lahZ/XoLqJsjemxP9kfe9jn8QzhYCWD/6uC8gRvQyjwCI6arNPeOv0PNQ9fSmr9rrnqN Ld3fqpkXF5iSZDsPwGSnueOwekLJXD/QkBFBjpkMYQSevNrNrqtbGE518hFa2dNWR3jz Vnq+1ZFcgsbphPu53Hl3cjHjSZ13M5FB6zmIhSSHo6IKEEyklFguT54jnZeERfheAqba QOJOAxx0re5wq1Z/fALME2q3TgJMPAqxH77+r2YOIh7wryATdlu8jzRPrdjTylxByGlE 8Vdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714507999; x=1715112799; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9m0SIAjC/fXui0J3KwU88Hp6WO/0sUOUf8RgaVwINgc=; b=OJOXfBoKfioIwCkvqPC6DK8WYT7MuQn6fsBPxf8v4M/qNZkuc23Kr3jX7X12hh9c63 w3U+9WHtZFCKduRFhudJduW4h+U/vjACNYk9GBUCmsF+yI9MYtcT4ORM363hKAxvREl/ l0L6yfBj27CpVqEmryz7nTJA56NlLahQpOYT+NrRTo9FYRHHLAGixpMPjkbDL/0Z/jx0 +4cy/SI8oIaz7aQL4Z2ZDcpkLLJEH8NF7130SJRwK3XIDBvCVllfLBv/fV1J1Pw2tm2A JhY+8imt0lb+O2GQCQ9TtbiiMeLzBzT6478TV9FRoYFTd+pUA2JGI8ucBcySWBF5kQlO P5+A== X-Gm-Message-State: AOJu0YzqDDcR7Va/3o6qlrNqtC8rpRPFAon2Co1yMie3qtDUHxapQvCD jQxM94OkCprMZI/KjgbCcWFTvJFTJhk8PUaeAfz3IZeTn7jlnfuWW2r56Evsy4N49ZAms9Mp+vn H5rKmxej4+G+QdbEYrfBOzDiQpOAC7Q== X-Google-Smtp-Source: AGHT+IFRfJ4oeht+ugkIcLf3ZDNXht+OoZ9TcGq4CBo0l1vbZMH6p+In7ZrQ03dvg5ryOOGgcWvyaiPiYJ3iPalEND0= X-Received: by 2002:a05:690c:6511:b0:61a:e947:5518 with SMTP id hw17-20020a05690c651100b0061ae9475518mr675186ywb.27.1714507999363; Tue, 30 Apr 2024 13:13:19 -0700 (PDT) MIME-Version: 1.0 References: <20240430200506.2717717-1-gabifalk@gmx.com> <20240430200506.2717717-4-gabifalk@gmx.com> In-Reply-To: <20240430200506.2717717-4-gabifalk@gmx.com> From: "H.J. Lu" Date: Tue, 30 Apr 2024 13:12:43 -0700 Message-ID: Subject: Re: [PATCH 3/3] Add a test to check for duplicate definitions in the static library To: Gabi Falk Cc: libc-alpha@sourceware.org, Florian Weimer , "Dmitry V. Levin" , Sam James Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 30, 2024 at 1:05=E2=80=AFPM Gabi Falk wrote: > > This change follows two previous fixes addressing multiple definitions > of __memcpy_chk and __mempcpy_chk functions on i586, and __memmove_chk > and __memset_chk functions on i686. The test is intended to prevent > such issues from occurring in the future. > > Signed-off-by: Gabi Falk > Reviewed-by: H.J. Lu > --- > Makefile | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Makefile b/Makefile > index b5ef98fb04..adf4749124 100644 > --- a/Makefile > +++ b/Makefile > @@ -577,6 +577,13 @@ $(objpfx)lint-makefiles.out: scripts/lint-makefiles.= sh > $(SHELL) $< "$(PYTHON)" `pwd` > $@ ; \ > $(evaluate-test) > > +# Link libc.a as a whole to verify that it does not contain multiple > +# definitions of any symbols. > +tests-special +=3D $(objpfx)link-static-libc.out > +$(objpfx)link-static-libc.out: > + $(LINK.o) $(whole-archive) -r $(objpfx)libc.a -o /dev/null > $@ 2= >&1; \ > + $(evaluate-test) > + > # Print test summary for tests in $1 .sum file; > # $2 is optional test identifier. > # Fail if there are unexpected failures in the test results. > -- > gabi > LGTM. Reviewed-by: H.J. Lu Thanks. --=20 H.J.