From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 19F443858D39 for ; Fri, 28 Oct 2022 22:18:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19F443858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22d.google.com with SMTP id x21so8631139ljg.10 for ; Fri, 28 Oct 2022 15:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jKn5L87ilZMXQoAzrhwqqfa+TA+35YLqdDQbrsN+cTA=; b=ooSAOAU3oy3zaOSozJVBR2TN9N5ToaZ0vmts9j+PwyeDDJAh16tba+9RW5YkjkpJ5M ZBK5YhqL/HC2o3UQ5VisUbqzmnhBVnAZxZvQFtdFlZpB1TrFDJVro4Q+RdWL/U3KLEb4 9Lpvvi1ZkZkdoBHykOhy7ZacSaW7IWOFAJS3qkyo4LO+zqv6oCZPEcSqfqbdl6pHOgmh mBl7kOetoCGE+u0KYTn12vbXGDpRIIFUyZbGR7oHk4X/jwYJMJ5RX9vlUvkjAYiHc7z3 4+rAXDVLVt2nClbEsPtqIAcFTg0l2S528JxekuP1E40o0cunPEa8lRr49Uzfyb7HCPa9 hj/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jKn5L87ilZMXQoAzrhwqqfa+TA+35YLqdDQbrsN+cTA=; b=qzznt8gm36s9T2XEu0GJnMCp+6H5mh4a8hwUNcr4ddRY0omThLg+9zEelI5rGKuslY ziyueB11BrSkgyaVzXVebArG99Oc6UIMxZziv7Tvihr+MNWVSez49KIHeFvDn+yoccbD MsJ5x8tBYiEOkCF+avg5TyyYCrCZodFiNfDCb7pFylyySiVwOq9Pg96xDssyiLQcaU5X MO1R34scMHbHEqIE+DvtxpjzfDHdGKzbW1l5n9iHOieSkR1XOyaJbGQYbKod3HYsxsTq 5eQy14mD16MLGXNED2amj3yEFYzXdAINwLPZoDCrPYGdGfzBJom4jEzPb2GzRH/WMZet zDtQ== X-Gm-Message-State: ACrzQf1WxKgDzwwKvo/VqfB0UNhalvaDpN2l+lyl9IBk3jeGS3khui8O /47uo0utFc0ocoF4iHw5M/1j+TXYNbDG2k6910AgnJltMcY= X-Google-Smtp-Source: AMsMyM6EEHAJKcWhhuIj+Bc79wlHlnw3kP07rXyq77sVumdJaOPa7qf0eP4mpL76/gF/vkGjrLQL9EwYc9mAA/NjICE= X-Received: by 2002:a05:651c:1947:b0:277:452:23a with SMTP id bs7-20020a05651c194700b002770452023amr614068ljb.479.1666995505344; Fri, 28 Oct 2022 15:18:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Fri, 28 Oct 2022 15:17:48 -0700 Message-ID: Subject: Re: Failing DT_RELR tests and --enable-hardcoded-path-in-tests? To: "Carlos O'Donell" Cc: libc-alpha , Fangrui Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3017.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 28, 2022 at 2:37 PM Carlos O'Donell wrote: > > HJ, > > In my testing on the recently about to be released Fedora 37 I noted the > following two failures: > > tests.sum:FAIL: elf/tst-relr3 > tests.sum:FAIL: elf/tst-relr4 > > cat elf/tst-relr3.test-result > FAIL: elf/tst-relr3 > original exit status 127 > > env GCONV_PATH=3D/home/carlos/build/glibc-review/iconvdata LOCPATH=3D/hom= e/carlos/build/glibc-review/localedata LC_ALL=3DC /home/carlos/build/glibc= -review/elf/tst-relr3 > /home/carlos/build/glibc-review/elf/tst-relr3.out;= \ > ../scripts/evaluate-test.sh elf/tst-relr3 $? false false > /home/carlos/b= uild/glibc-review/elf/tst-relr3.test-result > ... > /home/carlos/build/glibc-review/elf/tst-relr3: error while loading shared= libraries: tst-relr-mod3b.so: cannot open shared object file: No such file= or directory > > In the hardcoded path mode we do not add any additional paths to search > for tst-relr-mod3b.so that is depended upon by tst-relr-mod3a.so. > > Under Fedora we have DT_RUNPATH only: > 0x000000000000001d (RUNPATH) Library runpath: [/home/carlos/b= uild/glibc-review:/home/carlos/build/glibc-review/math:/home/carlos/build/g= libc-review/elf:/home/carlos/build/glibc-review/dlfcn:/home/carlos/build/gl= ibc-review/nss:/home/carlos/build/glibc-review/nis:/home/carlos/build/glibc= -review/rt:/home/carlos/build/glibc-review/resolv:/home/carlos/build/glibc-= review/mathvec:/home/carlos/build/glibc-review/support:/home/carlos/build/g= libc-review/crypt:/home/carlos/build/glibc-review/nptl] > > Do we need to add some rpath usage here when building the module? Yes. > Suggestions? Here is a patch: https://patchwork.sourceware.org/project/glibc/list/?series=3D13666 --=20 H.J.