* [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534]
@ 2020-08-26 2:26 Ondřej Hošek
2020-08-26 3:54 ` H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Ondřej Hošek @ 2020-08-26 2:26 UTC (permalink / raw)
To: libc-alpha
A typo in commit 107e6a3c2212ba7a3a4ec7cae8d82d73f7c95d0b causes the
FMA4 code path to be taken on systems that support FMA, even if they do
not support FMA4. Fix this to detect FMA4.
---
sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h b/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
index 7659758972..e5fd5ac9cb 100644
--- a/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
+++ b/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
@@ -32,7 +32,7 @@ IFUNC_SELECTOR (void)
&& CPU_FEATURE_USABLE_P (cpu_features, AVX2))
return OPTIMIZE (fma);
- if (CPU_FEATURE_USABLE_P (cpu_features, FMA))
+ if (CPU_FEATURE_USABLE_P (cpu_features, FMA4))
return OPTIMIZE (fma4);
return OPTIMIZE (sse2);
--
2.28.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534]
2020-08-26 2:26 [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534] Ondřej Hošek
@ 2020-08-26 3:54 ` H.J. Lu
2020-08-26 12:56 ` Adhemerval Zanella
2020-09-02 8:19 ` Ondřej Hošek
0 siblings, 2 replies; 6+ messages in thread
From: H.J. Lu @ 2020-08-26 3:54 UTC (permalink / raw)
To: Ondřej Hošek; +Cc: GNU C Library
On Tue, Aug 25, 2020 at 7:27 PM Ondřej Hošek via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> A typo in commit 107e6a3c2212ba7a3a4ec7cae8d82d73f7c95d0b causes the
> FMA4 code path to be taken on systems that support FMA, even if they do
> not support FMA4. Fix this to detect FMA4.
> ---
> sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h b/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
> index 7659758972..e5fd5ac9cb 100644
> --- a/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
> +++ b/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
> @@ -32,7 +32,7 @@ IFUNC_SELECTOR (void)
> && CPU_FEATURE_USABLE_P (cpu_features, AVX2))
> return OPTIMIZE (fma);
>
> - if (CPU_FEATURE_USABLE_P (cpu_features, FMA))
> + if (CPU_FEATURE_USABLE_P (cpu_features, FMA4))
> return OPTIMIZE (fma4);
>
> return OPTIMIZE (sse2);
> --
> 2.28.0
>
LGTM.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534]
2020-08-26 3:54 ` H.J. Lu
@ 2020-08-26 12:56 ` Adhemerval Zanella
2020-09-02 8:19 ` Ondřej Hošek
1 sibling, 0 replies; 6+ messages in thread
From: Adhemerval Zanella @ 2020-08-26 12:56 UTC (permalink / raw)
To: libc-alpha
On 26/08/2020 00:54, H.J. Lu via Libc-alpha wrote:
> On Tue, Aug 25, 2020 at 7:27 PM Ondřej Hošek via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>> A typo in commit 107e6a3c2212ba7a3a4ec7cae8d82d73f7c95d0b causes the
>> FMA4 code path to be taken on systems that support FMA, even if they do
>> not support FMA4. Fix this to detect FMA4.
>> ---
>> sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h b/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
>> index 7659758972..e5fd5ac9cb 100644
>> --- a/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
>> +++ b/sysdeps/x86_64/fpu/multiarch/ifunc-fma4.h
>> @@ -32,7 +32,7 @@ IFUNC_SELECTOR (void)
>> && CPU_FEATURE_USABLE_P (cpu_features, AVX2))
>> return OPTIMIZE (fma);
>>
>> - if (CPU_FEATURE_USABLE_P (cpu_features, FMA))
>> + if (CPU_FEATURE_USABLE_P (cpu_features, FMA4))
>> return OPTIMIZE (fma4);
>>
>> return OPTIMIZE (sse2);
>> --
I think it should be backported to 2.32 as well.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534]
2020-08-26 3:54 ` H.J. Lu
2020-08-26 12:56 ` Adhemerval Zanella
@ 2020-09-02 8:19 ` Ondřej Hošek
2020-09-02 12:10 ` H.J. Lu
1 sibling, 1 reply; 6+ messages in thread
From: Ondřej Hošek @ 2020-09-02 8:19 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Wed, Aug 26, 2020 at 5:54 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Aug 25, 2020 at 7:27 PM Ondřej Hošek via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > A typo in commit 107e6a3c2212ba7a3a4ec7cae8d82d73f7c95d0b causes the
> > FMA4 code path to be taken on systems that support FMA, even if they do
> > not support FMA4. Fix this to detect FMA4.
> > [...]
>
> LGTM.
>
> Thanks.
A week has elapsed since the last comment; may I ask you to commit the patch?
Thanks!
Cheers,
~~ Ondra
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534]
2020-09-02 8:19 ` Ondřej Hošek
@ 2020-09-02 12:10 ` H.J. Lu
2020-09-02 13:03 ` [2.32] " H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2020-09-02 12:10 UTC (permalink / raw)
To: Ondřej Hošek; +Cc: GNU C Library
On Wed, Sep 2, 2020 at 1:19 AM Ondřej Hošek <ondra.hosek@gmail.com> wrote:
>
> On Wed, Aug 26, 2020 at 5:54 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Tue, Aug 25, 2020 at 7:27 PM Ondřej Hošek via Libc-alpha
> > <libc-alpha@sourceware.org> wrote:
> > >
> > > A typo in commit 107e6a3c2212ba7a3a4ec7cae8d82d73f7c95d0b causes the
> > > FMA4 code path to be taken on systems that support FMA, even if they do
> > > not support FMA4. Fix this to detect FMA4.
> > > [...]
> >
> > LGTM.
> >
> > Thanks.
>
> A week has elapsed since the last comment; may I ask you to commit the patch?
>
> Thanks!
>
> Cheers,
> ~~ Ondra
I checked it in for you.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.32] [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534]
2020-09-02 12:10 ` H.J. Lu
@ 2020-09-02 13:03 ` H.J. Lu
0 siblings, 0 replies; 6+ messages in thread
From: H.J. Lu @ 2020-09-02 13:03 UTC (permalink / raw)
To: Ondřej Hošek, Libc-stable Mailing List; +Cc: GNU C Library
On Wed, Sep 2, 2020 at 5:10 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Wed, Sep 2, 2020 at 1:19 AM Ondřej Hošek <ondra.hosek@gmail.com> wrote:
> >
> > On Wed, Aug 26, 2020 at 5:54 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Tue, Aug 25, 2020 at 7:27 PM Ondřej Hošek via Libc-alpha
> > > <libc-alpha@sourceware.org> wrote:
> > > >
> > > > A typo in commit 107e6a3c2212ba7a3a4ec7cae8d82d73f7c95d0b causes the
> > > > FMA4 code path to be taken on systems that support FMA, even if they do
> > > > not support FMA4. Fix this to detect FMA4.
> > > > [...]
> > >
> > > LGTM.
> > >
> > > Thanks.
> >
> > A week has elapsed since the last comment; may I ask you to commit the patch?
> >
> > Thanks!
> >
> > Cheers,
> > ~~ Ondra
>
> I checked it in for you.
>
> Thanks.
I am backpoing it to 2.32 branch.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-02 13:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 2:26 [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534] Ondřej Hošek
2020-08-26 3:54 ` H.J. Lu
2020-08-26 12:56 ` Adhemerval Zanella
2020-09-02 8:19 ` Ondřej Hošek
2020-09-02 12:10 ` H.J. Lu
2020-09-02 13:03 ` [2.32] " H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).