From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 9990A3858D3C for ; Thu, 24 Mar 2022 19:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9990A3858D3C Received: by mail-pl1-x630.google.com with SMTP id e5so5821783pls.4 for ; Thu, 24 Mar 2022 12:34:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aBQvh5/oR3Z50eCEOn9uTinqqH7Jo1pc3XlXb8JGSl0=; b=gOTrC4o0FSwtbnXjwBVMbtZvTMuHsTJqQZ8RsT/j3/Swoycl+a7yQP/H3NKlDcbdjO OTrA4aF8RD40r78z9S+07+awKBqq+gnfUMdbVMawDSNV84xloyPULCS/P4qYJGGP3QRL nwpvgdRtJlS67YKvvwRvjtojuE05ufvWfX5fIXZrr6UFYiG4F8FQskYT7SJkJEp3zRe2 sJ+n+Il9E6gfWu6gGg3FGXWYqw02FgZ+vF9kyQRhnk6efoBbI0XksJ5Spi0odmXEdoIE HkN3SSe6ivUgHJaLwD8QzmLdfnue6Jkw82uEHBJJ/5cYrTBTLgCVJF2ntkEsAdn3XlI4 nDxw== X-Gm-Message-State: AOAM532YKAp/k6+ZK0m2oZ7KfyYtcJGHAHa/LIcam7sVESw9FSxFeTND iJHuNg75MBDwv6F+AnV1EKmTJfannG+SYxmmllY= X-Google-Smtp-Source: ABdhPJyfc7IPyfKvSWn7JuBeFyGi77YLBnVe03hqS8IUhTkYDdsV7i1l91hxt5jrEa1jQ7sZMbBmVAqpsLb/oHcz+I8= X-Received: by 2002:a17:902:d508:b0:154:2f99:a52e with SMTP id b8-20020a170902d50800b001542f99a52emr7431693plg.102.1648150480639; Thu, 24 Mar 2022 12:34:40 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-12-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 24 Mar 2022 12:34:04 -0700 Message-ID: Subject: Re: [PATCH v1 12/23] x86: Fix fallback for wcsncmp_avx2 in strcmp-avx2.S [BZ #28896] To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 19:34:43 -0000 On Thu, Mar 24, 2022 at 12:18 PM Noah Goldstein wrote: > > On Thu, Mar 24, 2022 at 2:00 PM H.J. Lu wrote: > > > > On Wed, Mar 23, 2022 at 3:01 PM Noah Goldstein wrote: > > > > > > Overflow case for __wcsncmp_avx2_rtm should be __wcscmp_avx2_rtm not > > > __wcscmp_avx2. > > > > > > All string/memory tests pass. > > > --- > > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S > > > index 52ff5ad724..86a86b68e3 100644 > > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S > > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S > > > @@ -122,7 +122,7 @@ ENTRY(STRCMP) > > > are cases where length is large enough that it can never be a > > > bound on valid memory so just use wcscmp. */ > > > shrq $56, %rcx > > > - jnz __wcscmp_avx2 > > > + jnz OVERFLOW_STRCMP > > > > > > leaq (, %rdx, 4), %rdx > > > # endif > > > -- > > > 2.25.1 > > > > > > > Isn't it a bug? Is there a glibc bug? Should this also be fixed on release > > branches? > > It is bug but no need for backport. Why no need for backport? Is there a testcase? -- H.J.