From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36814 invoked by alias); 4 Jun 2017 16:47:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 36798 invoked by uid 89); 4 Jun 2017 16:47:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f174.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zdn98uAMI/1l7hJHK5M2n+9EMjB4K4X1nknzSeJdeAs=; b=pMAqYal8W5F/D/YHXVAnXCbSpPCUxnMVKj6rDxdh6Fh7N0B0BZV2e7XvRDulXQEoiI EyJRnyO/EXKzCPz2xtZMwVJRs1kOhpzDsL1ISKKnIQBp4x/WiNphAJ0qD6U6zGf1oCA/ UffXhrdF83PF5k0iMuSLEY4qJIoeblknrWsBledXPZzG08d1iY6GPfrVc6be0E+QF1O5 H+SwalhmzTDbray4wVGA8QaBmwyS3DWGauEgj9Bnl+/nobszsOiVFrgkHoDmGkFA+htB ykf5i7+QxpDX4e1wh6djaTgoJBQhAj+ys4NRnxaYIbNBeYx34KoXkja5Em/bxxMS4LjQ CsSg== X-Gm-Message-State: AKS2vOzIPO8x+FEEyopwPH9A1O7BPS2Qe+rCI8+6LgIApVPXrSWci9x0 5bm9tygf6fc2H84z9NOk6DWtQ+o+kg== X-Received: by 10.55.128.199 with SMTP id b190mr20156495qkd.21.1496594879857; Sun, 04 Jun 2017 09:47:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170524154422.GA14778@lucon.org> From: "H.J. Lu" Date: Sun, 04 Jun 2017 16:47:00 -0000 Message-ID: Subject: Re: [PATCH] benchtests: Add more tests for memrchr To: Rajalakshmi Srinivasaraghavan Cc: GNU C Library Content-Type: multipart/mixed; boundary="94eb2c06632a2fe74a0551252674" X-SW-Source: 2017-06/txt/msg00173.txt.bz2 --94eb2c06632a2fe74a0551252674 Content-Type: text/plain; charset="UTF-8" Content-length: 1373 On Thu, May 25, 2017 at 12:17 AM, Rajalakshmi Srinivasaraghavan wrote: > > > On 05/24/2017 09:14 PM, H.J. Lu wrote: >> >> FOR_EACH_IMPL (impl, 0) >> do_one_test (impl, (CHAR *) (buf + align), seek_char, len, result); >> @@ -143,11 +144,27 @@ test_main (void) >> do_test (i, 64, 256, 23); >> do_test (0, 16 << i, 2048, 0); >> do_test (i, 64, 256, 0); >> +#ifdef USE_AS_MEMRCHR >> + /* Also test the position close to the beginning for memrchr. */ >> + do_test (0, i, 256, 23); >> + do_test (0, i, 256, 0); >> + do_test (i, i, 256, 23); >> + do_test (i, i, 256, 0); >> +#endif >> } >> for (i = 1; i < 32; ++i) >> { >> do_test (0, i, i + 1, 23); >> do_test (0, i, i + 1, 0); >> + do_test (i, i, i + 1, 23); >> + do_test (i, i, i + 1, 0); >> +#ifdef USE_AS_MEMRCHR >> + /* Also test the position close to the beginning for memrchr. */ >> + do_test (0, 1, i + 1, 23); >> + do_test (0, 2, i + 1, 0); >> + do_test (i, i, i + 1, 23); >> + do_test (i, i, i + 1, 0); > > > The above two lines are repeating, instead of > do_test (i, 1, i + 1, 23); > do_test (i, 2, i + 1, 0); > > LGTM with the above change. > > >> +#endif >> } >> >> return ret; >> -- 2.9.4 >> This is what I am going to check in. Thanks. -- H.J. --94eb2c06632a2fe74a0551252674 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-benchtests-Add-more-tests-for-memrchr.patch" Content-Disposition: attachment; filename="0001-benchtests-Add-more-tests-for-memrchr.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j3ixxrbf0 Content-length: 3242 RnJvbSA2YjY5Zjk4ZGNkMzRkNjNlNTA3Y2FlMWQ4YmZlODNlYThkNTk3ODMw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IFN1biwgNCBKdW4gMjAxNyAwOTo0 NDo0OCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGJlbmNodGVzdHM6IEFkZCBt b3JlIHRlc3RzIGZvciBtZW1yY2hyCgpiZW5jaC1tZW1jaHIuYyBpcyBzaGFy ZWQgd2l0aCBiZW5jaC1tZW1yY2hyLmMuICBUaGlzIHBhdGNoIGFkZHMgc29t ZQp0ZXN0cyBmb3IgcG9zaXRpb25zIGNsb3NlIHRvIHRoZSBiZWdpbm5pbmcg Zm9yIG1lbXJjaHIsIHdoaWNoIGFyZQplcXVpdmFsZW50IHRvIHBvc2l0aW9u cyBjbG9zZSB0byB0aGUgZW5kIGZvciBtZW1jaHIuCgoJKiBiZW5jaHRlc3Rz L2JlbmNoLW1lbWNoci5jIChkb190ZXN0KTogUHJpbnQgb3V0IGJvdGggbGVu Z3RoCglhbmQgcG9zaXRpb24uCgkodGVzdF9tYWluKTogQWxzbyB0ZXN0IHRo ZSBwb3NpdGlvbiBjbG9zZSB0byB0aGUgYmVnaW5uaW5nIGZvcgoJbWVtcmNo ci4KLS0tCiBDaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgIDcgKysrKysr KwogYmVuY2h0ZXN0cy9iZW5jaC1tZW1jaHIuYyB8IDE3ICsrKysrKysrKysr KysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VM b2cKaW5kZXggMDU1ZTdhZi4uOWU4MjRkNSAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDE3LTA2 LTA0ICBILkouIEx1ICA8aG9uZ2ppdS5sdUBpbnRlbC5jb20+CisKKwkqIGJl bmNodGVzdHMvYmVuY2gtbWVtY2hyLmMgKGRvX3Rlc3QpOiBQcmludCBvdXQg Ym90aCBsZW5ndGgKKwlhbmQgcG9zaXRpb24uCisJKHRlc3RfbWFpbik6IEFs c28gdGVzdCB0aGUgcG9zaXRpb24gY2xvc2UgdG8gdGhlIGJlZ2lubmluZyBm b3IKKwltZW1yY2hyLgorCiAyMDE3LTA2LTA0ICBaYWNrIFdlaW5iZXJnICA8 emFja3dAcGFuaXguY29tPgogCiAJKiBuaXMvbmlzX2FkZC5jLCBuaXMvbmlz X2FkZG1lbWJlci5jLCBuaXMvbmlzX2NhbGwuYwpkaWZmIC0tZ2l0IGEvYmVu Y2h0ZXN0cy9iZW5jaC1tZW1jaHIuYyBiL2JlbmNodGVzdHMvYmVuY2gtbWVt Y2hyLmMKaW5kZXggMTYwOTlhYy4uOTJiNWI3ZiAxMDA2NDQKLS0tIGEvYmVu Y2h0ZXN0cy9iZW5jaC1tZW1jaHIuYworKysgYi9iZW5jaHRlc3RzL2JlbmNo LW1lbWNoci5jCkBAIC0xMTcsNyArMTE3LDggQEAgZG9fdGVzdCAoc2l6ZV90 IGFsaWduLCBzaXplX3QgcG9zLCBzaXplX3QgbGVuLCBpbnQgc2Vla19jaGFy KQogICAgICAgYnVmW2FsaWduICsgbGVuXSA9IHNlZWtfY2hhcjsKICAgICB9 CiAKLSAgcHJpbnRmICgiTGVuZ3RoICU0emQsIGFsaWdubWVudCAlMnpkOiIs IHBvcywgYWxpZ24pOworICBwcmludGYgKCJMZW5ndGggJTR6ZCwgcG9zaXRp b24gJTR6ZCwgYWxpZ25tZW50ICUyemQ6IiwKKwkgIGxlbiwgcG9zLCBhbGln bik7CiAKICAgRk9SX0VBQ0hfSU1QTCAoaW1wbCwgMCkKICAgICBkb19vbmVf dGVzdCAoaW1wbCwgKENIQVIgKikgKGJ1ZiArIGFsaWduKSwgc2Vla19jaGFy LCBsZW4sIHJlc3VsdCk7CkBAIC0xNDMsMTEgKzE0NCwyNSBAQCB0ZXN0X21h aW4gKHZvaWQpCiAgICAgICBkb190ZXN0IChpLCA2NCwgMjU2LCAyMyk7CiAg ICAgICBkb190ZXN0ICgwLCAxNiA8PCBpLCAyMDQ4LCAwKTsKICAgICAgIGRv X3Rlc3QgKGksIDY0LCAyNTYsIDApOworI2lmZGVmIFVTRV9BU19NRU1SQ0hS CisgICAgICAvKiBBbHNvIHRlc3QgdGhlIHBvc2l0aW9uIGNsb3NlIHRvIHRo ZSBiZWdpbm5pbmcgZm9yIG1lbXJjaHIuICAqLworICAgICAgZG9fdGVzdCAo MCwgaSwgMjU2LCAyMyk7CisgICAgICBkb190ZXN0ICgwLCBpLCAyNTYsIDAp OworICAgICAgZG9fdGVzdCAoaSwgaSwgMjU2LCAyMyk7CisgICAgICBkb190 ZXN0IChpLCBpLCAyNTYsIDApOworI2VuZGlmCiAgICAgfQogICBmb3IgKGkg PSAxOyBpIDwgMzI7ICsraSkKICAgICB7CiAgICAgICBkb190ZXN0ICgwLCBp LCBpICsgMSwgMjMpOwogICAgICAgZG9fdGVzdCAoMCwgaSwgaSArIDEsIDAp OworICAgICAgZG9fdGVzdCAoaSwgaSwgaSArIDEsIDIzKTsKKyAgICAgIGRv X3Rlc3QgKGksIGksIGkgKyAxLCAwKTsKKyNpZmRlZiBVU0VfQVNfTUVNUkNI UgorICAgICAgLyogQWxzbyB0ZXN0IHRoZSBwb3NpdGlvbiBjbG9zZSB0byB0 aGUgYmVnaW5uaW5nIGZvciBtZW1yY2hyLiAgKi8KKyAgICAgIGRvX3Rlc3Qg KDAsIDEsIGkgKyAxLCAyMyk7CisgICAgICBkb190ZXN0ICgwLCAyLCBpICsg MSwgMCk7CisjZW5kaWYKICAgICB9CiAKICAgcmV0dXJuIHJldDsKLS0gCjIu OS40Cgo= --94eb2c06632a2fe74a0551252674--