From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by sourceware.org (Postfix) with ESMTPS id 18B95384AB4D for ; Thu, 25 Apr 2024 15:09:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18B95384AB4D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18B95384AB4D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714057751; cv=none; b=npdAjEe+Nl3doOZkp4vjQgyI5/sQjhdC1GDfiog12eL9kgn6Cziqu0K236DMSkZzCjfhI9OUE/6W2fbJmxEd9srrUOH42+4acIJSfSKF9uzb7nPrTDmNes4u0anP0uZcCiuHQmuC0VWl6DH9XsSlRj2cnxCqDdNYYStUksbij2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714057751; c=relaxed/simple; bh=M24YM+j4N16GmdDaDnJ0KndbEKAO2l0fr34cfEqvXVY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=TYwW4b/81R0kyHWREO6qfMAR12O10JT/6+ZrmS0DqScgPgm5rjZECpr9stDdCZ3necT0HJKSKqt70PNNcDlQ2Q9KomVUn38xAcGgTS8TyRqUFDTQjZRn8e3Fbu5EVsBm1A0JvNLmMGmotcWFkHGYy/L6nZZgadRGJUHpA9thK40= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5acfba298d5so488743eaf.2 for ; Thu, 25 Apr 2024 08:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714057745; x=1714662545; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZmJEIVzyjvPKHSwUVLOg+wR8e5FbwR8wfSuvB4n4L6Y=; b=NdjHrfwfvYOUOBywAv60QKf2pTP9AWOhqseLuCBaHS4oSQ27WltDE/OOUcNTwWQdCj 4jQrun1fqyA1jf2ZwD8BvgCOopDoSQ2rTrGAzo/9vd0sDBacpFiJlVCqdeY799sRaKyu sr5OcieAjozws0qZZQLvahTZOwSpXcXoeHK5xJCIANidi3IkfdIIeTpf7+rW36pg846B xfqJvKt24bd8b/NHyyAfpR0UvWEeFXQ5kRfHVATX/WViAc/TDpji3P+4R5g9jKUOt8Bl ZB5u9juquNunHxZ0dVFAMfGycZ47qTBJjlbznceyTa49Y2hVCWbZeE6wtqPlPzKfaQhx 7KJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057745; x=1714662545; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZmJEIVzyjvPKHSwUVLOg+wR8e5FbwR8wfSuvB4n4L6Y=; b=s/7dfnhSoVdjl97iwdrW5YF7VXAW6QzyIBbOMTe0AHXnQvst6Wa3LjW0kS3vtskJPY +5E7DntBUxCKEiAQB+hmeLiNzt/vNYc4EhqSGyrIC4F9mblw/bKcAfcWwvZoXvnPkB3U dY5tnifQR6scMhhgtyKjOm16fJ4efWC21p2x6h03wVEMUKlmAuCswHDjDZypmCzmLrOy jTCLFy7ntQdgPT4Wq5Ezlc0rsOX+eFD6or8+8qKCBti6tffTiBYbx/vMDeG0cLF6vaUE iVZ/qfNJ56Amx8hMITatsrPv/ASj0fH31tv0vVllwNpypvLPKHFMVKGxWRX8qbejyXVR 0+4Q== X-Gm-Message-State: AOJu0YwtiSJWwxRT/PnSTQ0XdjFetecwGmAn5WairaT7wZTIDIXgQatg 9LuNad5XjvJRzMhidx7kJWCW25wfsv+hy1zkH9LXUDLf7P4RLNSYgqlF16SKrnYdVMIXJzLjr/h xdEIRdRoZX4Ku1l8nMLZe9Jw7xofxgDkz X-Google-Smtp-Source: AGHT+IH5qFVqV3nIOgi5Dl5qhu0/geqKZG3/A0g3st4SWj3jnzdFPpFDAh3KGJ/HWo8fX0W8D6OmO2tiZMXjFX2iaMQ= X-Received: by 2002:a05:6358:e803:b0:18d:9114:eb1e with SMTP id gi3-20020a056358e80300b0018d9114eb1emr4475271rwb.22.1714057745195; Thu, 25 Apr 2024 08:09:05 -0700 (PDT) MIME-Version: 1.0 References: <20240425145425.309747-1-hjl.tools@gmail.com> <87wmol4hdi.fsf@oldenburg.str.redhat.com> In-Reply-To: <87wmol4hdi.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Thu, 25 Apr 2024 08:08:29 -0700 Message-ID: Subject: Re: [PATCH v2] elf: Also compile dl-misc.os with $(rtld-early-cflags) To: Florian Weimer Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 25, 2024 at 8:00=E2=80=AFAM Florian Weimer = wrote: > > * H. J. Lu: > > > Also compile dl-misc.os with $(rtld-early-cflags) to avoid > > > > Program received signal SIGILL, Illegal instruction. > > 0x00007ffff7fd36ea in _dl_strtoul (nptr=3Dnptr@entry=3D0x7fffffffe2c9 "= 2", > > endptr=3Dendptr@entry=3D0x7fffffffd728) at dl-misc.c:156 > > 156 bool positive =3D true; > > (gdb) bt > > #0 0x00007ffff7fd36ea in _dl_strtoul (nptr=3Dnptr@entry=3D0x7fffffffe= 2c9 "2", > > endptr=3Dendptr@entry=3D0x7fffffffd728) at dl-misc.c:156 > > #1 0x00007ffff7fdb1a9 in tunable_initialize ( > > cur=3Dcur@entry=3D0x7ffff7ffbc00 , > > strval=3Dstrval@entry=3D0x7fffffffe2c9 "2", len=3Dlen@entry=3D1) > > at dl-tunables.c:131 > > #2 0x00007ffff7fdb3a2 in parse_tunables (valstring=3D) > > at dl-tunables.c:258 > > #3 0x00007ffff7fdb5d9 in __GI___tunables_init (envp=3D0x7fffffffdd58) > > at dl-tunables.c:288 > > #4 0x00007ffff7fe44c3 in _dl_sysdep_start ( > > start_argptr=3Dstart_argptr@entry=3D0x7fffffffdcb0, > > dl_main=3Ddl_main@entry=3D0x7ffff7fe5f80 ) > > at ../sysdeps/unix/sysv/linux/dl-sysdep.c:110 > > #5 0x00007ffff7fe5cae in _dl_start_final (arg=3D0x7fffffffdcb0) at rt= ld.c:494 > > #6 _dl_start (arg=3D0x7fffffffdcb0) at rtld.c:581 > > #7 0x00007ffff7fe4b38 in _start () > > (gdb) > > > > when glibc is compiled with APX. > > Maybe mention setting GLIBC_TUNABLES as the trigger in the commit > message? > Done: https://patchwork.sourceware.org/project/glibc/list/?series=3D33163 > Otherwise: > > Reviewed-by: Florian Weimer > > Thanks, > Florian > --=20 H.J.