From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id 4DFB4388CC18 for ; Thu, 6 May 2021 18:04:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4DFB4388CC18 Received: by mail-oi1-x22e.google.com with SMTP id b25so1054100oic.0 for ; Thu, 06 May 2021 11:04:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OFwWBnLoXIVdoaI2ucmYNVJK9Kck8qrHivb14e7QdjY=; b=r7I5EuCemSKfSbOyGN7OAKknXcB+CssnbcOKe0UF0eHX/BQiTMdFMsfK2nClHGM0AA hqzQKH21dxe0o65EiJbBsrlNinY+etpqviRgtHQGMOhUyYhWDyyTt/49KF0fAmEo8Qm+ MAF1ONJsnACPzyG9SqgupwpD+AL+uKJtNSuOCJD28x+a/jFdd88Kog4N01MADPWGG0nN 6B/WbgElPDsPeuDFRcthyJp3MjjDU85/mb5xF9N7RSA6r5CRg/r+IECt4QG0F2r7k5ud XlfAlv97bxcBcCGw0LRNukBJROIbNWZnWUWne2Q4DqSCTCUrC1WPgLVl51vWNmi/uSwv L8ew== X-Gm-Message-State: AOAM532w6skQaXPDA2bcOdBAUaWhY+H195Ps+9uloaKPJucofq6WjX5h uciiLpRfJTbukD+ooyDSOIVfWbtOVW/QU9WmFKA= X-Google-Smtp-Source: ABdhPJzrOpQLjoS9bn1GbpB5X2zhWEa2NraSkLcDsqDh4bu6upXjk1Z4VoZS0pw7liTXUwPf065L5lsPQtQTCq9J3ow= X-Received: by 2002:aca:dd82:: with SMTP id u124mr11650236oig.35.1620324290396; Thu, 06 May 2021 11:04:50 -0700 (PDT) MIME-Version: 1.0 References: <20210226211507.3430032-1-hjl.tools@gmail.com> <871rajhon4.fsf@oldenburg.str.redhat.com> In-Reply-To: <871rajhon4.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Thu, 6 May 2021 11:04:14 -0700 Message-ID: Subject: [PATCH v2] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477] To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Content-Type: multipart/mixed; boundary="000000000000c02e1405c1ad25a8" X-Spam-Status: No, score=-3034.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 18:04:52 -0000 --000000000000c02e1405c1ad25a8 Content-Type: text/plain; charset="UTF-8" On Thu, May 6, 2021 at 8:23 AM Florian Weimer wrote: > > * H. J. Lu via Libc-alpha: > > > diff --git a/iconv/Makefile b/iconv/Makefile > > index 659857dd8c..4af3eea0d8 100644 > > --- a/iconv/Makefile > > +++ b/iconv/Makefile > > @@ -95,11 +95,13 @@ $(inst_bindir)/iconv: $(objpfx)iconv_prog $(+force) > > $(objpfx)iconv_prog: $(iconv_prog-modules:%=$(objpfx)%.o) > > $(objpfx)iconvconfig: $(iconvconfig-modules:%=$(objpfx)%.o) > > > > -$(objpfx)test-iconvconfig.out: /dev/null $(objpfx)iconvconfig > > +$(objpfx)test-iconvconfig.out: $(objpfx)iconvconfig > > (set -e; \ > > tmp=$(objpfx)gconv-modules.cache.$$$$; \ > > rm -f $$tmp; \ > > - $(make-test-out) --output=$$tmp --nostdlib $(inst_gconvdir); \ > > + $(built-program-cmd-before-env) \ > > + $(run-program-env) $(built-program-cmd-after-env) $< \ > > + --output=$$tmp --nostdlib $(inst_gconvdir); \ > > cmp $$tmp $(inst_gconvdir)/gconv-modules.cache; \ > > rm -f $$tmp) > $@; \ > > $(evaluate-test) > > Should tests use $(test-wrapper-env) instead of $(run-program-env) I think we should use $(run-program-prefix) $(objpfx)iconvconfig > $(built-program-cmd-after-env)? I think it's commonly used (mostly > along with shell scripts though). > > Thanks, > Florian > Here is the v2 patch. -- H.J. --000000000000c02e1405c1ad25a8 Content-Type: text/x-patch; charset="US-ASCII"; name="v2-0001-Run-objpfx-iconvconfig-with-run-program-prefix-BZ.patch" Content-Disposition: attachment; filename="v2-0001-Run-objpfx-iconvconfig-with-run-program-prefix-BZ.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kod76pwu0 RnJvbSAzZWVjZDA0ZGU3NTFhMGQ2ZGYwMDdkYTY4MjZlN2RhYTRjNzYwOWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IEZyaSwgMjYgRmViIDIwMjEgMTM6MDc6MTggLTA4MDAKU3ViamVjdDogW1BBVENIIHYyXSBSdW4g JChvYmpwZngpaWNvbnZjb25maWcgd2l0aCAkKHJ1bi1wcm9ncmFtLXByZWZpeCkgW0JaCiAjMjc0 NzddCgpXaGVuIGdsaWJjIGlzIGNvbmZpZ3VyZWQgd2l0aCAtLWVuYWJsZS1oYXJkY29kZWQtcGF0 aC1pbi10ZXN0cywKIm1ha2UgeGNoZWNrIiBmYWlsZWQgd2l0aAoKLi4uCmVudiBHQ09OVl9QQVRI PS9leHBvcnQvYnVpbGQvZ251L3Rvb2xzLWJ1aWxkL2dsaWJjLWNldC1naXRsYWIvYnVpbGQteDg2 XzY0LWxpbnV4L2ljb252ZGF0YSBMT0NQQVRIPS9leHBvcnQvYnVpbGQvZ251L3Rvb2xzLWJ1aWxk L2dsaWJjLWNldC1naXRsYWIvYnVpbGQteDg2XzY0LWxpbnV4L2xvY2FsZWRhdGEgTENfQUxMPUMg IC9leHBvcnQvYnVpbGQvZ251L3Rvb2xzLWJ1aWxkL2dsaWJjLWNldC1naXRsYWIvYnVpbGQteDg2 XzY0LWxpbnV4L2ljb252L2ljb252Y29uZmlnICAtLW91dHB1dD0kdG1wIC0tbm9zdGRsaWIgL3Vz ci9saWI2NC9nY29udjsKLi4uCi9leHBvcnQvYnVpbGQvZ251L3Rvb2xzLWJ1aWxkL2dsaWJjLWNl dC1naXRsYWIvYnVpbGQteDg2XzY0LWxpbnV4L2ljb252L2ljb252Y29uZmlnOiAvbGliNjQvbGli Yy5zby42OiB2ZXJzaW9uIGBHTElCQ18yLjM0JyBub3QgZm91bmQgKHJlcXVpcmVkIGJ5IC9leHBv cnQvYnVpbGQvZ251L3Rvb2xzLWJ1aWxkL2dsaWJjLWNldC1naXRsYWIvYnVpbGQteDg2XzY0LWxp bnV4L2ljb252L2ljb252Y29uZmlnKQouLi4KRkFJTDogaWNvbnYvdGVzdC1pY29udmNvbmZpZwoK U2luY2UgJChvYmpwZngpaWNvbnZjb25maWcgaXMgYW4gaW5zdGFsbGVkIHByb2dyYW0sIHJ1biBp dCB3aXRoCiQocnVuLXByb2dyYW0tcHJlZml4KS4KLS0tCiBpY29udi9NYWtlZmlsZSB8IDUgKysr LS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvaWNvbnYvTWFrZWZpbGUgYi9pY29udi9NYWtlZmlsZQppbmRleCA2NTk4NTdkZDhj Li5hOWIyNjdjODUxIDEwMDY0NAotLS0gYS9pY29udi9NYWtlZmlsZQorKysgYi9pY29udi9NYWtl ZmlsZQpAQCAtOTUsMTEgKzk1LDEyIEBAICQoaW5zdF9iaW5kaXIpL2ljb252OiAkKG9ianBmeClp Y29udl9wcm9nICQoK2ZvcmNlKQogJChvYmpwZngpaWNvbnZfcHJvZzogJChpY29udl9wcm9nLW1v ZHVsZXM6JT0kKG9ianBmeCklLm8pCiAkKG9ianBmeClpY29udmNvbmZpZzogJChpY29udmNvbmZp Zy1tb2R1bGVzOiU9JChvYmpwZngpJS5vKQogCi0kKG9ianBmeCl0ZXN0LWljb252Y29uZmlnLm91 dDogL2Rldi9udWxsICQob2JqcGZ4KWljb252Y29uZmlnCiskKG9ianBmeCl0ZXN0LWljb252Y29u ZmlnLm91dDogJChvYmpwZngpaWNvbnZjb25maWcKIAkoc2V0IC1lOyBcCiAJIHRtcD0kKG9ianBm eClnY29udi1tb2R1bGVzLmNhY2hlLiQkJCQ7IFwKIAkgcm0gLWYgJCR0bXA7IFwKLQkgJChtYWtl LXRlc3Qtb3V0KSAtLW91dHB1dD0kJHRtcCAtLW5vc3RkbGliICQoaW5zdF9nY29udmRpcik7IFwK KwkgJChydW4tcHJvZ3JhbS1wcmVmaXgpICQob2JqcGZ4KWljb252Y29uZmlnIFwKKwkJLS1vdXRw dXQ9JCR0bXAgLS1ub3N0ZGxpYiAkKGluc3RfZ2NvbnZkaXIpOyBcCiAJIGNtcCAkJHRtcCAkKGlu c3RfZ2NvbnZkaXIpL2djb252LW1vZHVsZXMuY2FjaGU7IFwKIAkgcm0gLWYgJCR0bXApID4gJEA7 IFwKIAkkKGV2YWx1YXRlLXRlc3QpCi0tIAoyLjMxLjEKCg== --000000000000c02e1405c1ad25a8--