Re: [PATCH 1/2] stdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638)

["H.J. Lu" <hjl.tools@gmail.com>]

On Thu, Sep 29, 2022 at 12:28 PM Adhemerval Zanella via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Using an unsigned type prevents the fallback to be used if kernel
> does not support getrandom syscall.
>
> Checked on x86_64-linux-gnu.
> ---
>  stdlib/arc4random.c                  | 2 +-
>  sysdeps/unix/sysv/linux/not-cancel.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/stdlib/arc4random.c b/stdlib/arc4random.c
> index e417ef624d..960a38f295 100644
> --- a/stdlib/arc4random.c
> +++ b/stdlib/arc4random.c
> @@ -34,7 +34,7 @@ void
>  __arc4random_buf (void *p, size_t n)
>  {
>    static int seen_initialized;
> -  size_t l;
> +  ssize_t l;
>    int fd;
>
>    if (n == 0)
> diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h
> index a263d294b1..cf35c8bfc9 100644
> --- a/sysdeps/unix/sysv/linux/not-cancel.h
> +++ b/sysdeps/unix/sysv/linux/not-cancel.h
> @@ -68,7 +68,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *iov, int iovcnt)
>    INTERNAL_SYSCALL_CALL (writev, fd, iov, iovcnt);
>  }
>
> -static inline int
> +static inline ssize_t

Shouldn't it be __syscall_slong_t?

>  __getrandom_nocancel (void *buf, size_t buflen, unsigned int flags)
>  {
>    return INLINE_SYSCALL_CALL (getrandom, buf, buflen, flags);
> --
> 2.34.1
>



-- 
H.J.