From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by sourceware.org (Postfix) with ESMTPS id BA2EC386F822; Tue, 29 Sep 2020 04:01:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BA2EC386F822 Received: by mail-io1-xd41.google.com with SMTP id z25so3399909iol.10; Mon, 28 Sep 2020 21:01:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5AjpkGm5awQIFBluctu0HZCztrS2fq7h7XVp39zK8m8=; b=YGphRFDRTlTQvlaqNsnTaw2yc7GzteadGybPEsiK7IXyOHMqv4hzg5fIYB7p7YMfwM 2H7PwdfFJaakjIGuxWxvZynQEEI6EGh5FzVQkadPDsl2dth+8oOUkue6QblEnJzBhrTD nowuadtpLqDOxJxebzGnwNRYQXXjSZQXTlSW632AxtnyrYezGYpZWUUywpdVjzyFDKMI N49dmRnx/NyUyCR18+knkUmj1rMEV4mV6e5sfEr14YF8njPEzoSW+yNQg1/LmsH8O/PL 7X+2UL7TcX4FH8S7cpIjsxZmy6RaxUutbgAjkzQJ9kZ2Ku1SVGmUU34LcN8r79w6Pqwk PKYw== X-Gm-Message-State: AOAM533TWi1dFkM9+/LnxU3JWpnGRlbSFU90msjmT/K52wJcz+Q0bDQT kllZQPjO2Z4Nol+2FSL17+If6+OVeCHOJjw4Vh9GSPe0HSg= X-Google-Smtp-Source: ABdhPJxL5e8/LV8LVLoBZNAARyf2dtnVSePb9vPRaz9deJJ+KD6zCnvzTKNsVfrJqWHKpkdHfUbKLPwUgxXlCAFPH+Y= X-Received: by 2002:a6b:b787:: with SMTP id h129mr1097968iof.202.1601352076001; Mon, 28 Sep 2020 21:01:16 -0700 (PDT) MIME-Version: 1.0 References: <20200918160709.949608-1-hjl.tools@gmail.com> <20200918160709.949608-3-hjl.tools@gmail.com> <87eemm6n37.fsf@oldenburg2.str.redhat.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 28 Sep 2020 21:00:40 -0700 Message-ID: Subject: V3 [PATCH] Set tunable value as well as min/max values To: Siddhesh Poyarekar Cc: Florian Weimer , "H.J. Lu via Libc-alpha" Content-Type: multipart/mixed; boundary="000000000000a6b2c405b06bd59e" X-Spam-Status: No, score=-3036.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2020 04:01:18 -0000 --000000000000a6b2c405b06bd59e Content-Type: text/plain; charset="UTF-8" On Mon, Sep 28, 2020 at 10:31 AM Siddhesh Poyarekar via Libc-alpha wrote: > > On 28/09/20 19:05, Florian Weimer via Libc-alpha wrote: > > I'm not sure if this change is philosophically correct as far as the > > tunables framework is concerned. I had thought the limits should be > > something static, so that they are consistent across systems. > > It seems like a good idea to support dynamic limits if they will always > be more restrictive than the most restrictive static limit one could > come up with for the tunable. I didn't exclude dynamic limits from a > design perspective; it's just that the tunables implemented at that time > didn't need them. > > There is a case to always have static bounds (at the minimum to ensure > that values don't overflow the underlying types) but that shouldn't > preclude more restrictive dynamic limits IMO. > > Bikeshed: maybe the macro should be called TUNABLE_SET_WITH_BOUNDS() > instead of TUNABLE_SET_ALL. > Here is the updated patch with TUNABLE_SET_WITH_BOUNDS. OK for master? Thanks. -- H.J. --000000000000a6b2c405b06bd59e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Set-tunable-value-as-well-as-min-max-values.patch" Content-Disposition: attachment; filename="0001-Set-tunable-value-as-well-as-min-max-values.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kfnfmxya0 RnJvbSAzNGM0NjNmMzdmNDZhYmNiMjI3OTE5NmRlZjk5MjVlOTc5N2U5ZWRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IE1vbiwgMSBKdW4gMjAyMCAxNDoxMTozMiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFNldCB0dW5h YmxlIHZhbHVlIGFzIHdlbGwgYXMgbWluL21heCB2YWx1ZXMKClNvbWUgdHVuYWJsZSB2YWx1ZXMg YW5kIHRoZWlyIG1pbmltdW0vbWF4aW11bSB2YWx1ZXMgbXVzdCBiZSBkZXRlcm1pbnRlZAphdCBy dW4tdGltZS4gIEFkZCBUVU5BQkxFX1NFVF9XSVRIX0JPVU5EUyBhbmQgVFVOQUJMRV9TRVRfV0lU SF9CT1VORFNfRlVMTAp0byB1cGRhdGUgdHVuYWJsZSB2YWx1ZSB0b2dldGhlciB3aXRoIG1pbmlt dW0gYW5kIG1heGltdW0gdmFsdWVzLgpfX3R1bmFibGVfc2V0X3ZhbCBpcyB1cGRhdGVkIHRvIHNl dCB0dW5hYmxlIHZhbHVlIGFzIHdlbGwgYXMgbWluL21heAp2YWx1ZXMuCi0tLQogZWxmL2RsLXR1 bmFibGVzLmMgICAgICB8IDE3ICsrKysrKysrKysrKy0tLS0tCiBlbGYvZGwtdHVuYWJsZXMuaCAg ICAgIHwgMjEgKysrKysrKysrKysrKysrKysrKy0tCiBtYW51YWwvUkVBRE1FLnR1bmFibGVzIHwg MjQgKysrKysrKysrKysrKysrKysrKysrKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDUzIGluc2VydGlv bnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZWxmL2RsLXR1bmFibGVzLmMgYi9l bGYvZGwtdHVuYWJsZXMuYwppbmRleCAyNmU2ZTI2NjEyLi5iNDQxNzRmZTcxIDEwMDY0NAotLS0g YS9lbGYvZGwtdHVuYWJsZXMuYworKysgYi9lbGYvZGwtdHVuYWJsZXMuYwpAQCAtMTAxLDEyICsx MDEsMTkgQEAgZ2V0X25leHRfZW52IChjaGFyICoqZW52cCwgY2hhciAqKm5hbWUsIHNpemVfdCAq bmFtZWxlbiwgY2hhciAqKnZhbCwKIH0pCiAKIHN0YXRpYyB2b2lkCi1kb190dW5hYmxlX3VwZGF0 ZV92YWwgKHR1bmFibGVfdCAqY3VyLCBjb25zdCB2b2lkICp2YWxwKQorZG9fdHVuYWJsZV91cGRh dGVfdmFsICh0dW5hYmxlX3QgKmN1ciwgY29uc3Qgdm9pZCAqdmFscCwKKwkJICAgICAgIGNvbnN0 IHZvaWQgKm1pbnAsIGNvbnN0IHZvaWQgKm1heHApCiB7CiAgIHVpbnQ2NF90IHZhbDsKIAogICBp ZiAoY3VyLT50eXBlLnR5cGVfY29kZSAhPSBUVU5BQkxFX1RZUEVfU1RSSU5HKQotICAgIHZhbCA9 ICooKGludDY0X3QgKikgdmFscCk7CisgICAgeworICAgICAgdmFsID0gKigoaW50NjRfdCAqKSB2 YWxwKTsKKyAgICAgIGlmIChtaW5wKQorCWN1ci0+dHlwZS5taW4gPSAqKChpbnQ2NF90ICopIG1p bnApOworICAgICAgaWYgKG1heHApCisJY3VyLT50eXBlLm1heCA9ICooKGludDY0X3QgKikgbWF4 cCk7CisgICAgfQogCiAgIHN3aXRjaCAoY3VyLT50eXBlLnR5cGVfY29kZSkKICAgICB7CkBAIC0x NTMsMTUgKzE2MCwxNSBAQCB0dW5hYmxlX2luaXRpYWxpemUgKHR1bmFibGVfdCAqY3VyLCBjb25z dCBjaGFyICpzdHJ2YWwpCiAgICAgICBjdXItPmluaXRpYWxpemVkID0gdHJ1ZTsKICAgICAgIHZh bHAgPSBzdHJ2YWw7CiAgICAgfQotICBkb190dW5hYmxlX3VwZGF0ZV92YWwgKGN1ciwgdmFscCk7 CisgIGRvX3R1bmFibGVfdXBkYXRlX3ZhbCAoY3VyLCB2YWxwLCBOVUxMLCBOVUxMKTsKIH0KIAog dm9pZAotX190dW5hYmxlX3NldF92YWwgKHR1bmFibGVfaWRfdCBpZCwgdm9pZCAqdmFscCkKK19f dHVuYWJsZV9zZXRfdmFsICh0dW5hYmxlX2lkX3QgaWQsIHZvaWQgKnZhbHAsIHZvaWQgKm1pbnAs IHZvaWQgKm1heHApCiB7CiAgIHR1bmFibGVfdCAqY3VyID0gJnR1bmFibGVfbGlzdFtpZF07CiAK LSAgZG9fdHVuYWJsZV91cGRhdGVfdmFsIChjdXIsIHZhbHApOworICBkb190dW5hYmxlX3VwZGF0 ZV92YWwgKGN1ciwgdmFscCwgbWlucCwgbWF4cCk7CiB9CiAKICNpZiBUVU5BQkxFU19GUk9OVEVO RCA9PSBUVU5BQkxFU19GUk9OVEVORF92YWxzdHJpbmcKZGlmZiAtLWdpdCBhL2VsZi9kbC10dW5h Ymxlcy5oIGIvZWxmL2RsLXR1bmFibGVzLmgKaW5kZXggZjA1ZWI1MGMyZi4uNTUwYjBjYzdmNCAx MDA2NDQKLS0tIGEvZWxmL2RsLXR1bmFibGVzLmgKKysrIGIvZWxmL2RsLXR1bmFibGVzLmgKQEAg LTcwLDkgKzcwLDEwIEBAIHR5cGVkZWYgc3RydWN0IF90dW5hYmxlIHR1bmFibGVfdDsKIAogZXh0 ZXJuIHZvaWQgX190dW5hYmxlc19pbml0IChjaGFyICoqKTsKIGV4dGVybiB2b2lkIF9fdHVuYWJs ZV9nZXRfdmFsICh0dW5hYmxlX2lkX3QsIHZvaWQgKiwgdHVuYWJsZV9jYWxsYmFja190KTsKLWV4 dGVybiB2b2lkIF9fdHVuYWJsZV9zZXRfdmFsICh0dW5hYmxlX2lkX3QsIHZvaWQgKik7CitleHRl cm4gdm9pZCBfX3R1bmFibGVfc2V0X3ZhbCAodHVuYWJsZV9pZF90LCB2b2lkICosIHZvaWQgKiwg dm9pZCAqKTsKIHJ0bGRfaGlkZGVuX3Byb3RvIChfX3R1bmFibGVzX2luaXQpCiBydGxkX2hpZGRl bl9wcm90byAoX190dW5hYmxlX2dldF92YWwpCitydGxkX2hpZGRlbl9wcm90byAoX190dW5hYmxl X3NldF92YWwpCiAKIC8qIERlZmluZSBUVU5BQkxFX0dFVCBhbmQgVFVOQUJMRV9TRVQgaW4gc2hv cnQgZm9ybSBpZiBUT1BfTkFNRVNQQUNFIGFuZAogICAgVFVOQUJMRV9OQU1FU1BBQ0UgYXJlIGRl ZmluZWQuICBUaGlzIGlzIHVzZWZ1bCBzaG9ydGhhbmQgdG8gZ2V0IGFuZCBzZXQKQEAgLTgyLDEx ICs4MywxOCBAQCBydGxkX2hpZGRlbl9wcm90byAoX190dW5hYmxlX2dldF92YWwpCiAgIFRVTkFC TEVfR0VUX0ZVTEwgKFRPUF9OQU1FU1BBQ0UsIFRVTkFCTEVfTkFNRVNQQUNFLCBfX2lkLCBfX3R5 cGUsIF9fY2IpCiAjIGRlZmluZSBUVU5BQkxFX1NFVChfX2lkLCBfX3R5cGUsIF9fdmFsKSBcCiAg IFRVTkFCTEVfU0VUX0ZVTEwgKFRPUF9OQU1FU1BBQ0UsIFRVTkFCTEVfTkFNRVNQQUNFLCBfX2lk LCBfX3R5cGUsIF9fdmFsKQorIyBkZWZpbmUgVFVOQUJMRV9TRVRfV0lUSF9CT1VORFMoX19pZCwg X190eXBlLCBfX3ZhbCwgX19taW4sIF9fbWF4KSBcCisgIFRVTkFCTEVfU0VUX1dJVEhfQk9VTkRT X0ZVTEwgKFRPUF9OQU1FU1BBQ0UsIFRVTkFCTEVfTkFNRVNQQUNFLCBfX2lkLCBcCisJCQkJX190 eXBlLCBfX3ZhbCwgX19taW4sIF9fbWF4KQogI2Vsc2UKICMgZGVmaW5lIFRVTkFCTEVfR0VUKF9f dG9wLCBfX25zLCBfX2lkLCBfX3R5cGUsIF9fY2IpIFwKICAgVFVOQUJMRV9HRVRfRlVMTCAoX190 b3AsIF9fbnMsIF9faWQsIF9fdHlwZSwgX19jYikKICMgZGVmaW5lIFRVTkFCTEVfU0VUKF9fdG9w LCBfX25zLCBfX2lkLCBfX3R5cGUsIF9fdmFsKSBcCiAgIFRVTkFCTEVfU0VUX0ZVTEwgKF9fdG9w LCBfX25zLCBfX2lkLCBfX3R5cGUsIF9fdmFsKQorIyBkZWZpbmUgVFVOQUJMRV9TRVRfV0lUSF9C T1VORFMoX190b3AsIF9fbnMsIF9faWQsIF9fdHlwZSwgX192YWwsIFwKKwkJCQkgX19taW4sIF9f bWF4KSBcCisgIFRVTkFCTEVfU0VUX1dJVEhfQk9VTkRTX0ZVTEwgKF9fdG9wLCBfX25zLCBfX2lk LCBfX3R5cGUsIF9fdmFsLCBcCisJCQkJX19taW4sIF9fbWF4KQogI2VuZGlmCiAKIC8qIEdldCBh bmQgcmV0dXJuIGEgdHVuYWJsZSB2YWx1ZS4gIElmIHRoZSB0dW5hYmxlIHdhcyBzZXQgZXh0ZXJu YWxseSBhbmQgX19DQgpAQCAtMTAzLDcgKzExMSwxNiBAQCBydGxkX2hpZGRlbl9wcm90byAoX190 dW5hYmxlX2dldF92YWwpCiAjIGRlZmluZSBUVU5BQkxFX1NFVF9GVUxMKF9fdG9wLCBfX25zLCBf X2lkLCBfX3R5cGUsIF9fdmFsKSBcCiAoewkJCQkJCQkJCSAgICAgIFwKICAgX190dW5hYmxlX3Nl dF92YWwgKFRVTkFCTEVfRU5VTV9OQU1FIChfX3RvcCwgX19ucywgX19pZCksCQkgICAgICBcCi0J CQkmIChfX3R5cGUpIHtfX3ZhbH0pOwkJCQkgICAgICBcCisJCSAgICAgJiAoX190eXBlKSB7X192 YWx9LCBOVUxMLCBOVUxMKTsJCQkgICAgICBcCit9KQorCisvKiBTZXQgYSB0dW5hYmxlIHZhbHVl IHRvZ2V0aGVyIHdpdGggbWluL21heCB2YWx1ZXMuICAqLworIyBkZWZpbmUgVFVOQUJMRV9TRVRf V0lUSF9CT1VORFNfRlVMTChfX3RvcCwgX19ucywgX19pZCwgX190eXBlLCBfX3ZhbCwJICAgICAg XAorCQkJCSAgICAgIF9fbWluLCBfX21heCkJCQkgICAgICBcCisoewkJCQkJCQkJCSAgICAgIFwK KyAgX190dW5hYmxlX3NldF92YWwgKFRVTkFCTEVfRU5VTV9OQU1FIChfX3RvcCwgX19ucywgX19p ZCksCQkgICAgICBcCisJCSAgICAgJiAoX190eXBlKSB7X192YWx9LCAgJiAoX190eXBlKSB7X19t aW59LAkJICAgICAgXAorCQkgICAgICYgKF9fdHlwZSkge19fbWF4fSk7CQkJCSAgICAgIFwKIH0p CiAKIC8qIE5hbWVzcGFjZSBzYW5pdHkgZm9yIGNhbGxiYWNrIGZ1bmN0aW9ucy4gIFVzZSB0aGlz IG1hY3JvIHRvIGtlZXAgdGhlCmRpZmYgLS1naXQgYS9tYW51YWwvUkVBRE1FLnR1bmFibGVzIGIv bWFudWFsL1JFQURNRS50dW5hYmxlcwppbmRleCBmODdhMzFhNjVlLi5mZmY2YzJhODdlIDEwMDY0 NAotLS0gYS9tYW51YWwvUkVBRE1FLnR1bmFibGVzCisrKyBiL21hbnVhbC9SRUFETUUudHVuYWJs ZXMKQEAgLTY3LDcgKzY3LDcgQEAgVGhlIGxpc3Qgb2YgYWxsb3dlZCBhdHRyaWJ1dGVzIGFyZToK IAkJCQkgICAgIG5vbi1BVF9TRUNVUkUgc3VicHJvY2Vzc2VzLgogCQkJTk9ORTogUmVhZCBhbGwg dGhlIHRpbWUuCiAKLTIuIFVzZSBUVU5BQkxFX0dFVC9UVU5BQkxFX1NFVCB0byBnZXQgYW5kIHNl dCB0dW5hYmxlcy4KKzIuIFVzZSBUVU5BQkxFX0dFVC9UVU5BQkxFX1NFVC9UVU5BQkxFX1NFVF9X SVRIX0JPVU5EUyB0byBnZXQgYW5kIHNldCB0dW5hYmxlcy4KIAogMy4gT1BUSU9OQUw6IElmIHR1 bmFibGVzIGluIGEgbmFtZXNwYWNlIGFyZSBiZWluZyB1c2VkIG11bHRpcGxlIHRpbWVzIHdpdGhp biBhCiAgICBzcGVjaWZpYyBtb2R1bGUsIHNldCB0aGUgVFVOQUJMRV9OQU1FU1BBQ0UgbWFjcm8g dG8gcmVkdWNlIHRoZSBhbW91bnQgb2YKQEAgLTExMiw5ICsxMTIsMjkgQEAgZm9ybSBvZiB0aGUg bWFjcm9zIGFzIGZvbGxvd3M6CiB3aGVyZSAnZ2xpYmMnIGlzIHRoZSB0b3AgbmFtZXNwYWNlLCAn Y3B1JyBpcyB0aGUgdHVuYWJsZSBuYW1lc3BhY2UgYW5kIHRoZQogcmVtYWluaW5nIGFyZ3VtZW50 cyBhcmUgdGhlIHNhbWUgYXMgdGhlIHNob3J0IGZvcm0gbWFjcm9zLgogCitUaGUgbWluaW11bSBh bmQgbWF4aW11bSB2YWx1ZXMgY2FuIHVwZGF0ZWQgdG9nZXRoZXIgd2l0aCB0aGUgdHVuYWJsZSB2 YWx1ZQordXNpbmc6CisKKyAgVFVOQUJMRV9TRVRfV0lUSF9CT1VORFMgKGNoZWNrLCBpbnQzMl90 LCB2YWwsIG1pbiwgbWF4KQorCit3aGVyZSAnY2hlY2snIGlzIHRoZSB0dW5hYmxlIG5hbWUsICdp bnQzMl90JyBpcyB0aGUgQyB0eXBlIG9mIHRoZSB0dW5hYmxlLAorJ3ZhbCcgaXMgYSB2YWx1ZSBv ZiBzYW1lIHR5cGUsICdtaW4nIGFuZCAnbWF4JyBhcmUgdGhlIG1pbmltdW0gYW5kIG1heGltdW0K K3ZhbHVlcyBvZiB0aGUgdHVuYWJsZS4KKworVG8gc2V0IHRoZSBtaW5pbXVtIGFuZCBtYXhpbXVt IHZhbHVlcyBvZiB0dW5hYmxlcyBpbiBhIGRpZmZlcmVudCBuYW1lc3BhY2UKK2Zyb20gdGhhdCBt b2R1bGUsIHVzZSB0aGUgZnVsbCBmb3JtIG9mIHRoZSBtYWNyb3MgYXMgZm9sbG93czoKKworICB2 YWwgPSBUVU5BQkxFX0dFVF9GVUxMIChnbGliYywgY3B1LCBod2NhcF9tYXNrLCB1aW50NjRfdCwg TlVMTCkKKworICBUVU5BQkxFX1NFVF9XSVRIX0JPVU5EU19GVUxMIChnbGliYywgY3B1LCBod2Nh cF9tYXNrLCB1aW50NjRfdCwgdmFsLCBtaW4sIG1heCkKKword2hlcmUgJ2dsaWJjJyBpcyB0aGUg dG9wIG5hbWVzcGFjZSwgJ2NwdScgaXMgdGhlIHR1bmFibGUgbmFtZXNwYWNlIGFuZCB0aGUKK3Jl bWFpbmluZyBhcmd1bWVudHMgYXJlIHRoZSBzYW1lIGFzIHRoZSBzaG9ydCBmb3JtIG1hY3Jvcy4K KwogV2hlbiBUVU5BQkxFX05BTUVTUEFDRSBpcyBub3QgZGVmaW5lZCBpbiBhIG1vZHVsZSwgVFVO QUJMRV9HRVQgaXMgZXF1aXZhbGVudCB0bwogVFVOQUJMRV9HRVRfRlVMTCwgc28geW91IHdpbGwg bmVlZCB0byBwcm92aWRlIGZ1bGwgbmFtZXNwYWNlIGluZm9ybWF0aW9uIGZvcgotYm90aCBtYWNy b3MuICBMaWtld2lzZSBmb3IgVFVOQUJMRV9TRVQgYW5kIFRVTkFCTEVfU0VUX0ZVTEwuCitib3Ro IG1hY3Jvcy4gIExpa2V3aXNlIGZvciBUVU5BQkxFX1NFVCwgVFVOQUJMRV9TRVRfRlVMTCwKK1RV TkFCTEVfU0VUX1dJVEhfQk9VTkRTIGFuZCBUVU5BQkxFX1NFVF9XSVRIX0JPVU5EU19GVUxMLgog CiAqKiBJTVBPUlRBTlQgTk9URSAqKgogCi0tIAoyLjI2LjIKCg== --000000000000a6b2c405b06bd59e--