From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id 9B1663858D3C for ; Thu, 1 Sep 2022 16:50:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B1663858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x732.google.com with SMTP id g21so13735393qka.5 for ; Thu, 01 Sep 2022 09:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=xKY4+wtCqQoMlEVyN/p0/KO9LUicOYWWC0MSY5RmqHk=; b=py5TxUZyGiaBl1XNzFY9Qvf0nyQJCjwxuZgj4JlAPc8XDdaRlBxGTRF2tYqZhXiIsw TUBjeGx4FmRLXZVMwq7cYjb1R/p5HhtJytdDNxUvcd4x9pcWJZTW8U29zch6o1gE6a3M YJMEVv2Q1KF/fzAafxKKn77WiQ+EeMpO0oBoTBLF+P6DIYCHeK7FCFA43895w3287aOQ 5bQNgl6EZStz8H15BsCATxnL+Z1NwBhkb5isUT7/ImiuJ4m5zHMDXepMYBSRSlTXxdu6 8h0XDtSdCaQIXJmUA65S2wVI0XGTXly+r0hjI8379wuVaRCfzcl/HVgCrS4ALf4JMAOO fmTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=xKY4+wtCqQoMlEVyN/p0/KO9LUicOYWWC0MSY5RmqHk=; b=gilPR9ab0pAbrpuQGRElbf+tTNxQHmbRmhhhVWX0/aatSiXivisJ0aV2iUaHaggqM0 0IsspoYEitsQKgJV0Xh0ogshIGnQE820iptVE2zQI1QDpLiO0lSqE4WOzKasoBmpwS1U mfMQIy1/vxMta2TTD265eGfRuUf9v+eKwR9z0D3RIF4os+wqcEre3BEjPJjAaXhpv6sn SdZz/9+k3luFdAhGalGrVjpOdyiXFyoYCJaPxPywhty46pYH/g7XOJID76jQvafTKBNs BBUvi8u9z8n/+L7XbX543ECn0VNHwpj7vQwks0C7IjPE7tpxGPZUjPh59rCq7VxJETSY aKgA== X-Gm-Message-State: ACgBeo015s5nmU4Qdulbfl1MWLFcP0Y9lJTbnt3YDCy6hgH5YulNobwm di1kPHcMnBqoEN6ZrhB+FjCEmRmKEd8wbmK8P2A= X-Google-Smtp-Source: AA6agR5zFKKBHJLkWe7cu2cPYRvZFjMEWSJsBTZ960PsSfyzeZsv6RApANo2L5C3icVlKoAebICb4TlMuOM01SqaxKg= X-Received: by 2002:a05:620a:254d:b0:6ab:84b8:25eb with SMTP id s13-20020a05620a254d00b006ab84b825ebmr20146572qko.383.1662051017050; Thu, 01 Sep 2022 09:50:17 -0700 (PDT) MIME-Version: 1.0 References: <20220901130253.1684344-1-adhemerval.zanella@linaro.org> In-Reply-To: From: "H.J. Lu" Date: Thu, 1 Sep 2022 09:49:41 -0700 Message-ID: Subject: Re: [PATCH] math: x86: Use prefix for FP_INIT_ROUNDMODE To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 1, 2022 at 9:42 AM H.J. Lu wrote: > > On Thu, Sep 1, 2022 at 6:03 AM Adhemerval Zanella via Libc-alpha > wrote: > > > > Not all compilers support the inline asm prefix '%v' to emit the avx > > instruction if AVX is enable. Use a prefix instead. > > > > Checked on x86_64-linux-gnu and i686-linux-gnu. > > --- > > sysdeps/x86/fpu/sfp-machine.h | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/sysdeps/x86/fpu/sfp-machine.h b/sysdeps/x86/fpu/sfp-machine.h > > index 5892f4f5fe..006eebe257 100644 > > --- a/sysdeps/x86/fpu/sfp-machine.h > > +++ b/sysdeps/x86/fpu/sfp-machine.h > > @@ -39,9 +39,15 @@ typedef unsigned int UTItype __attribute__ ((mode (TI))); > > > > # define FP_RND_MASK 0x6000 > > > > +# ifdef __AVX__ > > +# define AVX_INSN_PREFIX "v" > > +# else > > +# define AVX_INSN_PREFIX "" > > +# endif > > + > > # define FP_INIT_ROUNDMODE \ > > do { \ > > - __asm__ __volatile__ ("%vstmxcsr\t%0" : "=m" (_fcw)); \ > > + __asm__ __volatile__ (AVX_INSN_PREFIX "stmxcsr\t%0" : "=m" (_fcw)); \ > > } while (0) > > #else > > # define _FP_W_TYPE_SIZE 32 > > -- > > 2.34.1 > > > > Should we use __builtin_ia32_stmxcsr instead? > __builtin_ia32_stmxcsr requires extra instructions. -- H.J.