From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by sourceware.org (Postfix) with ESMTPS id 978143849AEF for ; Sat, 13 Apr 2024 15:27:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 978143849AEF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 978143849AEF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713022062; cv=none; b=WftZuDQ8joivxlD842BzBW69U3lXVN5BYgJzTAdkDyNdRW5Sqqq5gP8gT8gRcJangQtOrwEa9Jy8GqQuN/zYMKRDV9wFt/LFK8ocfs3M1rdd6W/FWqa3r9OUC7mrZBfmTprM476G0MdL05E6WesVWXsqQzBQqaTtqtlkcHswKzs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713022062; c=relaxed/simple; bh=6d2Gmhj775Zgr4O86EM2LS+xMShl2Rf39MKvE7SFY2Y=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=sUvBoetiW2Pp9Mm8r0Q9ArHHNsaEHfINUNP6bR9Vvzo7vmg8Fgz0ZworIlhFqfRSwBh2fRBWHhrihlyGnIcn4vjIIs0mNoUnd8gSOFrL6yF0hKehVxD45UGQUiEH0JFRdJv+lPZa2Xh60gppWAMCxJkQ/VhWC2fuAxayhkBcDnU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-dbed0710c74so1535487276.1 for ; Sat, 13 Apr 2024 08:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713022057; x=1713626857; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7arwUg7u+GugsdsgHOkWb/o7YCuUCcQjsZALhJpUZUQ=; b=dHOo5YcM7ObwPnPK3XaHLhB0N2P7crpaoU5LQvITRd86yvD8g3NlnxTgUGa4aDq3Em 7Piwa/yPfv9KyM84biHkidomEfI2yY/VyPLItWAlaAa0/TnbZs8lIts9CnLOwY5A8UAj hPt7lVnYCvFb1wO29So2tNv1JuSQWNFTnSOUFm+4KdMi/5+s4PjBl5YTTwNKq44wVb3v Fhe8PxGzWg1Ddnvgl0dvUDUz2C/NJHR06hDP+3scARKLg32GOamy0BaM6tbpfYolhZok vs50eEtN5ZWhG8xhhU65k9W4kt54Hmp5lo7iCOdA+bQMrIBiN6X4lWwi/g4lpUPP42bN va1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713022057; x=1713626857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7arwUg7u+GugsdsgHOkWb/o7YCuUCcQjsZALhJpUZUQ=; b=WaSBLt+Hd8k1g1xuYsyRoeB3MOvJJG2UZXB/GevlteiOaFjEg+kKYE8BnMif93/3Ij YCiL5cjApuIG8w9l1YUBBm3zrMCoC6E6W98vqubBXeQhjgDUZP9ecrVEw//g6xdzHFmv WtPlloGWmRKQ7g86hUQcoi61W8G64n1e56dL1weI9UVdqGSPI3deojrv/TQZ/4jlH8W7 7LNHfKUe4ne9km+fmEVVLIn76NKYbaw7XfXY/z2kY2LGAPkL76iF4Ekfo8REoa8AlEiC EwXPDtyAvwZ6hpesxLIA8K0pwGk1pe7DTdpBV4lABk25DbP+henrFcJADmTIKnCuOqxQ TA7w== X-Gm-Message-State: AOJu0Yzxg/9Z9Edcc2+MV0ZAUtPiqMQMSanLpAiDcAWx/U7rwYpesZlU 3TUcXWKDqDhsZDaXZJh0eseCTn8RPcHUUSS5SbYGJhD2s0TvXwclalaarxgYe5+JDDupB55NqvZ Y8r8rzVTUb44pQELjqtLPsVM4oXEQBZ6A X-Google-Smtp-Source: AGHT+IH70xdX1pIHI05USLv3L7DrCicTkhpT/a9sF8mPDMlepJJ7ZS69oS9HY97uQ0pJ5+3MXziRfEA/KWwrPDaXfac= X-Received: by 2002:a25:d3c2:0:b0:dc7:4cb1:6817 with SMTP id e185-20020a25d3c2000000b00dc74cb16817mr5745513ybf.22.1713022056911; Sat, 13 Apr 2024 08:27:36 -0700 (PDT) MIME-Version: 1.0 References: <87a5lx2u9a.fsf@oldenburg.str.redhat.com> <875xwl2tku.fsf@oldenburg.str.redhat.com> <871q792ssr.fsf@oldenburg.str.redhat.com> In-Reply-To: <871q792ssr.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Sat, 13 Apr 2024 08:27:00 -0700 Message-ID: Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error" To: Florian Weimer Cc: libc-alpha@sourceware.org, Sunil K Pandey Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Apr 13, 2024 at 8:20=E2=80=AFAM Florian Weimer = wrote: > > * H. J. Lu: > > > On Sat, Apr 13, 2024 at 8:03=E2=80=AFAM Florian Weimer wrote: > >> > >> * H. J. Lu: > >> > >> > On Sat, Apr 13, 2024 at 7:49=E2=80=AFAM Florian Weimer wrote: > >> >> > >> >> This reverts commit a1735e0aa858f0c8b15e5ee9975bff4279423680. > >> >> > >> >> The test failure is a real valgrind bug that needs to be fixed befo= re > >> >> valgrind is usable with a glibc that has been built with > >> >> CC=3D"gcc -march=3Dx86-64-v3". The valgrind fix addresses the obse= rved > >> >> test failure as well. > >> >> > >> >> Upstream bug: > >> >> > >> >> Tested on x86_64-linux-gnu with and without CC=3D"gcc -march=3Dx86-= 64-v3". > >> >> The elf/tst-valgrind-smoke tests again fails with an unpatched valg= rind, > >> >> and the proposed upstream patch fixes it. (Apparently, valgrind > >> >> matches on soname, and not the file name, which is ld.so in the tes= t.) > >> > > >> > Please clarify that your patch fixes the glibc valgrind test by not = using > >> > strcmp-avx2.S in the valgrind test. > >> > >> Sorry, clarify where? In the commit message here? On the upstream bu= g? > > > > In the glibc commit message. > > > >> My valgrind patch replaces the strcmp implementation in ld.so with its > >> own. > >> > > > > Please mention it in the glibc commit message. > > Okay, I'll send a v2. > > Could someone proficient in x86-64 assembly have a look at my strcmp > implementation? Can you adapt sysdeps/i386/i686/strcmp.S for valgrind? > > > It seems to work, but =E2=80=A6 > > Thanks, > Florian > --=20 H.J.