From: "H.J. Lu" <hjl.tools@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Remove unneded setting of errno after malloc failure
Date: Thu, 17 May 2018 13:38:00 -0000 [thread overview]
Message-ID: <CAMe9rOpBJ+uxd5-asNxHnr46EiO5VgKn4RB+poFtBejmxkm8zw@mail.gmail.com> (raw)
In-Reply-To: <mvm36yqxv4k.fsf@suse.de>
On Thu, May 17, 2018 at 6:35 AM, Andreas Schwab <schwab@suse.de> wrote:
> The errno value has alread been set by malloc.
>
> * resolv/res_send.c (__res_context_send): Don't set errno when
> returning error after malloc failure.
> ---
> resolv/res_send.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/resolv/res_send.c b/resolv/res_send.c
> index 9e9541789b..947ebf5212 100644
> --- a/resolv/res_send.c
> +++ b/resolv/res_send.c
> @@ -472,10 +472,7 @@ __res_context_send (struct resolv_context *ctx,
> sizeof (struct sockaddr_in6)
> - sizeof (struct sockaddr_in));
> else
> - {
> - __set_errno (ENOMEM);
> - return -1;
> - }
> + return -1;
> }
> EXT(statp).nscount = statp->nscount;
> }
> --
> 2.17.0
>
The commit subject should "unneeded", not "unneded". Otherwise, LGTM.
Thanks.
--
H.J.
prev parent reply other threads:[~2018-05-17 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 13:35 Andreas Schwab
2018-05-17 13:38 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpBJ+uxd5-asNxHnr46EiO5VgKn4RB+poFtBejmxkm8zw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).