From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4 00/10] fix ifunc with static pie [BZ #27072]
Date: Tue, 19 Jan 2021 13:38:16 -0800 [thread overview]
Message-ID: <CAMe9rOpCcDWp0dBiotUf+f0+8Aj3qj_uYpZp1sc7_U7eLEvCog@mail.gmail.com> (raw)
In-Reply-To: <831d6134-b688-9049-5d7c-4092f4a6d968@linaro.org>
On Tue, Jan 19, 2021 at 12:16 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 19/01/2021 16:41, H.J. Lu wrote:
> > On Tue, Jan 19, 2021 at 10:25 AM Szabolcs Nagy via Libc-alpha
> > <libc-alpha@sourceware.org> wrote:
> >>
> >> The 01/18/2021 18:37, Adhemerval Zanella wrote:
> >>> As a side note I tried your branch with a build for all support Linux
> >>> ABIs and it as least improves by issuing an error on architectures
> >>> where previously indicated support static-pie but it is broken in practice
> >>> (powerpc for instance [1])
> >>>
> >>> So currently static-pie are support for all architectures, however it
> >>> fails to build for:
> >>>
> >>> alpha-linux-gnu
> >>> arc-linux-gnuhf
> >>> hppa-linux-gnu
> >>> ia64-linux-gnu
> >>> m68k-linux-gnu
> >>> microblaze-linux-gnu
> >>> riscv32-linux-gnu-rv32imafdc-ilp32d
> >>> riscv64-linux-gnu-rv64imafdc-lp64d
> >>> s390-linux-gnu
> >>> sparc64-linux-gnu
> >>> sparcv9-linux-gnu
> >>>
> >>> By requiring PI_STATIC_AND_HIDDEN hppa, m68, microblaze, mips, nios2,
> >>> and powerpc fail at configure. Some architecture still fails at build:
> >>>
> >>> alpha-linux-gnu
> >>> arc-linux-gnuhf
> >>> riscv32-linux-gnu-rv32imafdc-ilp32d
> >>> riscv64-linux-gnu-rv64imafdc-lp64d
> >>> s390-linux-gnu
> >>> sparc64-linux-gnu
> >>> sparcv9-linux-gnu
> >>>
> >>> I haven't checked if mips is currently broken for static-pie (since
> >>> as for powerpc, it does not define PI_STATIC_AND_HIDDEN); but I would
> >>> expect so.
> >>>
> >>> It would be good if we could avoid building the broken configuration
> >>> and warn it on configure, but I don't think this should be a blocker.
> >>> The NEWS for 2.27 states this features is only supported for x86
> >>> and aarch64, so I wonder if would be better to just enable it for
> >>> the supported architectures instead of relying on PI_STATIC_AND_HIDDEN.
> >>
> >> i randomly checked alpha, which fails while linking sln:
> >>
> >> elf/dl-reloc-static-pie.c:40: undefined reference to `_DYNAMIC'
> >>
> >> i think this should be possible to configure test in case others
> >> targets fail in a similar way.
> >>
> >
> > Linker must be fixed to support static PIE:
> >
> > https://sourceware.org/bugzilla/show_bug.cgi?id=22269
> > https://sourceware.org/bugzilla/show_bug.cgi?id=22263
> > https://sourceware.org/bugzilla/show_bug.cgi?id=21252
>
> My question is which is the correct way to check at configure time
> for this support? Currently this patchset added the PI_STATIC_AND_HIDDEN,
> which is set by each configure snipper within glibc.
Add and define SUPPORT_STATIC_PIE for x86 and aarch64. Other
targets can opt-in.
--
H.J.
next prev parent reply other threads:[~2021-01-19 21:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 16:22 Szabolcs Nagy
2021-01-18 16:23 ` [PATCH v4 01/10] configure: Require PI_STATIC_AND_HIDDEN for static pie Szabolcs Nagy
2021-01-18 16:23 ` [PATCH v4 02/10] libmvec: Add extra-test-objs to test-extras Szabolcs Nagy
2021-01-18 20:04 ` Adhemerval Zanella
2021-01-18 16:23 ` [PATCH v4 03/10] elf: Make the tunable struct definition internal only Szabolcs Nagy
2021-01-18 16:24 ` [PATCH v4 04/10] elf: Avoid RELATIVE relocs in __tunables_init Szabolcs Nagy
2021-01-18 16:24 ` [PATCH v4 05/10] Use hidden visibility for early static PIE code Szabolcs Nagy
2021-01-18 21:49 ` Adhemerval Zanella
2021-01-18 16:24 ` [PATCH v4 06/10] elf: Avoid RELATIVE relocation for _dl_sysinfo Szabolcs Nagy
2021-01-19 13:51 ` Adhemerval Zanella
2021-01-19 14:25 ` V2 " H.J. Lu
2021-01-19 14:35 ` Adhemerval Zanella
2021-01-18 16:25 ` [PATCH v4 07/10] Use <startup.h> in __libc_init_secure Szabolcs Nagy
2021-01-19 13:56 ` Adhemerval Zanella
2021-01-18 16:25 ` [PATCH v4 08/10] csu: Move static pie self relocation later [BZ #27072] Szabolcs Nagy
2021-01-19 14:07 ` Adhemerval Zanella
2021-01-19 14:35 ` Szabolcs Nagy
2021-01-19 14:36 ` Adhemerval Zanella
2021-01-19 14:48 ` H.J. Lu
2021-01-19 15:24 ` Szabolcs Nagy
2021-01-19 15:32 ` H.J. Lu
2021-01-19 16:47 ` H.J. Lu
2021-01-19 17:03 ` Szabolcs Nagy
2021-01-19 17:10 ` H.J. Lu
2021-01-19 17:25 ` Fāng-ruì Sòng
2021-01-19 17:33 ` H.J. Lu
2021-01-19 17:38 ` Fāng-ruì Sòng
2021-01-19 17:38 ` Szabolcs Nagy
2021-01-19 17:42 ` H.J. Lu
2021-01-19 17:47 ` Szabolcs Nagy
2021-01-19 17:53 ` H.J. Lu
2021-01-19 17:59 ` H.J. Lu
2021-01-18 16:25 ` [PATCH v4 09/10] x86: Check ifunc resolver with CPU_FEATURE_USABLE " Szabolcs Nagy
2021-01-19 14:11 ` Adhemerval Zanella
2021-01-19 14:37 ` V2 " H.J. Lu
2021-01-21 16:33 ` H.J. Lu
2021-01-18 16:26 ` [PATCH v4 10/10] Make libc symbols hidden in static PIE Szabolcs Nagy
2021-01-18 21:37 ` [PATCH v4 00/10] fix ifunc with static pie [BZ #27072] Adhemerval Zanella
2021-01-19 18:25 ` Szabolcs Nagy
2021-01-19 19:41 ` H.J. Lu
2021-01-19 20:16 ` Adhemerval Zanella
2021-01-19 21:38 ` H.J. Lu [this message]
2021-01-20 11:29 ` Adhemerval Zanella
2021-01-20 12:38 ` Szabolcs Nagy
2021-01-20 12:49 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpCcDWp0dBiotUf+f0+8Aj3qj_uYpZp1sc7_U7eLEvCog@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).