From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com
 [IPv6:2607:f8b0:4864:20::62e])
 by sourceware.org (Postfix) with ESMTPS id 374563858D3C
 for <libc-alpha@sourceware.org>; Mon,  8 Nov 2021 16:13:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 374563858D3C
Received: by mail-pl1-x62e.google.com with SMTP id r5so16170528pls.1
 for <libc-alpha@sourceware.org>; Mon, 08 Nov 2021 08:13:28 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=VvdUZFCJ/og9pUfZ3DM1SF1mCKSkbCxB7qbhycJS3j4=;
 b=MUG+X+G6F5AwbLMxwBlWYW80+jSLpquGu/8iF4o+dmJDL69CWXNwoZT6HWHI5CX94k
 uW90M6ozckAqGyeZ4XS+drt7gGSKDXYhlwarPJEGx0MbgyFXFRt1Pm88EoRrppjk9GEK
 yhhLMes2XtmbRoTZ4sQTo2FvV43qMYalgZehTRIrgau41SYCZLyBlADK/uYOeA1YKNxi
 eTX9+VlVMHbWnB8dudtZFhuYFRGJAonChkknzl6ZMtkP0vagwpNSZ+USEk6LxBc4vwvS
 wgs/7aLikjfCV8nhwc2vFYgbVklIY4AUgET+UT5d3qZthTsDgUHpPMQmlyM0RArc1ph2
 korQ==
X-Gm-Message-State: AOAM532+m5nsByB92OZhSsUMvZbe6NnhHJ5EfWqR9HfDpLfP5/w143ny
 Sfy87hQgUtXWf04k4ic4qUgg35/Hcom2QjG7/VXKqdZ7
X-Google-Smtp-Source: ABdhPJw3j0ugyzLv4+5pmCPIIF81uFpSim1IfQLTuCY9MdoToDPVaI7PLrwgukYZAtGBeu1i4hz2VrM5+pP2YHM//PA=
X-Received: by 2002:a17:90b:3a85:: with SMTP id
 om5mr54046540pjb.28.1636388007411; 
 Mon, 08 Nov 2021 08:13:27 -0800 (PST)
MIME-Version: 1.0
References: <20211106135053.141779-1-hjl.tools@gmail.com>
 <87cznay6to.fsf@igel.home>
In-Reply-To: <87cznay6to.fsf@igel.home>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 8 Nov 2021 08:12:51 -0800
Message-ID: <CAMe9rOpD0Wzeny_8V6g776CZTxqEFkx=hBCi1sRLmaMcvBFuBw@mail.gmail.com>
Subject: Re: [PATCH] Remove the unnecessary +make-deps
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2021 16:13:29 -0000

On Mon, Nov 8, 2021 at 8:01 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Nov 06 2021, H.J. Lu via Libc-alpha wrote:
>
> > diff --git a/Makerules b/Makerules
> > index 3503605a8e..8db0ca1296 100644
> > --- a/Makerules
> > +++ b/Makerules
> > @@ -459,15 +459,6 @@ compile-stdin.c = $(COMPILE.c) -o $@ -x c - $(compile-mkdep-flags)
> >  # get the wrong predefines.
> >  S-CPPFLAGS = -DASSEMBLER $(asm-CPPFLAGS)
> >
> > -define +make-deps
> > -$(make-target-directory)
> > -$(+mkdep) $< $(if $(filter %.c,$<),$(CFLAGS)) \
>
> This was the last use of +mkdep.
>
> > diff --git a/sysdeps/unix/Makefile b/sysdeps/unix/Makefile
> > index 2ee3be7237..582baa4bd8 100644
> > --- a/sysdeps/unix/Makefile
> > +++ b/sysdeps/unix/Makefile
> > @@ -104,10 +104,6 @@ $(common-objpfx)sysd-syscalls: $(..)sysdeps/unix/make-syscalls.sh \
> >       mv -f $@T $@
> >  endif
> >
> > -$(common-objpfx)s-%.d: $(..)sysdeps/unix/s-%.S \
> > -                    $(wildcard $(+sysdep_dirs:%=%/syscalls.list))
>
> This was the last reference to sysdeps/unix/s-proto.S and
> sysdeps/unix/s-proto-cancel.S.
>
> Andreas.

Is this an approval?


-- 
H.J.