From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Reduce the statically linked startup code [BZ #23323]
Date: Wed, 08 Aug 2018 15:10:00 -0000 [thread overview]
Message-ID: <CAMe9rOpErNaOCT558WrQ_xT92iQmmYP+uSP03PHKPVsyrdC2sw@mail.gmail.com> (raw)
In-Reply-To: <edc80e57-356a-dc28-6195-f4508410c8ab@redhat.com>
On Wed, Aug 8, 2018 at 7:48 AM, Florian Weimer <fweimer@redhat.com> wrote:
> This is the patch rebased for glibc 2.29.
>
> Should we make more far-reaching changes and remove the arguments which are
> now zero?
>
i386 and x86-64 parts look good, except for
+ /* These used to be the addresses of .fini and .init. */
+ xor %R8_LP, %R8_LP
+ xor %RCX_LP, %RCX_LP
Please use
xorl %r8d, %r8d
xorl %ecx, %ecx
They will zero-extend to 64 bits.
Thanks.
--
H.J.
next prev parent reply other threads:[~2018-08-08 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 21:45 Florian Weimer
2018-07-01 9:30 ` Florian Weimer
2018-07-03 10:01 ` Florian Weimer
2018-08-08 14:48 ` Florian Weimer
2018-08-08 15:10 ` H.J. Lu [this message]
2018-08-08 15:17 ` Florian Weimer
2018-08-08 15:56 ` Szabolcs Nagy
2018-08-08 16:11 ` Florian Weimer
2021-02-18 13:12 Florian Weimer
2021-02-25 11:00 ` Siddhesh Poyarekar
2021-02-25 18:43 ` Mike Frysinger
2021-02-25 18:52 ` Florian Weimer
2021-02-28 6:02 ` Mike Frysinger
2021-03-01 9:43 ` Florian Weimer
2021-03-07 16:39 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpErNaOCT558WrQ_xT92iQmmYP+uSP03PHKPVsyrdC2sw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).