From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by sourceware.org (Postfix) with ESMTPS id 5C2D838930CB for ; Wed, 29 Apr 2020 15:53:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5C2D838930CB Received: by mail-il1-x141.google.com with SMTP id b18so2918964ilf.2 for ; Wed, 29 Apr 2020 08:53:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qQ0c0neP7UhA/4DtFg6OiSKDr1tyfONJJ/b2so/rYTI=; b=aigGpxdG0NCRZvc6YbxYKZEwWwIUbEIpb7kley08IOj2ccq0m2yWtnLeIt/pEwpiAn vmvb2K4SV5WOBa6V8D28Qw0Dq50PHZ8trxl7e8VP22uMeCKAlDjxJde++KxdThoeBH3A tAXKtEYbGvjhG+dogloVGmLnWQb3RXqOy1OBUN9P9kjmLTIiwI8Xi6Ynr9snQtIa2RYC shIFNcRZmqSkFn+s2JSMWiGkl9naT5/tCqjSSR7PEc8GutFl2W8MR72OXbIvPW/irVVQ DYOtyvFz1KWbeL2+pCqhKbwHEtu4dft6cxp6zaUHUTxW2EjZoHDqqcMOcr8UrWsgudz0 Ln9w== X-Gm-Message-State: AGi0PuZ5DwnQ+IGuzn8V0c+sepi2HwL4B4thDkMlX9mGvvp0p7ZIQSmN NQIwXLMHF496paPZq7qQYBk1BQzWMjQ2UZvHtok= X-Google-Smtp-Source: APiQypIo9JZCAfcO1MYUt9t4FA/TL+dsV05uBt9wb05r2/sSwbgt4NIfjlS2UJ4M5g1yx40ocixnDHU01Mt0ttiFlLw= X-Received: by 2002:a92:c150:: with SMTP id b16mr33124755ilh.13.1588175599657; Wed, 29 Apr 2020 08:53:19 -0700 (PDT) MIME-Version: 1.0 References: <20200429144727.3769136-1-hjl.tools@gmail.com> <20200429144727.3769136-2-hjl.tools@gmail.com> <87d07qs5n4.fsf@oldenburg2.str.redhat.com> <20200429152017.GA3811691@gmail.com> <87zhau2tpa.fsf@igel.home> <875zdiqovv.fsf@oldenburg2.str.redhat.com> In-Reply-To: <875zdiqovv.fsf@oldenburg2.str.redhat.com> From: "H.J. Lu" Date: Wed, 29 Apr 2020 08:52:43 -0700 Message-ID: Subject: Add C wrappers for process_vm_readv/process_vm_writev [BZ #25810] To: Florian Weimer Cc: Andreas Schwab , "H.J. Lu via Libc-alpha" Content-Type: multipart/mixed; boundary="0000000000007594ca05a46ff261" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:53:27 -0000 --0000000000007594ca05a46ff261 Content-Type: text/plain; charset="UTF-8" On Wed, Apr 29, 2020 at 8:43 AM Florian Weimer wrote: > > * H. J. Lu: > > > On Wed, Apr 29, 2020 at 8:32 AM Andreas Schwab wrote: > >> > >> On Apr 29 2020, H.J. Lu via Libc-alpha wrote: > >> > >> >> > +int > >> >> > +__prctl (int option, unsigned long arg2, unsigned long arg3, > >> >> > + unsigned long arg4, unsigned long arg5) > >> >> > >> >> unsigned long int everywhere. > >> > > >> > Fixed. > >> > > >> >> > >> >> > +{ > >> >> > + return INLINE_SYSCALL_CALL (prctl, option, arg2, arg3, arg4, arg5); > >> >> > +} > >> >> > + > >> >> > +hidden_def (__prctl) > >> >> > +weak_alias (__prctl, prctl) > >> >> > +hidden_weak (prctl) > >> >> > >> >> Can't you use libc_hidden_proto in include/sys/prctl.h and > >> >> libc_hidden_proto here? > >> >> > >> > > >> > Since include/sys/prctl.h has > >> > > >> > extern int __prctl (int __option, ...); > >> > > >> > it can't be used. > >> > >> You cannot implement a function declared as varargs with a non-varargs > >> definition. > > > > True. There is a separate bug: > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=25896 > > I suggest to drop prctl from process_vm_*v fix and commit only the > latter now. > > Thanks, > Florian > Sounds good. I will submit a separate patch for prctl later. This is I am going to check in. Thanks. -- H.J. --0000000000007594ca05a46ff261 Content-Type: application/x-patch; name="0001-Add-C-wrappers-for-process_vm_readv-process_vm_write.patch" Content-Disposition: attachment; filename="0001-Add-C-wrappers-for-process_vm_readv-process_vm_write.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k9linv1x0 RnJvbSBhZDE5Y2M1NzQxODllZTM4Nzk0YjRlM2VjMzU0NGMwODZkNjZiNTM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFdlZCwgMjkgQXByIDIwMjAgMDc6Mzg6NDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBBZGQgQyB3 cmFwcGVycyBmb3IgcHJvY2Vzc192bV9yZWFkdi9wcm9jZXNzX3ZtX3dyaXRldiBbQloKICMyNTgx MF0KClNpbmNlIHRoZSB0aGUgVSBtYXJrZXIgY2FuIG9ubHkgYmUgYXBwbGllZCB0byAyIHVuc2ln bmVkIGxvbmcgYXJndW1lbnRzCmluIHN5c2NhbGxzLmxpc3QgZmlsZXMsIGFkZCBhIEMgd3JhcHBl ciBmb3IgcHJvY2Vzc192bV9yZWFkdiBhbmQKcHJvY2Vzc192bV93cml0ZXYgc3lzY2FscyB3aGlj aCBoYXZlIG1vcmUgdGhhbiAyIHVuc2lnbmVkIGxvbmcgYXJndW1lbnRzLgotLS0KIHN5c2RlcHMv dW5peC9zeXN2L2xpbnV4L01ha2VmaWxlICAgICAgICAgICAgfCAgMyArLQogc3lzZGVwcy91bml4 L3N5c3YvbGludXgvcHJvY2Vzc192bV9yZWFkdi5jICB8IDMzICsrKysrKysrKysrKysrKysrKysr Kwogc3lzZGVwcy91bml4L3N5c3YvbGludXgvcHJvY2Vzc192bV93cml0ZXYuYyB8IDMzICsrKysr KysrKysrKysrKysrKysrKwogc3lzZGVwcy91bml4L3N5c3YvbGludXgvc3lzY2FsbHMubGlzdCAg ICAgICB8ICAyIC0tCiA0IGZpbGVzIGNoYW5nZWQsIDY4IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgc3lzZGVwcy91bml4L3N5c3YvbGludXgvcHJvY2Vz c192bV9yZWFkdi5jCiBjcmVhdGUgbW9kZSAxMDA2NDQgc3lzZGVwcy91bml4L3N5c3YvbGludXgv cHJvY2Vzc192bV93cml0ZXYuYwoKZGlmZiAtLWdpdCBhL3N5c2RlcHMvdW5peC9zeXN2L2xpbnV4 L01ha2VmaWxlIGIvc3lzZGVwcy91bml4L3N5c3YvbGludXgvTWFrZWZpbGUKaW5kZXggMDg5YTQ4 OTlkNS4uYmFlMjA2NDI3ZCAxMDA2NDQKLS0tIGEvc3lzZGVwcy91bml4L3N5c3YvbGludXgvTWFr ZWZpbGUKKysrIGIvc3lzZGVwcy91bml4L3N5c3YvbGludXgvTWFrZWZpbGUKQEAgLTU5LDcgKzU5 LDggQEAgc3lzZGVwX3JvdXRpbmVzICs9IGFkanRpbWV4IGNsb25lIHVtb3VudCB1bW91bnQyIHJl YWRhaGVhZCBzeXNjdGwgXAogCQkgICBldmVudGZkIGV2ZW50ZmRfcmVhZCBldmVudGZkX3dyaXRl IHBybGltaXQgXAogCQkgICBwZXJzb25hbGl0eSBlcG9sbF93YWl0IHRlZSB2bXNwbGljZSBzcGxp Y2UgXAogCQkgICBvcGVuX2J5X2hhbmRsZV9hdCBtbG9jazIgcGtleV9tcHJvdGVjdCBwa2V5X3Nl dCBwa2V5X2dldCBcCi0JCSAgIHRpbWVyZmRfZ2V0dGltZSB0aW1lcmZkX3NldHRpbWUKKwkJICAg dGltZXJmZF9nZXR0aW1lIHRpbWVyZmRfc2V0dGltZSBcCisJCSAgIHByb2Nlc3Nfdm1fcmVhZHYg cHJvY2Vzc192bV93cml0ZXYKIAogQ0ZMQUdTLWdldGhvc3RpZC5jID0gLWZleGNlcHRpb25zCiBD RkxBR1MtdGVlLmMgPSAtZmV4Y2VwdGlvbnMgLWZhc3luY2hyb25vdXMtdW53aW5kLXRhYmxlcwpk aWZmIC0tZ2l0IGEvc3lzZGVwcy91bml4L3N5c3YvbGludXgvcHJvY2Vzc192bV9yZWFkdi5jIGIv c3lzZGVwcy91bml4L3N5c3YvbGludXgvcHJvY2Vzc192bV9yZWFkdi5jCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLmRjYTgyNmI2NzkKLS0tIC9kZXYvbnVsbAorKysgYi9z eXNkZXBzL3VuaXgvc3lzdi9saW51eC9wcm9jZXNzX3ZtX3JlYWR2LmMKQEAgLTAsMCArMSwzMyBA QAorLyogcHJvY2Vzc192bV9yZWFkdiAtIExpbnV4IHNwZWNpZmljIHN5c2NhbGwuCisgICBDb3B5 cmlnaHQgKEMpIDIwMjAgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisgICBUaGlzIGZp bGUgaXMgcGFydCBvZiB0aGUgR05VIEMgTGlicmFyeS4KKworICAgVGhlIEdOVSBDIExpYnJhcnkg aXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgICBtb2Rp ZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisg ICBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBl aXRoZXIKKyAgIHZlcnNpb24gMi4xIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24p IGFueSBsYXRlciB2ZXJzaW9uLgorCisgICBUaGUgR05VIEMgTGlicmFyeSBpcyBkaXN0cmlidXRl ZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorICAgYnV0IFdJVEhPVVQgQU5Z IFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAgIE1FUkNI QU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUg R05VCisgICBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgor CisgICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGVzc2VyIEdl bmVyYWwgUHVibGljCisgICBMaWNlbnNlIGFsb25nIHdpdGggdGhlIEdOVSBDIExpYnJhcnk7IGlm IG5vdCwgc2VlCisgICA8aHR0cHM6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LiAgKi8KKworI2lu Y2x1ZGUgPHVuaXN0ZC5oPgorI2luY2x1ZGUgPHN5c2RlcC5oPgorI2luY2x1ZGUgPGVycm5vLmg+ CisjaW5jbHVkZSA8c3lzL3Vpby5oPgorCitzc2l6ZV90Citwcm9jZXNzX3ZtX3JlYWR2IChwaWRf dCBwaWQsIGNvbnN0IHN0cnVjdCBpb3ZlYyAqbG9jYWxfaW92LAorCQkgIHVuc2lnbmVkIGxvbmcg aW50IGxpb3ZjbnQsCisJCSAgY29uc3Qgc3RydWN0IGlvdmVjICpyZW1vdGVfaW92LAorCQkgIHVu c2lnbmVkIGxvbmcgaW50IHJpb3ZjbnQsIHVuc2lnbmVkIGxvbmcgaW50IGZsYWdzKQoreworICBy ZXR1cm4gSU5MSU5FX1NZU0NBTExfQ0FMTCAocHJvY2Vzc192bV9yZWFkdiwgcGlkLCBsb2NhbF9p b3YsCisJCQkgICAgICBsaW92Y250LCByZW1vdGVfaW92LCByaW92Y250LCBmbGFncyk7Cit9CisK ZGlmZiAtLWdpdCBhL3N5c2RlcHMvdW5peC9zeXN2L2xpbnV4L3Byb2Nlc3Nfdm1fd3JpdGV2LmMg Yi9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC9wcm9jZXNzX3ZtX3dyaXRldi5jCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjE1NzQ4NDUxYWEKLS0tIC9kZXYvbnVsbAorKysg Yi9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC9wcm9jZXNzX3ZtX3dyaXRldi5jCkBAIC0wLDAgKzEs MzMgQEAKKy8qIHByb2Nlc3Nfdm1fd3JpdGV2IC0gTGludXggc3BlY2lmaWMgc3lzY2FsbC4KKyAg IENvcHlyaWdodCAoQykgMjAyMCBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKyAgIFRo aXMgZmlsZSBpcyBwYXJ0IG9mIHRoZSBHTlUgQyBMaWJyYXJ5LgorCisgICBUaGUgR05VIEMgTGli cmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAg IG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJs aWMKKyAgIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRp b247IGVpdGhlcgorICAgdmVyc2lvbiAyLjEgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9w dGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyAgIFRoZSBHTlUgQyBMaWJyYXJ5IGlzIGRpc3Ry aWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgICBidXQgV0lUSE9V VCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICAg TUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2Vl IHRoZSBHTlUKKyAgIExlc3NlciBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFp bHMuCisKKyAgIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNz ZXIgR2VuZXJhbCBQdWJsaWMKKyAgIExpY2Vuc2UgYWxvbmcgd2l0aCB0aGUgR05VIEMgTGlicmFy eTsgaWYgbm90LCBzZWUKKyAgIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwor CisjaW5jbHVkZSA8dW5pc3RkLmg+CisjaW5jbHVkZSA8c3lzZGVwLmg+CisjaW5jbHVkZSA8ZXJy bm8uaD4KKyNpbmNsdWRlIDxzeXMvdWlvLmg+CisKK3NzaXplX3QKK3Byb2Nlc3Nfdm1fd3JpdGV2 IChwaWRfdCBwaWQsIGNvbnN0IHN0cnVjdCBpb3ZlYyAqbG9jYWxfaW92LAorCQkgICB1bnNpZ25l ZCBsb25nIGludCBsaW92Y250LAorCQkgICBjb25zdCBzdHJ1Y3QgaW92ZWMgKnJlbW90ZV9pb3Ys CisJCSAgIHVuc2lnbmVkIGxvbmcgaW50IHJpb3ZjbnQsIHVuc2lnbmVkIGxvbmcgaW50IGZsYWdz KQoreworICByZXR1cm4gSU5MSU5FX1NZU0NBTExfQ0FMTCAocHJvY2Vzc192bV93cml0ZXYsIHBp ZCwgbG9jYWxfaW92LAorCQkJICAgICAgbGlvdmNudCwgcmVtb3RlX2lvdiwgcmlvdmNudCwgZmxh Z3MpOworfQorCmRpZmYgLS1naXQgYS9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC9zeXNjYWxscy5s aXN0IGIvc3lzZGVwcy91bml4L3N5c3YvbGludXgvc3lzY2FsbHMubGlzdAppbmRleCA1YjRlMjA1 OTM0Li5jZWQ3N2Q0OWZhIDEwMDY0NAotLS0gYS9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC9zeXNj YWxscy5saXN0CisrKyBiL3N5c2RlcHMvdW5peC9zeXN2L2xpbnV4L3N5c2NhbGxzLmxpc3QKQEAg LTk4LDggKzk4LDYgQEAgbmFtZV90b19oYW5kbGVfYXQgRVhUUkEJbmFtZV90b19oYW5kbGVfYXQg aTppc3BwaSBuYW1lX3RvX2hhbmRsZV9hdAogCiBzZXRucwkJRVhUUkEJc2V0bnMJCWk6aWkJc2V0 bnMKIAotcHJvY2Vzc192bV9yZWFkdiBFWFRSQQlwcm9jZXNzX3ZtX3JlYWR2IGk6aXBpcGlpIHBy b2Nlc3Nfdm1fcmVhZHYKLXByb2Nlc3Nfdm1fd3JpdGV2IEVYVFJBCXByb2Nlc3Nfdm1fd3JpdGV2 IGk6aXBpcGlpIHByb2Nlc3Nfdm1fd3JpdGV2CiBtZW1mZF9jcmVhdGUgICAgRVhUUkEJbWVtZmRf Y3JlYXRlCWk6c2kgICAgbWVtZmRfY3JlYXRlCiBwa2V5X2FsbG9jCUVYVFJBCXBrZXlfYWxsb2MJ aTppaQlwa2V5X2FsbG9jCiBwa2V5X2ZyZWUJRVhUUkEJcGtleV9mcmVlCWk6aQlwa2V5X2ZyZWUK LS0gCjIuMjUuNAoK --0000000000007594ca05a46ff261--