From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 80A873858D20 for ; Sun, 6 Feb 2022 14:51:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 80A873858D20 Received: by mail-pg1-x530.google.com with SMTP id 132so9408627pga.5 for ; Sun, 06 Feb 2022 06:51:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=iteuYMw5SYaidNy0y0+AxI2FqIE2mlE23ZuHAH8XyJU=; b=j0xWtDrZCMWLcMzox+iffojM434MIyHzTg5HpWchelZ3iTnJBq4/xj3Ca4HSSG4+GX qqntXgi0z2OWp7PSClqNfxo59XbkbxexRd9zuvMPd6otNid7Vwbt69TvskaldbJ+VEQe ibEBPAlWfDmj+fKpUUq69ezf8VxXPAHRT2uDxpRDVHLJSFVbDqqVSdJFE0IHLqI3IMqG tkWKPzKijgnE/gGtmIWdl/y6IMpgsjxdypRRJKV7Fz5AD10MHNdCxrs/OeSMV4d3Nt4B YXZZoW4c7xhFxL55TML/JBVCFy1mj/EkjBYAVfG/1GAdoWFMX15tvgrO55xetZwsRK5F /OeA== X-Gm-Message-State: AOAM532QuBQU/0lFmL9VvNIBdV5NO6Kz3MSeXDjHUDnWnUJVyVEibsXB EjWPoqVMB+QBgpfxqYYs851BR7BsB4DquWIXtZq7+1OZ X-Google-Smtp-Source: ABdhPJy4Swgt5sTelNiQdcMOlcsKhx2otx4d1+t6OXKHmvmIc16KT6+/4WgkLtI/EYwzrVeyim3hUpDkZ4XvwAHaWzY= X-Received: by 2002:a63:3e8b:: with SMTP id l133mr6089590pga.210.1644159076191; Sun, 06 Feb 2022 06:51:16 -0800 (PST) MIME-Version: 1.0 References: <20220206002929.2888485-1-hjl.tools@gmail.com> In-Reply-To: <20220206002929.2888485-1-hjl.tools@gmail.com> From: "H.J. Lu" Date: Sun, 6 Feb 2022 06:50:40 -0800 Message-ID: Subject: Re: [PATCH] string: Sort headers, routines, tests and tests-translation To: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Feb 2022 14:51:20 -0000 On Sat, Feb 5, 2022 at 4:29 PM H.J. Lu wrote: > > Sort headers, routines, tests and tests-translation. Put one entry per > line. > --- > string/Makefile | 210 ++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 166 insertions(+), 44 deletions(-) > > diff --git a/string/Makefile b/string/Makefile > index b65f6027b7..641e062bbb 100644 > --- a/string/Makefile > +++ b/string/Makefile > @@ -22,52 +22,174 @@ subdir := string > > include ../Makeconfig > > -headers := string.h bits/string_fortified.h \ > - strings.h bits/strings_fortified.h \ > - byteswap.h bits/byteswap.h \ > - endian.h bits/endian.h bits/endianness.h \ > - bits/uintn-identity.h \ > - memory.h argz.h envz.h > - > -routines := strcat strchr strcmp strcoll strcpy strcspn \ > - strverscmp strdup strndup \ > - strerror _strerror strlen strnlen \ > - strncat strncmp strncpy \ > - strrchr strpbrk strsignal strspn strstr strtok \ > - strtok_r strxfrm memchr memcmp memcmpeq memmove memset \ > - mempcpy bcopy bzero ffs ffsll stpcpy stpncpy \ > - strcasecmp strncase strcasecmp_l strncase_l \ > - memccpy memcpy wordcopy strsep strcasestr \ > - swab strfry memfrob memmem rawmemchr strchrnul \ > - $(addprefix argz-,append count create ctsep next \ > - delete extract insert stringify \ > - addsep replace) \ > - envz basename \ > - strcoll_l strxfrm_l string-inlines memrchr \ > - xpg-strerror strerror_l explicit_bzero \ > - sigdescr_np sigabbrev_np strerrorname_np \ > - strerrordesc_np > - > -strop-tests := memchr memcmp memcpy memcpy-large memcmpeq memmove mempcpy \ > - memset memccpy stpcpy stpncpy strcat strchr strcmp strcpy \ > - strcspn strlen strncmp strncpy strpbrk strrchr strspn memmem \ > - strstr strcasestr strnlen strcasecmp strncasecmp \ > - strncat rawmemchr strchrnul bcopy bzero memrchr \ > - explicit_bzero > -tests := tester inl-tester noinl-tester testcopy test-ffs \ > - tst-strlen stratcliff tst-svc tst-inlcall \ > - bug-strncat1 bug-strspn1 bug-strpbrk1 tst-bswap \ > - tst-strtok tst-strxfrm bug-strcoll1 tst-strfry \ > - bug-strtok1 $(addprefix test-,$(strop-tests)) \ > - bug-envz1 tst-strxfrm2 tst-endian tst-svc2 \ > - tst-strtok_r bug-strcoll2 tst-cmp tst-xbzero-opt \ > - test-endian-types test-endian-file-scope \ > - test-endian-sign-conversion tst-memmove-overflow \ > - test-sig_np > +headers := \ > + argz.h \ > + bits/byteswap.h \ > + bits/endian.h \ > + bits/endianness.h \ > + bits/string_fortified.h \ > + bits/strings_fortified.h \ > + bits/uintn-identity.h \ > + byteswap.h \ > + endian.h \ > + envz.h \ > + memory.h \ > + string.h \ > + strings.h \ > +# headers > + > +routines := \ > + _strerror \ > + argz-addsep \ > + argz-append \ > + argz-count \ > + argz-create \ > + argz-ctsep \ > + argz-delete \ > + argz-extract \ > + argz-insert \ > + argz-next \ > + argz-replace \ > + argz-stringify \ > + basename \ > + bcopy \ > + bzero \ > + envz \ > + explicit_bzero \ > + ffs \ > + ffsll \ > + memccpy \ > + memchr \ > + memcmp \ > + memcmpeq \ > + memcpy \ > + memfrob \ > + memmem \ > + memmove \ > + mempcpy \ > + memrchr \ > + memset \ > + rawmemchr \ > + sigabbrev_np \ > + sigdescr_np \ > + stpcpy \ > + stpncpy \ > + strcasecmp \ > + strcasecmp_l \ > + strcasestr \ > + strcat \ > + strchr \ > + strchrnul \ > + strcmp \ > + strcoll \ > + strcoll_l \ > + strcpy \ > + strcspn \ > + strdup \ > + strerror \ > + strerror_l \ > + strerrordesc_np \ > + strerrorname_np \ > + strfry \ > + string-inlines \ > + strlen \ > + strncase \ > + strncase_l \ > + strncat \ > + strncmp \ > + strncpy \ > + strndup \ > + strnlen \ > + strpbrk \ > + strrchr \ > + strsep \ > + strsignal \ > + strspn \ > + strstr \ > + strtok \ > + strtok_r \ > + strverscmp \ > + strxfrm \ > + strxfrm_l \ > + swab \ > + wordcopy \ > + xpg-strerror \ > +# routines > + > +tests := \ > + bug-envz1 \ > + bug-strcoll1 \ > + bug-strcoll2 \ > + bug-strncat1 \ > + bug-strpbrk1 \ > + bug-strspn1 \ > + bug-strtok1 \ > + inl-tester \ > + noinl-tester \ > + stratcliff \ > + test-bcopy \ > + test-bzero \ > + test-endian-file-scope \ > + test-endian-sign-conversion \ > + test-endian-types \ > + test-explicit_bzero \ > + test-ffs \ > + test-memccpy \ > + test-memchr \ > + test-memcmp \ > + test-memcmpeq \ > + test-memcpy \ > + test-memcpy-large \ > + test-memmem \ > + test-memmove \ > + test-mempcpy \ > + test-memrchr \ > + test-memset \ > + test-rawmemchr \ > + test-sig_np \ > + test-stpcpy \ > + test-stpncpy \ > + test-strcasecmp \ > + test-strcasestr \ > + test-strcat \ > + test-strchr \ > + test-strchrnul \ > + test-strcmp \ > + test-strcpy \ > + test-strcspn \ > + test-strlen \ > + test-strncasecmp \ > + test-strncat \ > + test-strncmp \ > + test-strncpy \ > + test-strnlen \ > + test-strpbrk \ > + test-strrchr \ > + test-strspn \ > + test-strstr \ > + testcopy \ > + tester \ > + tst-bswap \ > + tst-cmp \ > + tst-endian \ > + tst-inlcall \ > + tst-memmove-overflow \ > + tst-strfry \ > + tst-strlen \ > + tst-strtok \ > + tst-strtok_r \ > + tst-strxfrm \ > + tst-strxfrm2 \ > + tst-svc \ > + tst-svc2 \ > + tst-xbzero-opt \ > +# tests > > # Both tests require the .mo translation files generated by msgfmt. > -tests-translation := tst-strsignal \ > - tst-strerror > +tests-translation := \ > + tst-strerror \ > + tst-strsignal \ > +# tests-translation > > tests-container += $(tests-translation) > ifeq ($(MSGFMT),:) > -- > 2.34.1 > I am checking this in. -- H.J.