From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com
 [IPv6:2607:f8b0:4864:20::1030])
 by sourceware.org (Postfix) with ESMTPS id 89F1E3857020
 for <libc-alpha@sourceware.org>; Tue, 22 Jun 2021 14:23:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89F1E3857020
Received: by mail-pj1-x1030.google.com with SMTP id
 x21-20020a17090aa395b029016e25313bfcso2365543pjp.2
 for <libc-alpha@sourceware.org>; Tue, 22 Jun 2021 07:23:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Spoc2mwg0uIkumNmvHuGZFcNBFAdKDqRzYbud+ZUYYQ=;
 b=Nn1L7f8M7J5V4lXNsniwIQq/cjBMsJqrAo7c4x40IG7sIurnqTRyRUcGrBqtrESLha
 OvWpc8NsMVfsf3jtGjDzH+Jg4IG8ZUv9qEqIrgNAZxGcxpEH/sF/KUyi8k969c95gbLa
 LgcBsdEUGnLbKp1wuOrba5FxtggzDyJDwu+uHRd/0hl4+ZHK5iUsFzAQiZw6t7C+amY5
 YSRli/dwXBkX0naCpEdj8JWaqKVejU1EwXNFK830rdhn+uThnypXK2r1fhdjJ1Pp3wG+
 Km/JjOuiNWnxv82nwoV0zgTvSOJ06mqx/DJIqwOXJlQ1djcWIyU5K/ki63EI1pccIM8x
 0d/w==
X-Gm-Message-State: AOAM532sgJhUiAJwh1x1+sn0ZPa7Ycm2+EIAC4CrRyP834Ufn0JGxmjj
 NNiyB0CZIN2r4n7FCzy66qHpmm+ssAF9b+Y6Z9gpmPCH
X-Google-Smtp-Source: ABdhPJwvhsfph8z2m5H2qBrCW9gjsxvH1z20wfiDzjkYp6UDf8pG2RScT6qwJXGxwlDxuCjQg+7IBY0WpOU3rVyviLo=
X-Received: by 2002:a17:902:8f8f:b029:107:810b:9ee5 with SMTP id
 z15-20020a1709028f8fb0290107810b9ee5mr23114385plo.4.1624371796649; Tue, 22
 Jun 2021 07:23:16 -0700 (PDT)
MIME-Version: 1.0
References: <20210621221606.1295443-1-hjl.tools@gmail.com>
 <87a6nidz7o.fsf@oldenburg.str.redhat.com>
In-Reply-To: <87a6nidz7o.fsf@oldenburg.str.redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 22 Jun 2021 07:22:40 -0700
Message-ID: <CAMe9rOpJV+yTTBpGrLJTSC7TJHBpdxoCmxPm4-a9wQ8Zg_gOsw@mail.gmail.com>
Subject: Re: [PATCH v2] Define PTHREAD_STACK_MIN to
 sysconf(_SC_THREAD_STACK_MIN)
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>,
 Joseph Myers <joseph@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jun 2021 14:23:18 -0000

On Tue, Jun 22, 2021 at 2:29 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > The constant PTHREAD_STACK_MIN may be too small for some processors.
> > When _SC_THREAD_STACK_MIN_SOURCE or _GNU_SOURCE are defined, define
> > PTHREAD_STACK_MIN to sysconf(_SC_THREAD_STACK_MIN) which is changed
> > to MIN (PTHREAD_STACK_MIN, sysconf(_SC_MINSIGSTKSZ)).
>
> I think we should have a single feature test macro, not both
> _SC_THREAD_STACK_MIN_SOURCE and _SC_SIGSTKSZ_SOURCE.  Maybe
> _DYNAMIC_STACK_SIZE_SOURCE?

Fixed in the v3 patch.

Thanks.

-- 
H.J.