From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 2C4B6384402B for ; Fri, 7 May 2021 11:40:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2C4B6384402B Received: by mail-ot1-x332.google.com with SMTP id i23-20020a9d68d70000b02902dc19ed4c15so3644471oto.0 for ; Fri, 07 May 2021 04:40:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3FFhJb/LrPZJnIB2CVBvPxQ5mJgWvu9xAmCeWYyVzMc=; b=i8xYfRxmx5S/equZeiVolnVsaZ+CaCfzrA+U3iA8fK0QeMkvVjEyzlQRuuWgoTU56l p8a0jrulqnTytFcJxRkhtvJFm8NlPELXGB9ACKpZFD1NYEx4kRfRVpTcV64ATCImrSAm Qph/5EeVJYWuQa5Dxs0Gi+kwznVw+GZNHvDW6C/vxxN0pTIv9jCEZFFc9GryVXR+ISdg AlKd55FcvGghWjrREehsgO75cnPvPcVwo0mSsvY1BJVsy6CgD5qFnQgEHOk5FLhw9D0n RJ4nCf/JTXlQHn5kjnOhq3F+WybOPhbRv2x1FGH4RwirrTOSsgCIb/RHhr/6+2zFE+A5 XOWA== X-Gm-Message-State: AOAM5336F4yfNx4q4PpemVbakFOyjT591ckgT+eenRDJvKKgs6fyXbA5 qrwQW/5JGUunzlugyb/GN5YfaBbgdXbE1s121Rk= X-Google-Smtp-Source: ABdhPJzxcAa6fEN77yVLfugtntPyIrHcyTONsPxHI5tOQo7nsF8+sABVNB3883ZUMGwZTbiQI26YziHN/GBFpLlnItw= X-Received: by 2002:a9d:67cf:: with SMTP id c15mr7718972otn.285.1620387626628; Fri, 07 May 2021 04:40:26 -0700 (PDT) MIME-Version: 1.0 References: <20210226211507.3430032-1-hjl.tools@gmail.com> <871rajhon4.fsf@oldenburg.str.redhat.com> <878s4qetes.fsf@oldenburg.str.redhat.com> In-Reply-To: <878s4qetes.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Fri, 7 May 2021 04:39:50 -0700 Message-ID: Subject: Re: [PATCH v2] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477] To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3028.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 11:40:28 -0000 On Fri, May 7, 2021 at 3:21 AM Florian Weimer wrote: > > * H. J. Lu via Libc-alpha: > > >> Should tests use $(test-wrapper-env) instead of $(run-program-env) > > > > I think we should use > > > > $(run-program-prefix) $(objpfx)iconvconfig > > You are more familiar with the makefiles than I am. I do not have any > objection to the proposed patch. > > Thanks, > Florian > I checked it in. -- H.J.