From: "H.J. Lu" <hjl.tools@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
Date: Thu, 7 Jul 2022 16:51:54 -0700 [thread overview]
Message-ID: <CAMe9rOpOnMRTLsQG0_S_s1pZdejnvJkKSp98cqmm3O43OA5K-g@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfJf83paA3YowMNCupX6v=_uJ+4MXSzO=TxxAaEJcS6mxA@mail.gmail.com>
On Thu, Jul 7, 2022 at 4:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > > >
> > > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > > ---
> > > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 -
> > > > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 -
> > > > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > > > 3 files changed, 3 deletions(-)
> > > >
> > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > index 8da09bd86d..516cde1145 100644
> > > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > > @@ -184,7 +184,6 @@
> > > > .align 16
> > > > .type STRCMP, @function
> > > > .globl STRCMP
> > > > - .hidden STRCMP
> > >
> > > Hi Noah,
> > >
> > > Why aren't ENTRY/END used on STRCMP?
> > >
> >
> > Not sure, I copied sse42 when doing avx2/evex.
> >
> > > > # ifndef GLABEL
> > > > # define GLABEL(...) __VA_ARGS__
> > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > index 2a5b3ce037..e97d51bb26 100644
> > > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > > @@ -214,7 +214,6 @@
> > > > .align 16
> > > > .type STRCMP, @function
> > > > .globl STRCMP
> > > > - .hidden STRCMP
> > > >
> > > > # ifdef USE_AS_STRCASECMP_L
> > > > ENTRY (STRCASECMP)
> > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > index a9178ad25c..60313c647a 100644
> > > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > > @@ -77,7 +77,6 @@
> > > > .align 16
> > > > .type STRCMP_SSE42, @function
> > > > .globl STRCMP_SSE42
> > > > - .hidden STRCMP_SSE42
> > > > #ifdef USE_AS_STRCASECMP_L
> > > > ENTRY (GLABEL(__strcasecmp))
> > > > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > > --
> > > > 2.36.1
> > > >
> > >
>
> Do you need to do strcmp-sse2.S?
There is no strcmp-sse2.S on master branch.
--
H.J.
next prev parent reply other threads:[~2022-07-07 23:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 23:39 H.J. Lu
2022-07-07 23:42 ` H.J. Lu
2022-07-07 23:45 ` Noah Goldstein
2022-07-07 23:47 ` Noah Goldstein
2022-07-07 23:51 ` H.J. Lu [this message]
2022-07-07 23:54 ` Noah Goldstein
2022-07-07 23:57 ` H.J. Lu
2022-07-08 0:00 ` Noah Goldstein
2022-07-08 0:05 ` H.J. Lu
2022-07-08 0:09 ` Noah Goldstein
2022-07-07 23:54 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpOnMRTLsQG0_S_s1pZdejnvJkKSp98cqmm3O43OA5K-g@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).