From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 19/58] Mark internal stdlib functions with attribute_hidden [BZ #18822]
Date: Sun, 01 Oct 2017 21:10:00 -0000 [thread overview]
Message-ID: <CAMe9rOpQiprWaf6bVjpm4vQVhFu1BsCVpNS6JopdkiuUDg54PA@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOoX5X2=-782F83AwzZLaDmP4qSqJN_AfHPOoz_31CrkFA@mail.gmail.com>
On 9/3/17, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Sep 3, 2017 at 2:13 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 09/01/2017 07:59 PM, H.J. Lu wrote:
>>> (__qecvt_r): Likewise.
>>> (__qfcvt_r): Likewise.
>>
>> I think this change makes symbols vanish from the public ABI on various
>> architectures:
>>
>> --- ../sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist
>> 2017-08-28 05:01:14.557643019 -0400
>> +++ /home/bmg/build/glibcs/powerpc64-linux-gnu/glibc/libc.symlist
>> 2017-09-03 05:07:32.110128081 -0400
>> @@ -1383 +1382,0 @@ GLIBC_2.3 qecvt F
>> -GLIBC_2.3 qecvt_r F
>> @@ -1385 +1383,0 @@ GLIBC_2.3 qfcvt F
>> -GLIBC_2.3 qfcvt_r F
>> @@ -2198 +2195,0 @@ GLIBC_2.4 qecvt F
>> -GLIBC_2.4 qecvt_r F
>> @@ -2200 +2196,0 @@ GLIBC_2.4 qfcvt F
>> -GLIBC_2.4 qfcvt_r F
>>
>> (I assume that the patch is identical to what is on the hjl/pr18822
>> branch, which is what I used for testing.)
>
> I updated hjl/pr18822 branch and there are no regressions with
> build-many-glibcs.py.
>
I am checking it in now.
--
H.J.
next prev parent reply other threads:[~2017-10-01 21:10 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 18:00 [PATCH 00/58] Hide internal functions in libc.so H.J. Lu
2017-09-01 18:00 ` [PATCH 04/58] Mark ____wcsto*_l_internal functions with attribute_hidden [BZ #18822] H.J. Lu
2017-10-01 21:40 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 54/58] Hide internal __new_exitfn function " H.J. Lu
2017-10-02 0:57 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 57/58] Hide internal __sched_setaffinity_new " H.J. Lu
2017-10-02 1:03 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 50/58] Hide internal __setfpucw " H.J. Lu
2017-10-02 0:51 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 09/58] Mark internal wchar functions with attribute_hidden " H.J. Lu
2017-10-01 21:45 ` H.J. Lu
2017-11-13 10:16 ` Stefan Liebler
2017-09-01 18:00 ` [PATCH 07/58] Mark internal grp/pwd/shadow " H.J. Lu
2017-10-01 21:44 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 01/58] Mark internal " H.J. Lu
2017-10-01 21:37 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 51/58] Hide internal __init_misc function " H.J. Lu
2017-10-02 0:53 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 56/58] Hide internal __glob64 " H.J. Lu
2017-10-02 1:01 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 18/58] Mark internal utmp functions with attribute_hidden " H.J. Lu
2017-09-02 20:58 ` Florian Weimer
2017-10-01 21:14 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 55/58] Hide internal __new_getrlimit function " H.J. Lu
2017-10-02 0:59 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 19/58] Mark internal stdlib functions with attribute_hidden " H.J. Lu
2017-09-03 9:13 ` Florian Weimer
2017-09-03 21:49 ` H.J. Lu
2017-10-01 21:10 ` H.J. Lu [this message]
2017-09-01 18:00 ` [PATCH 53/58] Hide internal __moncontrol function " H.J. Lu
2017-10-02 0:56 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 03/58] Mark __internal_statvfs[64] with attribute_hidden " H.J. Lu
2017-10-01 21:39 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 15/58] Mark internal stdio functions " H.J. Lu
2017-10-01 22:03 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 52/58] Hide internal __libc_print_version function " H.J. Lu
2017-10-02 0:54 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 08/58] Mark __dso_handle as hidden " H.J. Lu
2017-09-03 8:21 ` Florian Weimer
2017-09-03 9:11 ` Florian Weimer
2017-09-03 13:42 ` H.J. Lu
2017-09-04 7:23 ` Florian Weimer
2017-09-04 21:20 ` H.J. Lu
2017-09-12 15:57 ` H.J. Lu
2017-09-26 22:53 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 11/58] Mark internal nscd functions with attribute_hidden " H.J. Lu
2017-10-01 22:00 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 10/58] Mark internal gmp " H.J. Lu
2017-10-01 21:46 ` H.J. Lu
2017-09-01 18:00 ` [PATCH 12/58] Mark internal time " H.J. Lu
2017-10-01 22:01 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 22/58] Mark internal rpc " H.J. Lu
2017-10-01 22:24 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 14/58] Mark internal gshadow " H.J. Lu
2017-10-01 22:02 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 31/58] Hide internal __strsep function " H.J. Lu
2017-10-01 22:36 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 38/58] Move hidden_proto (__dl_iterate_phdr) to include/link.h " H.J. Lu
2017-10-01 22:43 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 13/58] Mark internal statfs functions with attribute_hidden " H.J. Lu
2017-10-01 22:02 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 02/58] Mark 3 *_internal " H.J. Lu
2017-10-01 21:21 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 43/58] Hide internal __hasmntopt function " H.J. Lu
2017-10-02 0:38 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 05/58] Mark internal argp functions with attribute_hidden " H.J. Lu
2017-10-01 21:42 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 39/58] Hide internal __get_sol function " H.J. Lu
2017-10-01 22:44 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 41/58] Hide internal idna functions " H.J. Lu
2017-10-02 0:32 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 42/58] Hide internal __ifreq function " H.J. Lu
2017-10-02 0:34 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 26/58] Mark internal intl functions with attribute_hidden " H.J. Lu
2017-10-01 22:25 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 29/58] Hide internal __mremap function " H.J. Lu
2017-10-01 22:33 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 17/58] Mark internal dirent functions with attribute_hidden " H.J. Lu
2017-10-01 22:23 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 25/58] Hide internal sysinfo functions " H.J. Lu
2017-10-01 22:29 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 23/58] Mark internal netlink functions with attribute_hidden " H.J. Lu
2017-10-01 22:25 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 46/58] Hide internal __vstrfmon_l function " H.J. Lu
2017-10-02 0:44 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 37/58] Hide internal __bsd_getpt " H.J. Lu
2017-10-01 22:42 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 47/58] Hide internal __setrlimit " H.J. Lu
2017-10-02 0:46 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 35/58] Hide internal __tdestroy " H.J. Lu
2017-10-01 22:40 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 48/58] Hide internal __tcgetattr " H.J. Lu
2017-10-02 0:47 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 40/58] Hide internal __gettextparse " H.J. Lu
2017-10-02 0:30 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 49/58] Hide internal __nis_hash " H.J. Lu
2017-10-02 0:49 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 28/58] Hide internal __malloc_check_init " H.J. Lu
2017-10-01 22:32 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 16/58] Mark internal getXXXbyYYY functions with attribute_hidden " H.J. Lu
2017-10-01 22:04 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 30/58] Hide __posix_spawn_file_actions_realloc/__spawni " H.J. Lu
2017-10-01 22:34 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 27/58] Hide internal __ioctl function " H.J. Lu
2017-10-01 22:31 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 45/58] Hide internal __sched_setparam " H.J. Lu
2017-10-02 0:42 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 36/58] Hide internal __fopen_maybe_mmap " H.J. Lu
2017-10-01 22:41 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 06/58] Mark internal unistd functions with attribute_hidden " H.J. Lu
2017-10-01 21:43 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 21/58] Hide __readv and __writev " H.J. Lu
2017-09-01 18:01 ` [PATCH 20/58] Hide internal regex functions " H.J. Lu
2017-10-01 22:27 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 34/58] Hide internal __assert_fail_base function " H.J. Lu
2017-10-01 22:39 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 24/58] Hide __chmod and __mkdir " H.J. Lu
2017-09-04 8:05 ` Florian Weimer
2017-09-01 18:01 ` [PATCH 32/58] Hide internal signal functions " H.J. Lu
2017-10-01 22:37 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 44/58] Hide internal __hash_string function " H.J. Lu
2017-10-02 0:40 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 33/58] Hide internal __sysinfo " H.J. Lu
2017-10-01 22:38 ` H.J. Lu
2017-09-01 18:01 ` [PATCH 58/58] Hide internal fadvise64/fallocate64 functions " H.J. Lu
2017-10-02 1:05 ` H.J. Lu
2017-09-01 18:16 ` [PATCH 00/58] Hide internal functions in libc.so Florian Weimer
2017-09-01 19:42 ` H.J. Lu
2017-09-01 20:14 ` Joseph Myers
2017-09-18 13:59 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpQiprWaf6bVjpm4vQVhFu1BsCVpNS6JopdkiuUDg54PA@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).