From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30513 invoked by alias); 1 Oct 2017 21:10:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 30504 invoked by uid 89); 1 Oct 2017 21:10:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=20170903, Hx-languages-length:1124, 2017-09-03, vanish X-HELO: mail-oi0-f67.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=g960MtI0q70tNB/w22UZ+xsvksayqfij+BpDOUKJM1k=; b=oXQAhfb4X3FOahb3M84LfqwrewTaOzHeFZNr7/KpF9HJywsVM17sL6xfPWnYs4AGM8 xyoRpIZX8EXO0TJ5ApyYFS2Sa37QUY7XNwpLStH5LtXErOSovN6dqnkmuFybGE5jSGjw G1HwpFRMKPCuSQOIx5on7eNmhZ1mVf+m0ZpRnVnnp7fQSQFuaV3ZrgwD8P1CY8UbuAzM eoPQJLsjcM7Kgp1z3VG6lKvw2lPSTHAHB/Xv3Iy2l2sKcp6uTXs+vFArDfFIcMxzEyyK T6g0v+ENld7OW1djLskNVgdX6Qc4VqSTBsKK1obIvuZUeNR1BraTUW87P02hfB/lIPBC 7WPQ== X-Gm-Message-State: AMCzsaWURe1QYzSplyxwGPZ3KBmNtn8Q/L191McW4prpGv0VJwuRuM/u i/kjeIT9ipZSiFT6WmBg9pdpnIDZ5IxeRFe/Gyk= X-Google-Smtp-Source: AOwi7QD7zWWwct5fRv6fe/YqYtcAWjheR89eYeQHyEwYdDKjNPmZihebE2qAJ/X1JIsIfADXnjUM4/EjbQXuxxysllo= X-Received: by 10.157.33.246 with SMTP id s109mr7975426otb.50.1506892211762; Sun, 01 Oct 2017 14:10:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170901180029.9527-1-hjl.tools@gmail.com> <20170901180029.9527-20-hjl.tools@gmail.com> <21eb3240-eea3-f81c-37b4-ef820e9f9e96@redhat.com> From: "H.J. Lu" Date: Sun, 01 Oct 2017 21:10:00 -0000 Message-ID: Subject: Re: [PATCH 19/58] Mark internal stdlib functions with attribute_hidden [BZ #18822] To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-10/txt/msg00003.txt.bz2 On 9/3/17, H.J. Lu wrote: > On Sun, Sep 3, 2017 at 2:13 AM, Florian Weimer wrote: >> On 09/01/2017 07:59 PM, H.J. Lu wrote: >>> (__qecvt_r): Likewise. >>> (__qfcvt_r): Likewise. >> >> I think this change makes symbols vanish from the public ABI on various >> architectures: >> >> --- ../sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist >> 2017-08-28 05:01:14.557643019 -0400 >> +++ /home/bmg/build/glibcs/powerpc64-linux-gnu/glibc/libc.symlist >> 2017-09-03 05:07:32.110128081 -0400 >> @@ -1383 +1382,0 @@ GLIBC_2.3 qecvt F >> -GLIBC_2.3 qecvt_r F >> @@ -1385 +1383,0 @@ GLIBC_2.3 qfcvt F >> -GLIBC_2.3 qfcvt_r F >> @@ -2198 +2195,0 @@ GLIBC_2.4 qecvt F >> -GLIBC_2.4 qecvt_r F >> @@ -2200 +2196,0 @@ GLIBC_2.4 qfcvt F >> -GLIBC_2.4 qfcvt_r F >> >> (I assume that the patch is identical to what is on the hjl/pr18822 >> branch, which is what I used for testing.) > > I updated hjl/pr18822 branch and there are no regressions with > build-many-glibcs.py. > I am checking it in now. -- H.J.