From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by sourceware.org (Postfix) with ESMTPS id CC2AF386103C for ; Thu, 8 Oct 2020 13:22:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CC2AF386103C Received: by mail-ot1-x342.google.com with SMTP id f37so5387813otf.12 for ; Thu, 08 Oct 2020 06:22:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XZeqqE3UqfxqZaGsJPNOfOipewqrLlrJBi3VX4kGroI=; b=HtznHTQwW1ujnoBXeW6T6u08QvuCp3Wo98sCzHe1hTIyHUaxtUvYl3OwmcuFtch/U7 ZM4vKVoA+/eHmbABbkI61hDh0eADN0y0F4s63NRj7gYzf3WCLVytev4J/pGEhIbVNUOs t8bdCmn9flonMqZWsw+ZBjSkS6sTYtjECG9rLwFvXCv8GoCLqHUfk3DQGZxVNovgACYE jFmZuGZP/FbKAi8VUCUgHuGEvZq2F/1VaiDYavjwJa4cPUjCqU0O/6HJEdpiM400CmYI TbXVirugzsIYOXeXyVIuFSPTPF0cRGBdX6c/NfRAucTvmo+B70jSMDe7CyBngycgxRUl GknQ== X-Gm-Message-State: AOAM531VpHcW9ULdzNgFJqpzDaJrMmwuS6+U4zc6jZbZdS740qmS+BiG DpjR24xpJb4478vGpo46FwgCUtJQN0sveet/EkA= X-Google-Smtp-Source: ABdhPJwogEnar3DCwU6CgcVnZg3FjB47Gkuux29NNbedb3RIpA9ITUFbEud1YkjTnETJ7UEfExJr/X7iJ/U7sUYN2X0= X-Received: by 2002:a9d:6498:: with SMTP id g24mr5225196otl.179.1602163367237; Thu, 08 Oct 2020 06:22:47 -0700 (PDT) MIME-Version: 1.0 References: <20200918160709.949608-1-hjl.tools@gmail.com> <20200918160709.949608-2-hjl.tools@gmail.com> <87imby6obw.fsf@oldenburg2.str.redhat.com> <87y2ku574k.fsf@oldenburg2.str.redhat.com> <87lfgu56c8.fsf@oldenburg2.str.redhat.com> <87pn663qm5.fsf@oldenburg2.str.redhat.com> <87ft71yq64.fsf@oldenburg2.str.redhat.com> <87362yl4fh.fsf@oldenburg2.str.redhat.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 8 Oct 2020 06:22:11 -0700 Message-ID: Subject: PING: V4 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203] To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3036.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2020 13:22:49 -0000 On Thu, Oct 1, 2020 at 12:50 PM H.J. Lu wrote: > > On Thu, Oct 1, 2020 at 1:46 AM Florian Weimer wrote: > > > > * H. J. Lu: > > > > > diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c > > > index dadec5d58f..65ab29123d 100644 > > > --- a/sysdeps/x86/cacheinfo.c > > > +++ b/sysdeps/x86/cacheinfo.c > > > @@ -16,7 +16,9 @@ > > > License along with the GNU C Library; if not, see > > > . */ > > > > > > -#if IS_IN (libc) > > > +/* NB: In libc.a, this file is included in libc-static.c. In libc.s= o, > > > + this file is standalone. */ > > > +#if IS_IN (libc) && (defined SHARED || defined _PRIVATE_CPU_FEATURES= _H) > > > > libc-static.c should be libc-start.c, I believe. The =E2=80=9Cdefined > > _PRIVATE_CPU_FEATURES_H=E2=80=9D part seems rather indirect. What exac= tly are > > you trying to accomplish here? > > > > It looks to me as if this file should included in libc.so, but not > > pulled into ld.so via the rebuild, so maybe you can add an empty > > sysdeps/x86/rtld-cacheinfo.c file instead? > > > > Here is the updated patch. I also moved files around to prepare > for moving x86 processor cache info to cpu_features in ld.so to > support --list-tunables. > PING: https://sourceware.org/pipermail/libc-alpha/2020-October/118228.html --=20 H.J.