From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 3F2873856DD2 for ; Wed, 25 May 2022 19:30:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F2873856DD2 Received: by mail-pj1-x1029.google.com with SMTP id gz24so2609996pjb.2 for ; Wed, 25 May 2022 12:30:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IBqbANAFrzqJoMvLOxM5Q4nVdLc7r5rcXLu3kbughwg=; b=yo2R30HKpPehb0gk5KvSgxYdvDhLPueTkdWT+Mz1zTmxG5T8LEEWrwfya+zfryvBfK TgkJIlIlhDNSVdQ4N3uPjmQ7j5QHxGcwm4TmSDp94IG+wgVz9/GEhX/DbEXhAYrfDwDT b4ltF2MBRGAbD+FQeXp2KRx1sRaWRVKSr9dm5pJ0VWP6jlASQKJ3JEpS5DxcIO6yldsv h/ct+9HjSkqHcFYt6sbI0D3eL/dqgBpK/mQZY1kz7phN4kTUP75g5Mg6uMepJAsE69CE 67zse3wr6Gv5GSBQaExjI60EKoq2qazwdoBWcWHgw7o5guhcvY8xjfGXUIVDs3mfa9Pt MVSQ== X-Gm-Message-State: AOAM530UMa2V+fHJEex4GgSzn+AbDXryCWIjMsXp9j3KdNMpmw9FLNc4 n3VfwMRJdTOrh/fPLUfV8nqK1Hh0P9JcjGa3bw/oSKSH X-Google-Smtp-Source: ABdhPJzqoOkCA/0CPmU0+XKfUch7//VotI6OGVd/JmTj2DiQCk+Vts04WHf8IaD5gWthR5Vr9U/H7Mi+6dVudeo/0Dk= X-Received: by 2002:a17:90a:a585:b0:1e0:c609:59c3 with SMTP id b5-20020a17090aa58500b001e0c60959c3mr2183115pjq.35.1653507017170; Wed, 25 May 2022 12:30:17 -0700 (PDT) MIME-Version: 1.0 References: <20220521022336.2464080-1-hjl.tools@gmail.com> <874k1dy2pf.fsf@oldenburg.str.redhat.com> <87wne9wk4h.fsf@oldenburg.str.redhat.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 25 May 2022 12:29:41 -0700 Message-ID: Subject: Re: [PATCH] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3019.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 19:30:23 -0000 On Wed, May 25, 2022 at 11:28 AM Adhemerval Zanella via Libc-alpha wrote: > > > > On 25/05/2022 15:19, Florian Weimer via Libc-alpha wrote: > > * H. J. Lu: > > > >> Linker always sets r_addend to 0 for R_X86_64_GLOB_DAT and > >> R_X86_64_JUMP_SLOT. > > > > Okay, so it's very unlikely that we see non-zero addends. > > Maybe you can add this to the commit message? > > > > Given that, I think the change should be safe. > > > > Thanks, > > Florian > > > > Maybe assert that r_addend is always zero? I don't think it is necessary since r_addend has never been non-zero. -- H.J.