From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by sourceware.org (Postfix) with ESMTPS id 6CDD0386181D for ; Mon, 24 Aug 2020 12:43:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6CDD0386181D Received: by mail-io1-xd43.google.com with SMTP id b16so8456739ioj.4 for ; Mon, 24 Aug 2020 05:43:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7SM7t8sfPBlpUzChQwSO8EDEQxVTfEH92NS8i9RAXl8=; b=YvJPRLplg4SSM/i3qExhswrIebaKxb4qm5tine2by2v8EgCwripqmjKuf6xdS6mduK 0zEsKHJz6+erd8iHmEogbTKHW3/Th55lWsbJfAAmeIZvxKOkyVxuZls8NHh2kpj73QYt WLzbzgKilC8SvvV5GwWkrNyk5ItlYCCwj4WncjZY/US1cJ/1vPB7wKJEhYTWVBTI/NZp bWGObzj36oQB497X1vKgbvj486UR2xNt0DBWChiUhCOk6YuuzWWLWMwHxSwQsOx5H288 ks6snv+YgTgXP/Q1PtOEz+9N5OXjoooY+UPVuX+/7C5XntssrJN3nY/nJs7Y//8s32lb fogQ== X-Gm-Message-State: AOAM533H9CkpLctHwBhDHUy6XhlkC0bIHNqfTwoabjpQhuk4xq1584M/ sQb9G1iJ+/FeJC9D03AVDddXsJC+ArfVKA4k6cmYnE2sduQ= X-Google-Smtp-Source: ABdhPJzv2SG9brXgl16YstMpDejoADAwzBYakgVGxjKjF9wSQg71Y2UCPRfJ3esbOzAcPZvqPqoiMkzTSl05kI1nxrg= X-Received: by 2002:a02:852c:: with SMTP id g41mr5564364jai.58.1598272982790; Mon, 24 Aug 2020 05:43:02 -0700 (PDT) MIME-Version: 1.0 References: <20200815213138.1375595-1-hjl.tools@gmail.com> <87v9h8e1it.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87v9h8e1it.fsf@oldenburg2.str.redhat.com> From: "H.J. Lu" Date: Mon, 24 Aug 2020 05:42:27 -0700 Message-ID: Subject: Re: [PATCH] x32: Add and regenerate arch-syscall.h To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 12:43:04 -0000 On Mon, Aug 24, 2020 at 4:17 AM Florian Weimer wrote: > > * H. J. Lu via Libc-alpha: > > > diff --git a/sysdeps/unix/sysv/linux/x86/include/asm/unistd_x32.h b/sys= deps/unix/sysv/linux/x86/include/asm/unistd_x32.h > > new file mode 100644 > > index 0000000000..4de22a7737 > > --- /dev/null > > +++ b/sysdeps/unix/sysv/linux/x86/include/asm/unistd_x32.h > > @@ -0,0 +1,9 @@ > > +/* FIXME: __NR_set_thread_area should come from the kernel header file= . > > + This file should be removed if from the kernel > > + header file contains __NR_set_thread_area. */ > > + > > +#include_next > > + > > +#ifndef __NR_set_thread_area > > +# define __NR_set_thread_area 1073742029 > > +#endif > > I think you can use sysdeps/unix/sysv/linux/x86_64/x32/fixup-asm-unistd.h > for this. It's more tailored to this purpose. arc and arm already > use it. It doesn't work in this case. is used to undefine or redefine a syscall from . The actual syscall numbers still come from . In this case, the sycall number is missing from . My patch is a prerequisite for a new testcase: ../sysdeps/unix/sysv/linux/x86/tst-sigreturn-1.c: In function =E2=80=98setu= p_ldt=E2=80=99: ../sysdeps/unix/sysv/linux/x86/tst-sigreturn-1.c:258:14: error: =E2=80=98SYS_set_thread_area=E2=80=99 undeclared (first use in this functio= n) 258 | if (syscall(SYS_set_thread_area, &gdt_data16_desc) =3D=3D 0) { | ^~~~~~~~~~~~~~~~~~~ --=20 H.J.