From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by sourceware.org (Postfix) with ESMTPS id 834343858D37 for ; Sat, 16 Mar 2024 14:43:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 834343858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 834343858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710600239; cv=none; b=JWp0f7GEA718bFeqcbNrToKllyx+23wDTEuFYVcqJ9vJktW6TZQh+oSayOf9vHCuAi0GH7vyd6zSy2LYDPK6bdwS9yNrWxzSqTRq5y91iHEr9qzBXV1GGO7wBOFvOptBNkf8rm9Q77Xv+2v0Wt3dRNyO3hYBYz3ipd2gEU0ibgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710600239; c=relaxed/simple; bh=VyycAUlx+5Hpu7OdfMO03buDYJt7QOoHOxIbTVdVdzE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=SOYO6BqhlCOFDyRJOFu52bzqDniRN9UnviSJK40X3nADXPrYh2nRHbVEtNam3zN323TCngY/eQZMykDpXVi0Hxcih75BWtDanQVRd5Ub/e7altD81mZiqnPyJjY/1j5dHqEGHFISulD9LC8El2yNm4jTy9xzN25soVgWZVpdiJw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-60a057b6601so29626087b3.2 for ; Sat, 16 Mar 2024 07:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710600237; x=1711205037; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w9QUWRP8yREBpPBSZk9ex2BJhIHMeTr0N2ndMW/L6TY=; b=BPmqbQnv+7/aCh5V+ZY/AvsX4ZIWbVk02X3qpyNZzp9qIiCEoRYOeLVCEueF0kx48p O+hOwu79A6ugDSkhA7OfNy9DUH+5jNtvCoGx2RqNxRd1pPSLHDi/fyYijh2bdA2ywKiY fECMmIl3ivnVe8Df97zlbMYjKPGsmgIjZWkDZYTe1eo5mxV0IMVawISlkALmAMn0aCq4 PvWTSuWvdNmErKKiyyzb+SGimn6lHO6Z4Z5NEf+B6EP0oGxfCz3b4mSjA7mGIKBilSMd ByBc2XYF/kdr87qP+DOOzlUi5qluJbnCcHRGXCas9nPaQf/t7SkJcACDeZhsO3gHnMmh p0cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710600237; x=1711205037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w9QUWRP8yREBpPBSZk9ex2BJhIHMeTr0N2ndMW/L6TY=; b=gIp4Q9MLojLdlxpzut0wnTAp33Scvl95dSt0O5kOgXobkPmxgnixX0hTqnTwsheEkS 57mdP9pXOeAVl//5B5ipry4w/fS04285km5yOW5yIWyyBoBNbn0Q+xisvH2k+vt7fWRS gEpmkOa3dRLveL1Wb+ezieGdKN/cTf4zKXCmxyw4SDr6qvsiYtefLiB6F6IGGW1dX+7M kdy4sYF6N/bhAhm4F8Cw0mqV/82PrdGX0+2sWKEHLiKw2DmdJ4SlhzCNluzaqnA0K7v5 T973jqzv+Qw+XN3yjJW0mMV9PCyYOc3V7rFY90K1/uLa3KlKqSkRXQPmL2M7x0ccoabd g4rA== X-Gm-Message-State: AOJu0YxrNm0SxsyQQ0g0h+NLQXl+5rbHJKQQo8Urzz+7E/d4CMX3gzly lWEsNgUbv60eAdoTMDgbPDEyRbJp9sS/M+JhMzjrbrBeBaYRSIYsSJnVKLheexnhPwp6JiN1/Ni W7/9G8k7V7TfS9rRg/6HsS+7DHp4= X-Google-Smtp-Source: AGHT+IFUrCt2cy2JD4lZ7pMdvnfKPogkJp1YeRwg8AhKgZ87eS8+ZrMQpZj614QWaISwsRNBYn71cc8wLfa0jR6Wdec= X-Received: by 2002:a81:af56:0:b0:60c:cc36:e6ed with SMTP id x22-20020a81af56000000b0060ccc36e6edmr7104020ywj.3.1710600236716; Sat, 16 Mar 2024 07:43:56 -0700 (PDT) MIME-Version: 1.0 References: <878r2ifdrx.fsf@oldenburg.str.redhat.com> In-Reply-To: From: "H.J. Lu" Date: Sat, 16 Mar 2024 07:43:20 -0700 Message-ID: Subject: Re: [PATCH] x86-64: Stack alignment in _dl_tlsdesc_dynamic and red zone usage (bug 31501) To: Florian Weimer Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3020.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Mar 16, 2024 at 7:37=E2=80=AFAM H.J. Lu wrote= : > > On Sat, Mar 16, 2024 at 7:33=E2=80=AFAM Florian Weimer wrote: > > > > In sysdeps/x86_64/dl-tlsdesc-dynamic.h, the stack pointer is > > realigned for some variants (notably _dl_tlsdesc_dynamic_xsavec). > > This realignment does not take into account that the function has > > already used part of the red zone at this point, thus clobbering > > the initally saved register values located there if the stack > > alignment inherited from the caller is unfortunate. > > > > (Note: I do not know to write a good test case for this in the existing > > framework. We saw this as a random LTO plugin crash when building GCC > > with -mtls-dialect=3Dgnu2. The existing tests on pass on x86_64-linux-= gnu > > with this change here.) > > Will a different STATE_SAVE_OFFSET for TLS descriptor work? Correction. REGISTER_SAVE_AREA is for this purpose. Will a different value for TLS descriptor work? > > --- > > sysdeps/x86_64/dl-tlsdesc-dynamic.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/sysdeps/x86_64/dl-tlsdesc-dynamic.h b/sysdeps/x86_64/dl-tl= sdesc-dynamic.h > > index 9f02cfc3eb..8e49e7eece 100644 > > --- a/sysdeps/x86_64/dl-tlsdesc-dynamic.h > > +++ b/sysdeps/x86_64/dl-tlsdesc-dynamic.h > > @@ -83,6 +83,8 @@ _dl_tlsdesc_dynamic: > > 2: > > #if DL_RUNTIME_RESOLVE_REALIGN_STACK > > movq %rbx, -24(%rsp) > > + subq $24, %rsp > > + cfi_adjust_cfa_offset(24) > > mov %RSP_LP, %RBX_LP > > cfi_def_cfa_register(%rbx) > > and $-STATE_SAVE_ALIGNMENT, %RSP_LP > > @@ -153,6 +155,8 @@ _dl_tlsdesc_dynamic: > > #if DL_RUNTIME_RESOLVE_REALIGN_STACK > > mov %RBX_LP, %RSP_LP > > cfi_def_cfa_register(%rsp) > > + addq $24, %rsp > > + cfi_adjust_cfa_offset(-24) > > movq -24(%rsp), %rbx > > cfi_restore(%rbx) > > #else > > > > base-commit: 5ebc24f785dc0dff494a93ca82a369497c3cdc68 > > > > > -- > H.J. --=20 H.J.