From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 504D73835C11 for ; Fri, 14 Jan 2022 14:28:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 504D73835C11 Received: by mail-pg1-x52e.google.com with SMTP id e2so2904922pgc.6 for ; Fri, 14 Jan 2022 06:28:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3fRdH8ELnusWsieOy9Y8homVQK9PiNfQdrMO/eZIWNw=; b=MC7Gh6f5tpWz3sKP7b7tLChrZJJqMI+pOhgQu5jvKHtWMmw5H/5jxFg0FhVHs9ha2Z nRogxrexDQy3kKbYcPENNMdDVPXz7+tlrxsjbh9j0b2qNNYxu6TUtcFarBo38M2gLF4E GR1IUbncgLzox+J3k7hoof8dVUDlMIKfF3bMzyymcKSntcBLwtS32QMqTkW431KSHQgL 0dnqckEFJs3I10ejdCWCboDWBJVWxn7SrpYGsizIGRMDd1RDa/OhYteeGhERinLCqJJG QZpX3V6gLSszS730ZeRCgwjG0BXbMvSdY2JkbG7nw4oNqHbXulmPmc8do5/iLr0abnIF lytA== X-Gm-Message-State: AOAM531uxwwmRJ9TAQRbAuf9QFPZm4OabBO2fTKionsGOEYcf33L3wTn TmpHW4H8Y0jn+nJyunWoYfDdti5CWQf1zRSncvQ= X-Google-Smtp-Source: ABdhPJxmehblf0KqQTfngwIVBmxnWRZhGt/RG2rh4Wk8EYHO4dMhKlKEpAUSmJbORwUxIQyFeDnRShwJYgEPGBHiARM= X-Received: by 2002:a63:89c6:: with SMTP id v189mr1757714pgd.210.1642170480379; Fri, 14 Jan 2022 06:28:00 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Fri, 14 Jan 2022 06:27:24 -0800 Message-ID: Subject: Re: [PATCH 4/7] Add --early-cflags configure option To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 14:28:03 -0000 On Fri, Jan 14, 2022 at 4:43 AM Florian Weimer via Libc-alpha wrote: > > --- > config.make.in | 1 + > configure | 13 +++++++++++++ > configure.ac | 6 ++++++ > elf/Makefile | 8 ++++++++ > manual/install.texi | 7 +++++++ > 5 files changed, 35 insertions(+) > > diff --git a/config.make.in b/config.make.in > index e8630a8d0c..e06f1ff49f 100644 > --- a/config.make.in > +++ b/config.make.in > @@ -110,6 +110,7 @@ CFLAGS = @CFLAGS@ > CPPFLAGS-config = @CPPFLAGS@ > CPPUNDEFS = @CPPUNDEFS@ > extra-nonshared-cflags = @extra_nonshared_cflags@ > +early-cflags = @early_cflags@ > ASFLAGS-config = @ASFLAGS_config@ > AR = @AR@ > NM = @NM@ > diff --git a/configure b/configure > index 3f956cf777..6eedd8c3a7 100755 > --- a/configure > +++ b/configure > @@ -681,6 +681,7 @@ force_install > bindnow > hardcoded_path_in_tests > enable_timezone_tools > +early_cflags > extra_nonshared_cflags > use_default_link > sysheaders > @@ -761,6 +762,7 @@ with_selinux > with_headers > with_default_link > with_nonshared_cflags > +with_early_cflags > with_timeoutfactor > enable_sanity_checks > enable_shared > @@ -1480,6 +1482,8 @@ Optional Packages: > --with-default-link do not use explicit linker scripts > --with-nonshared-cflags=CFLAGS > build nonshared libraries with additional CFLAGS > + --with-early-cflags=CFLAGS > + build early initialization with additional CFLAGS > --with-timeoutfactor=NUM > specify an integer to scale the timeout > --with-cpu=CPU select code for CPU variant > @@ -3386,6 +3390,15 @@ fi > > > > +# Check whether --with-early-cflags was given. > +if test "${with_early_cflags+set}" = set; then : > + withval=$with_early_cflags; early_cflags=$withval > +else > + early_cflags= > +fi > + > + > + > > # Check whether --with-timeoutfactor was given. > if test "${with_timeoutfactor+set}" = set; then : > diff --git a/configure.ac b/configure.ac > index 277d3527d2..445b0b7f15 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -162,6 +162,12 @@ AC_ARG_WITH([nonshared-cflags], > [extra_nonshared_cflags=$withval], > [extra_nonshared_cflags=]) > AC_SUBST(extra_nonshared_cflags) > +AC_ARG_WITH([early-cflags], > + AS_HELP_STRING([--with-early-cflags=CFLAGS], > + [build early initialization with additional CFLAGS]), > + [early_cflags=$withval], > + [early_cflags=]) > +AC_SUBST(early_cflags) > > AC_ARG_WITH([timeoutfactor], > AS_HELP_STRING([--with-timeoutfactor=NUM], > diff --git a/elf/Makefile b/elf/Makefile > index 0c4be43deb..9fcb4ebd13 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -99,6 +99,14 @@ CFLAGS-.o += $(call elide-stack-protector,.o,$(elide-routines.os)) > CFLAGS-.op += $(call elide-stack-protector,.op,$(elide-routines.os)) > CFLAGS-.os += $(call elide-stack-protector,.os,$(all-rtld-routines)) > > +# Add the requested compiler flags to the early startup code. > +CFLAGS-dl-printf.os += $(early-cflags) > +CFLAGS-dl-sysdep.os += $(early-cflags) > +CFLAGS-dl-tunables.os += $(early-cflags) > +CFLAGS-dl-write.os += $(early-cflags) > +CFLAGS-dl-writev.os += $(early-cflags) > +CFLAGS-rtld.os += $(early-cflags) > + > ifeq ($(unwind-find-fde),yes) > routines += unwind-dw2-fde-glibc > shared-only-routines += unwind-dw2-fde-glibc > diff --git a/manual/install.texi b/manual/install.texi > index b1afc56f5a..27d5893c5e 100644 > --- a/manual/install.texi > +++ b/manual/install.texi > @@ -131,6 +131,13 @@ that the objects in @file{libc_nonshared.a} are compiled with this flag > (although this will not affect the generated code in this particular > case and potentially change debugging information and metadata only). > > +@item --with-early-cflags=@var{cflags} > +Use additional compiler flags @var{cflags} to build the early startup > +code of the dynamic linker. These flags can be used to enable early > +dynamic linker diagnostics to run on CPUs which are not compatible with > +the rest of @theglibc{}, for example, due to compiler flags which target > +a later instruction set architecture (ISA). > + Isn't it limited to rtld? If yes, I prefer --with-early-rtld-cflags > @item --with-timeoutfactor=@var{NUM} > Specify an integer @var{NUM} to scale the timeout of test programs. > This factor can be changed at run time using @env{TIMEOUTFACTOR} > -- > 2.34.1 > > -- H.J.