* [PATCH] x86: Remove the duplicated CPU_FEATURE_CPU_P
@ 2020-12-24 4:13 H.J. Lu
2020-12-24 12:37 ` H.J. Lu
2020-12-24 19:20 ` Florian Weimer
0 siblings, 2 replies; 3+ messages in thread
From: H.J. Lu @ 2020-12-24 4:13 UTC (permalink / raw)
To: libc-alpha
CPU_FEATURE_CPU_P is defined in sysdeps/x86/sys/platform/x86.h. Remove
the duplicated CPU_FEATURE_CPU_P in sysdeps/x86/include/cpu-features.h.
---
sysdeps/x86/include/cpu-features.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/sysdeps/x86/include/cpu-features.h b/sysdeps/x86/include/cpu-features.h
index f62be0b9b3..0df57d9a17 100644
--- a/sysdeps/x86/include/cpu-features.h
+++ b/sysdeps/x86/include/cpu-features.h
@@ -57,8 +57,6 @@ enum
|= ptr->features[index_cpu_##name].cpuid.reg_##name & bit_cpu_##name;
# define CPU_FEATURE_PREFERRED_P(ptr, name) \
((ptr->preferred[index_arch_##name] & bit_arch_##name) != 0)
-# define CPU_FEATURE_CPU_P(ptr, name) \
- CPU_FEATURE_CHECK_P (ptr, name, cpuid)
/* HAS_CPU_FEATURE evaluates to true if CPU supports the feature. */
# undef HAS_CPU_FEATURE
--
2.29.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: Remove the duplicated CPU_FEATURE_CPU_P
2020-12-24 4:13 [PATCH] x86: Remove the duplicated CPU_FEATURE_CPU_P H.J. Lu
@ 2020-12-24 12:37 ` H.J. Lu
2020-12-24 19:20 ` Florian Weimer
1 sibling, 0 replies; 3+ messages in thread
From: H.J. Lu @ 2020-12-24 12:37 UTC (permalink / raw)
To: GNU C Library
On Wed, Dec 23, 2020 at 8:13 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> CPU_FEATURE_CPU_P is defined in sysdeps/x86/sys/platform/x86.h. Remove
> the duplicated CPU_FEATURE_CPU_P in sysdeps/x86/include/cpu-features.h.
> ---
> sysdeps/x86/include/cpu-features.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sysdeps/x86/include/cpu-features.h b/sysdeps/x86/include/cpu-features.h
> index f62be0b9b3..0df57d9a17 100644
> --- a/sysdeps/x86/include/cpu-features.h
> +++ b/sysdeps/x86/include/cpu-features.h
> @@ -57,8 +57,6 @@ enum
> |= ptr->features[index_cpu_##name].cpuid.reg_##name & bit_cpu_##name;
> # define CPU_FEATURE_PREFERRED_P(ptr, name) \
> ((ptr->preferred[index_arch_##name] & bit_arch_##name) != 0)
> -# define CPU_FEATURE_CPU_P(ptr, name) \
> - CPU_FEATURE_CHECK_P (ptr, name, cpuid)
>
> /* HAS_CPU_FEATURE evaluates to true if CPU supports the feature. */
> # undef HAS_CPU_FEATURE
> --
> 2.29.2
>
I am checking it in.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: Remove the duplicated CPU_FEATURE_CPU_P
2020-12-24 4:13 [PATCH] x86: Remove the duplicated CPU_FEATURE_CPU_P H.J. Lu
2020-12-24 12:37 ` H.J. Lu
@ 2020-12-24 19:20 ` Florian Weimer
1 sibling, 0 replies; 3+ messages in thread
From: Florian Weimer @ 2020-12-24 19:20 UTC (permalink / raw)
To: H.J. Lu via Libc-alpha
* H. J. Lu via Libc-alpha:
> CPU_FEATURE_CPU_P is defined in sysdeps/x86/sys/platform/x86.h. Remove
> the duplicated CPU_FEATURE_CPU_P in sysdeps/x86/include/cpu-features.h.
> ---
> sysdeps/x86/include/cpu-features.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sysdeps/x86/include/cpu-features.h b/sysdeps/x86/include/cpu-features.h
> index f62be0b9b3..0df57d9a17 100644
> --- a/sysdeps/x86/include/cpu-features.h
> +++ b/sysdeps/x86/include/cpu-features.h
> @@ -57,8 +57,6 @@ enum
> |= ptr->features[index_cpu_##name].cpuid.reg_##name & bit_cpu_##name;
> # define CPU_FEATURE_PREFERRED_P(ptr, name) \
> ((ptr->preferred[index_arch_##name] & bit_arch_##name) != 0)
> -# define CPU_FEATURE_CPU_P(ptr, name) \
> - CPU_FEATURE_CHECK_P (ptr, name, cpuid)
>
> /* HAS_CPU_FEATURE evaluates to true if CPU supports the feature. */
> # undef HAS_CPU_FEATURE
There's also some _ISOMAC cruft in this file which should not be
needed because <cpu-features.h> is not an installed header.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-24 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-24 4:13 [PATCH] x86: Remove the duplicated CPU_FEATURE_CPU_P H.J. Lu
2020-12-24 12:37 ` H.J. Lu
2020-12-24 19:20 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).