From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id A55CD38582A3 for ; Fri, 5 Aug 2022 16:55:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A55CD38582A3 Received: by mail-pf1-x430.google.com with SMTP id q19so2730217pfg.8 for ; Fri, 05 Aug 2022 09:55:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=/Xd6DwW4GaCcWnt7e/Sjsf/+/DOAKp/fxXgrmNu7zeM=; b=CGuK2UHLi1Lj5eMK02xn4GfRAUpqy4DIkv17DHr4OGDsOwSrPV0HK3kuIV/A15etsj RLfwLD+WS4J6lxt6XL1O//HzHfvVn60VYos/NJiXko9z3WBVP6h+Lh3y3h2vH/uQ7adU VpcArResPVi+h6dbmqhpKaRcQyXKI4m9HSZ/0DCuI6CyP0B+P4tryhrTpOJIKpeA+vkx 4MvtluFIrGegKj0a0eHgOjioyQ2VYj0nFq/3titDH/f0HgZD3pQ1107cusSqLfKRWet9 HaORC7vANcUdJZ/xB9PvTAUXiBn91MgNSmyTetPxrFqblUQ26y+Ytldm6iwlpOv4VNOF umnA== X-Gm-Message-State: ACgBeo0ejYULBYNHMjtVoeC9wfjzUr0FVetHEf9tRWL/M01u4E+zmNRf Q1HF4yzenwbYt8h/WED5aUY81n+43zaxwH85y/Nty7g1 X-Google-Smtp-Source: AA6agR5GT42asp1fH7eiY1nWB6VDmX9FYKyCkT3TWUcHaY7dKwd8w1Q0OnY99mWMWCsO1yq/kiCyiJBGTHNfdsfaFFk= X-Received: by 2002:a63:82c2:0:b0:41b:c0f3:39b3 with SMTP id w185-20020a6382c2000000b0041bc0f339b3mr6428777pgd.86.1659718547496; Fri, 05 Aug 2022 09:55:47 -0700 (PDT) MIME-Version: 1.0 References: <20220804210016.2613403-1-adhemerval.zanella@linaro.org> In-Reply-To: From: "H.J. Lu" Date: Fri, 5 Aug 2022 09:55:11 -0700 Message-ID: Subject: Re: [PATCH] i386: Use fldt instead of fld on e_logl.S To: Adhemerval Zanella Netto Cc: Fangrui Song , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2022 16:55:50 -0000 On Fri, Aug 5, 2022 at 5:28 AM Adhemerval Zanella Netto wrote: > > > > On 04/08/22 18:35, H.J. Lu wrote: > > On Thu, Aug 4, 2022 at 2:31 PM Fangrui Song wrote: > >> > >> On Thu, Aug 4, 2022 at 2:24 PM H.J. Lu wrote: > >>> > >>> On Thu, Aug 4, 2022 at 2:00 PM Adhemerval Zanella > >>> wrote: > >>>> > >>>> Clang cannot assemble fldt in the AT&T dialect mode. > >>>> --- > >>>> sysdeps/i386/i686/fpu/e_logl.S | 4 ++-- > >>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/sysdeps/i386/i686/fpu/e_logl.S b/sysdeps/i386/i686/fpu/e_logl.S > >>>> index 63183ac544..5d53f3bb22 100644 > >>>> --- a/sysdeps/i386/i686/fpu/e_logl.S > >>>> +++ b/sysdeps/i386/i686/fpu/e_logl.S > >>>> @@ -43,7 +43,7 @@ ENTRY(__ieee754_logl) > >>>> fsubl MO(one) // x-1 : x : log(2) > >>>> 5: fld %st // x-1 : x-1 : x : log(2) > >>>> fabs // |x-1| : x-1 : x : log(2) > >>>> - fld MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > >>>> + fldt MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > >>>> fcomip %st(1) // |x-1| : x-1 : x : log(2) > >>>> fstp %st(0) // x-1 : x : log(2) > >>>> jc 2f > >>>> @@ -76,7 +76,7 @@ ENTRY(__logl_finite) > >>>> fsubl MO(one) // x-1 : x : log(2) > >>>> fld %st // x-1 : x-1 : x : log(2) > >>>> fabs // |x-1| : x-1 : x : log(2) > >>>> - fld MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > >>>> + fldt MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > >>>> fcomip %st(1) // |x-1| : x-1 : x : log(2) > >>>> fstp %st(0) // x-1 : x : log(2) > >>>> jc 2b > >>>> -- > >>>> 2.34.1 > >>>> > >>> > >>> I don't think this is correct since there are > >>> > >>> .type limit,@object > >>> limit: .double 0.29 > >>> > >>> It should be fldl. > >>> > >>> -- > >>> H.J. > >> > >> If I am not mistaken, the existing fld has a bug as it is treated as flds > > > > True. It doesn't seem to cause any issue. > > > >> fld limit@GOTOFF(%edx) # treated as flds > >> flds limit@GOTOFF(%edx) > >> fldl limit@GOTOFF(%edx) > >> fldt limit@GOTOFF(%edx) > >> > >> .section .rodata.cst8,"aM",@progbits,8 > >> .p2align 3 > >> limit: .double 0.29 > > fldl works and it see the best option. Ok with this change? Yes. Thanks. -- H.J.