From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id A48E6385800C for ; Mon, 8 Nov 2021 18:43:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A48E6385800C Received: by mail-pg1-x52e.google.com with SMTP id p8so14626216pgh.11 for ; Mon, 08 Nov 2021 10:43:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iGaJdtptPnr6AVizQ8+Fuuvy2Nmugby+e/Zx/lSTbus=; b=M5t5yWX6dXOO7mBWzsFFKDgD0KXLIRy5dlLBArBVzLbMlhyJFQil5HKD6uIPj9wlSS yCF2pbl2T/l+Oa3dnSPQq1vZCZmx927/kdFTdIczSn8s1Q+0+hbJflNesD1DiXCjmQxB qypNYpa5fN3g+vIGyo9V9Wxwlf9ovBl7CoSyUxhCFMG5VFuyLuEqZtThQ40SoEC99ESr 1XKODEKuNQXIwIoOsnxl2EOiFLnDUmXDPTF69F2xT0I8GLCngx3ImwNVnl+oiN8AXhff lCxhr7kdBcHnmfpbIpffQM4VpMGtR7OxO+Wgj2Vl94uXhg2+PHzQwLyEue/xTA//ccLt OipQ== X-Gm-Message-State: AOAM532KpfN8XTW6C21N8qLHqWuuaO6T0pJyXs8Hp0JTtTuT15XksB4L EaeQzlyGWTPDnK/rL6QftWnGSLD7u+zV4D4EBFQtKkXyNnQ= X-Google-Smtp-Source: ABdhPJzd9JJeovc98Wn6zj41a5vEsxsjNErN4NFno2ordHV0PEnbbLWy2PnqmAv0w7215n3aOdJkhWkOyQMwV7rxyQs= X-Received: by 2002:a63:2155:: with SMTP id s21mr1195283pgm.20.1636397011844; Mon, 08 Nov 2021 10:43:31 -0800 (PST) MIME-Version: 1.0 References: <20211106135053.141779-1-hjl.tools@gmail.com> <87cznay6to.fsf@igel.home> In-Reply-To: <87cznay6to.fsf@igel.home> From: "H.J. Lu" Date: Mon, 8 Nov 2021 10:42:56 -0800 Message-ID: Subject: Re: [PATCH] Remove the unnecessary +make-deps To: Andreas Schwab Cc: "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 18:43:35 -0000 On Mon, Nov 8, 2021 at 8:01 AM Andreas Schwab wrote: > > On Nov 06 2021, H.J. Lu via Libc-alpha wrote: > > > diff --git a/Makerules b/Makerules > > index 3503605a8e..8db0ca1296 100644 > > --- a/Makerules > > +++ b/Makerules > > @@ -459,15 +459,6 @@ compile-stdin.c = $(COMPILE.c) -o $@ -x c - $(compile-mkdep-flags) > > # get the wrong predefines. > > S-CPPFLAGS = -DASSEMBLER $(asm-CPPFLAGS) > > > > -define +make-deps > > -$(make-target-directory) > > -$(+mkdep) $< $(if $(filter %.c,$<),$(CFLAGS)) \ > > This was the last use of +mkdep. > > > diff --git a/sysdeps/unix/Makefile b/sysdeps/unix/Makefile > > index 2ee3be7237..582baa4bd8 100644 > > --- a/sysdeps/unix/Makefile > > +++ b/sysdeps/unix/Makefile > > @@ -104,10 +104,6 @@ $(common-objpfx)sysd-syscalls: $(..)sysdeps/unix/make-syscalls.sh \ > > mv -f $@T $@ > > endif > > > > -$(common-objpfx)s-%.d: $(..)sysdeps/unix/s-%.S \ > > - $(wildcard $(+sysdep_dirs:%=%/syscalls.list)) > > This was the last reference to sysdeps/unix/s-proto.S and > sysdeps/unix/s-proto-cancel.S. > > Andreas. > The v2 patch is at https://sourceware.org/pipermail/libc-alpha/2021-November/132816.html -- H.J.