From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com
 [IPv6:2607:f8b0:4864:20::343])
 by sourceware.org (Postfix) with ESMTPS id DFD293850404
 for <libc-alpha@sourceware.org>; Tue, 24 Nov 2020 17:16:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DFD293850404
Received: by mail-ot1-x343.google.com with SMTP id 11so7510699oty.9
 for <libc-alpha@sourceware.org>; Tue, 24 Nov 2020 09:16:44 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=67ZT/2A3biN7fl3C18ZFUe+1VZ4qz+psvA8nWo/Zkdc=;
 b=o6xgSbU4xpNtVI1VfH1VgOvQnu4WuRzLi/H1Smu7ecieiUquWOF1nDQ97AL/xbYfF0
 xCLz8JY7CEOFNeJ+5AjcLxn/IgZ2uXuW68/LV0OnX//eyyvK+iWeHaa3hIW9W9vEeR4M
 rU4OKgOLDyZdyvhox8Ah8gh4vxzdx78HHDfaqgYRe/aFhV2q6TGLGLww/HyTZ9g4JvaO
 /dr/WZJSx+kwaBL9MsoFy0gJjXtxjSO7/QMf6L/fYZ2nstBh+7FmRG3PitySnFT3BCty
 6W5LR4UrKls3hGxo4mic3baPLIqGKVhu/u/gZvDJgz6udJr4sQydV4AhQvrvqjrVa5oK
 zi7A==
X-Gm-Message-State: AOAM531juzqdQoNjT487/uENr7VkTjsIjW4ScvAGbf/eK7XNbvR5PVtU
 N7IewsNnY4K12+YpVla+wOKBRS7Mv9C4WrG13Xc=
X-Google-Smtp-Source: ABdhPJwTHlN0ll/qbBH2rxnN1kNorTdJKk4XQ1jOEW3Ym4MWLzq2PD3MZ6ACD23wvYlo73yJrwIvNhhu0MaHbaG39Gc=
X-Received: by 2002:a9d:23e6:: with SMTP id t93mr3840329otb.269.1606238204383; 
 Tue, 24 Nov 2020 09:16:44 -0800 (PST)
MIME-Version: 1.0
References: <mvmpn42anev.fsf@suse.de>
 <CAMe9rOoOdZgjc__iYESJYGSKb0vY0r5fGKVRoO_UkwLjB5iB7g@mail.gmail.com>
 <mvmlfeqak34.fsf@suse.de>
 <CAMe9rOrDtLth2F7Fbpymm9Mekm9h12FQcKiDq_Z4FGq7SBQzMw@mail.gmail.com>
 <87h7peu5e6.fsf@igel.home>
 <CAMe9rOr_D4J06rhAFvkFecDrR2VHBe8-73FbJoUEjj6iLYhsKA@mail.gmail.com>
 <878saqu40b.fsf@igel.home>
In-Reply-To: <878saqu40b.fsf@igel.home>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 24 Nov 2020 09:16:07 -0800
Message-ID: <CAMe9rOpXUCj4WruNaW3-OYXPfS1RsVT8C89VMTJ1x2NhKkh9VQ@mail.gmail.com>
Subject: Re: [PATCH] Turn ___brk_addr into a compat symbol
To: Andreas Schwab <schwab@suse.de>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3030.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2020 17:16:47 -0000

On Tue, Nov 24, 2020 at 8:13 AM Andreas Schwab <schwab@suse.de> wrote:
>
> On Nov 24 2020, H.J. Lu via Libc-alpha wrote:
>
> > On Tue, Nov 24, 2020 at 7:43 AM Andreas Schwab <schwab@suse.de> wrote:
> >>
> >> On Nov 24 2020, H.J. Lu via Libc-alpha wrote:
> >>
> >> > I think ___brk_addr should be removed for ia64 and microblaze.
> >>
> >> That's exactly what I do.
> >>
> >
> > You added
> >
> > #include <shlib-compat.h>
> > ...
> > compat_symbol (libc, __curbrk, ___brk_addr, GLIBC_2_0);
> >
> > to ia64 and microblaze.
>
> Yes, and?
>

There is no need for that.  ___brk_addr should be simply removed from ia64
and microblaze.

-- 
H.J.