From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id BB0263858D28 for ; Wed, 17 Nov 2021 15:39:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB0263858D28 Received: by mail-pj1-x1030.google.com with SMTP id gf14-20020a17090ac7ce00b001a7a2a0b5c3so5546676pjb.5 for ; Wed, 17 Nov 2021 07:39:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gJaqUV7JhC9owcYal5t04PB82Ida0s4v/i36GaavVSQ=; b=gIK0FM9pWyZKPBycQpunCYzj8n9ZXR4k/8/BF/eAg7HJxutJk1iNC40A+2YdnfipAV Ol4BPqlGE/uFipT6eMjb+VcLu4ybQLvxYgbX5KfvKLezRfFXf1SPIHP0kjm8gfrUnqoI k09UEptXPmntHAaLI9D4BWKdm0B3f0yJFD+eK0hVyrTgijlInu2U1J4ujSplpeu8p5st L+ELFwD9HBTcBFQ2e7oLcpjLH4sfYdDRAQexeLRqaa1M7MCGSebCavedfa2/aXsXCAQH B87171IbOh1huR7yl2pQhml7RN/D7t/FRzQzwAfPFduRKtyV+Ty7W2RgCFmGkk50lDE7 EX2g== X-Gm-Message-State: AOAM533OE/zBIvgKd83/VOOKGmDQRp4flaIfIL5+y4EzhebfppndedYo ++AKnBJtqJY+w5wz6AfzTFuiAu4Pa4Qwb8UXarY= X-Google-Smtp-Source: ABdhPJzsIVa0h3D8RYcmBxEbMPCrH6IoRTjJ2k264nSphHXZKmPP5Tqz2g6uSBRatISKBl0vPxK7oNJTXm83OL205K8= X-Received: by 2002:a17:902:cecf:b0:141:e15d:4a2a with SMTP id d15-20020a170902cecf00b00141e15d4a2amr56624541plg.66.1637163576884; Wed, 17 Nov 2021 07:39:36 -0800 (PST) MIME-Version: 1.0 References: <20211116131418.2070092-1-hjl.tools@gmail.com> <87zgq26gee.fsf@oldenburg.str.redhat.com> <87h7ca6brq.fsf@oldenburg.str.redhat.com> In-Reply-To: <87h7ca6brq.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Wed, 17 Nov 2021 07:39:01 -0800 Message-ID: Subject: Re: [PATCH v2] elf: Use a temporary file to generate Makefile fragments [BZ #28550] To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2021 15:39:39 -0000 On Wed, Nov 17, 2021 at 7:29 AM Florian Weimer wrote: > > * H. J. Lu: > > > On Wed, Nov 17, 2021 at 5:49 AM Florian Weimer wro= te: > >> > >> I still see > >> > >> /builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/build-x86_64-r= edhat-linux/elf/dso-sort-tests-2.def.generated-makefile:1067: warning: over= riding recipe for target '/builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b= 5483/build-x86_64-redhat-linux/elf/tst-redhat-1162810-dir/tst-redhat-116281= 0-M22X17.os' > >> > >> and eventually a build failure: > >> > >> make[2]: Leaving directory '/builddir/build/BUILD/glibc-2.34.9000-29= 4-ga43c0b5483/elf' > >> make[1]: *** [Makefile:483: elf/tests] Error 2 > >> make: *** [Makefile:9: check] Error 2 > >> > >> There's no error before that, or other message indicating which make > >> target is failing. > >> > >> The full build log is here: > >> > >> > >> > >> > >> The make error messages are not very helpful to me though. > >> > > > > It also happened to me in a build directory whose path contains a > > symbolic linked directory. Make was confused to include the generated > > makefile twice, which could be reached with 2 different pathnames. > > After removing the symbolic linked directory, the generated makefile > > can be reached with a single pathname, the make error went away. > > This is a standard Koji build environment. The build directory is not a > symbolic link: > > + readlink -f . > /builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/build-x86_64-redhat= -linux > > And we reach that via /builddir/build/BUILD. > > So I still don't know what's going on there. > In my case, the same makefile fragment was included twice. Can you try https://sourceware.org/pipermail/libc-alpha/2021-November/132795.html --=20 H.J.