From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 8435B385482D for ; Mon, 28 Dec 2020 21:50:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8435B385482D Received: by mail-ot1-x32c.google.com with SMTP id i6so10369111otr.2 for ; Mon, 28 Dec 2020 13:50:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l+dXvhABtwxU6s8/RfdEEdcBRuronwaoNXk5zu7DuOA=; b=slvjHxSVU+FFw1qZVWl7WQbYGjiKyPy0ajlZxY3uMVY1z9g5ErOtPBPY2uIdjVQEjM LKLL8CuQi0NOANtPxcf6oxNNYi5pU8EN4oqIDD+ijc9QmcK8XBncmVakdE8IbsbgWCLW q0wmHrEogXmnVLGEuQcTQ8O0Je5cw/znssY8wsbNx9/YnqnjmZaRkbMgN0QjB+4I3bm1 tg0Qb0S/kRsQNH0ZlzBp+G4bsHy+gYTeBtBnPKBw1HU371mQzCJ/95En9WOMUbO6HgTZ a2oaIikhOCQcZDI/PjrKm5sUMtx45tVTP1L7Lgq3mcyjkWigr/AblZXwczx74n6TLpVl 0Yuw== X-Gm-Message-State: AOAM532cZeH7fB9/1k8aI9MaoAqbdsa7hrQluAZWR7U9Pa59fz5QSOvv CyhrQQU3MfCI/VQrJZclUc4DyzJB5kfJJwGyudY= X-Google-Smtp-Source: ABdhPJyPmD0EizqHKO+l7qqG6G3YardUHwek1NBSzXZLEVQ5+m/r6txBJI6o0P/pnNGljhcuEvd9uYK66OBTlWgxr+Q= X-Received: by 2002:a05:6830:1d71:: with SMTP id l17mr34324757oti.269.1609192206888; Mon, 28 Dec 2020 13:50:06 -0800 (PST) MIME-Version: 1.0 References: <20201228194855.510315-1-maskray@google.com> <20201228214541.phbfjgv2ft3mgikj@google.com> In-Reply-To: <20201228214541.phbfjgv2ft3mgikj@google.com> From: "H.J. Lu" Date: Mon, 28 Dec 2020 13:49:30 -0800 Message-ID: Subject: Re: [PATCH 0/3] Make glibc build with LLD To: Fangrui Song Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2020 21:50:08 -0000 On Mon, Dec 28, 2020 at 1:45 PM Fangrui Song wrote: > > On 2020-12-28, H.J. Lu wrote: > >On Mon, Dec 28, 2020 at 11:49 AM Fangrui Song via Libc-alpha > > wrote: > >> > >> I sent the first two in April. Resending in a patch series to be > >> clearer. > >> > >> install: Replace scripts/output-format.sed with objdump -f > >> > >> replaced https://sourceware.org/pipermail/libc-alpha/2020-April/112733.html > >> by leveraging objdump -f. > >> > >> With this patch series (available in https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/maskray/lld), > >> `make` with ld pointing to ld.lld (LLVM linker) works. > > > >I tried your branch with "LLD 11.0.0 (compatible with GNU linkers)" on > >Fedora 33/x86-64, > >"make check" generated: > > > >make[4]: *** [../Makerules:767: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-tlsmod2.so] > >Error 1 > >make[4]: *** [../Makerules:767: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-tlsmod4.so] > >Error 1 > >make[4]: *** [../Makerules:767: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-absolute-sym-lib.so] > >Error 1 > >make[4]: *** [../Makerules:767: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-absolute-zero-lib.so] > >Error 1 > >make[4]: *** [../Makerules:767: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-tlsmod6.so] > >Error 1 > >make[4]: *** [../Makerules:767: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-tlsmod5.so] > >Error 1 > >make[4]: *** [../Rules:226: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-audit16] > >Error 1 > >make[4]: *** [../Rules:226: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-audit14] > >Error 1 > >make[4]: *** [../Rules:226: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-audit15] > >Error 1 > >make[4]: *** [../Rules:226: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-tls1] > >Error 1 > >make[4]: *** [../Rules:226: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/ifuncmain5] > >Error 1 > >make[4]: *** [../Rules:226: > >/export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/ifuncmain1] > >Error 1 > >make[3]: *** [Makefile:479: elf/tests] Error 2 > > > >with error messages, like > > > >ld: error: /export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-tlsmod2.os > >has an STT_TLS symbol but doesn't have an SHF_TLS section > >ld: error: /export/users/hjl/build/gnu/tools-build/glibc-gitlab-lld/build-x86_64-linux/elf/tst-tlsmod4.os > >has an STT_TLS symbol but doesn't have an SHF_TLS section > > tst-tls* tests appear to be similar to .tls_common which looks very > obsoleted and not supported by Clang. I don't think ifuncmain* or > tst-audit* matters for typical usage (most users) but I can take a look. "make check" should be clean on Fedora 33/x86-64. > >When glibc is configured with --enable-static-pie, I got > > > >[hjl@gnu-skx-1 build-x86_64-linux]$ ./elf/ldconfig > >Segmentation fault (core dumped) > >[hjl@gnu-skx-1 build-x86_64-linux]$ > > > >You need to fix lld first and give the working lld a proper version so that > >configure can check it. > > I cherry picked "Make _dl_relocate_static_pie return an int indicating whether it applied relocs." > in google/grte/v5-2.27/master, which has fixed the issue. Why isn't it needed for ld? -- H.J.