From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com
 [IPv6:2607:f8b0:4864:20::d2f])
 by sourceware.org (Postfix) with ESMTPS id 186A13857C53
 for <libc-alpha@sourceware.org>; Mon,  6 Jul 2020 13:14:20 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 186A13857C53
Received: by mail-io1-xd2f.google.com with SMTP id k23so39188913iom.10
 for <libc-alpha@sourceware.org>; Mon, 06 Jul 2020 06:14:20 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=9vojOQpAP0sTqrfOb5yBdRbvUNWOSbjl8YbTW28r5sg=;
 b=YHhG+UaIDqw8Rs9Ph/ARebE3L1ulLFp2mLelHlD12zmt9JzSOCS47nNpz7sBztzDpj
 U5J8yOJm0iIP2Cpj/JFv7TRGzKuQjOGOfR0uVSPi5rXrYK773mGuRQAquCcAfhuUafvc
 WwPjc6FLEoNKo1IJEDHwLUB8L9/lckCoaXvBi5KHbAhQ0Cs6YhWe5SeQ8CLFENPBxKVN
 tM+PXimwFpBwMwQK3CF03nAMTTJ4kRUEl+vCbFLHJXiCuw7q/NZQMIAkTWVMaK28NXsp
 qKEN1MDaIeDSLbGP3Ad9/qty4OtRvauC/F3XraOpcTAvkXE6PbAFscliIFBaMU9sl9j3
 4Mmg==
X-Gm-Message-State: AOAM531Iw4o3Ug94SOVILsPuRGEv0dtxAZBMv34IDDa3sb/mHxsMgfE9
 w4T/eNdwswHXGnHRnLMaxAQLSqZM1LWhxgxQj2seng==
X-Google-Smtp-Source: ABdhPJxamEp7cqbljwoXW+uZ/3pzYEFnJa6+a5nvrszTH/+ump3dILkqWeupSj0Mm5gpshN4b1FyDCAov5NEzryzJ5g=
X-Received: by 2002:a6b:9246:: with SMTP id u67mr25015487iod.51.1594041259462; 
 Mon, 06 Jul 2020 06:14:19 -0700 (PDT)
MIME-Version: 1.0
References: <20200703175220.1178840-1-hjl.tools@gmail.com>
 <20200703175220.1178840-2-hjl.tools@gmail.com>
 <cc15fba0-0fc1-d0fa-3895-fda3bafb8f1b@redhat.com>
 <20200703230951.GA1301408@gmail.com>
 <d8bff242-5b98-64a0-c269-547ec24956b0@redhat.com>
In-Reply-To: <d8bff242-5b98-64a0-c269-547ec24956b0@redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 6 Jul 2020 06:13:43 -0700
Message-ID: <CAMe9rOp_k0HYRJSm4F8R0GsVbWqMQNnmNRArz+SeOQ_e85KEkw@mail.gmail.com>
Subject: Re: V2 [PATCH 1/2] Update tunable min/max values
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jul 2020 13:14:21 -0000

On Mon, Jul 6, 2020 at 5:47 AM Carlos O'Donell <carlos@redhat.com> wrote:
>
> On 7/3/20 7:09 PM, H.J. Lu wrote:
> >> Why not raise the dl-tunables.list minimum to 1?
> >> Then the above code just becomes what we used to have.
> >
> > What we used to have are
> >
> >   cpu_features->non_temporal_threshold
> >     = TUNABLE_GET (x86_non_temporal_threshold, long int, NULL);
> > ...
> >   __x86_shared_non_temporal_threshold
> >     = (cpu_features->non_temporal_threshold != 0
> >        ? cpu_features->non_temporal_threshold
> >        : __x86_shared_cache_size * threads * 3 / 4);
> >
> > I just changed the order.
> This is a bug in sysdeps/x86/dl-tunables.list where we have failed
> to set the minimum to 1. Please fix dl-tunables.list instead of
> rewriting the code which is incorrect?

I will update this patch after 2.32 is branched since it isn't needed for
2.32.


-- 
H.J.