From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by sourceware.org (Postfix) with ESMTPS id 84ED53858D28 for ; Tue, 2 Apr 2024 15:08:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84ED53858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84ED53858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712070527; cv=none; b=ar3Djh6e0+FcDPTtYE+T2KGIe6WNTl95BxQsgBEKWBW5B9ughpaPoiK3c3GBG5E6MYeKgqpFqjjMlHv8uKqD4mDaTXKxcBPNYCNUp/g1I8jnTfb1jjo5ZG+bWLvLKfOaGhGhdEqIaP200pFTsOj+IlOMgyfuhESiw7UcMl+iW68= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712070527; c=relaxed/simple; bh=K6Rbb10qrCKdgvxrYsg01jRHtANl+ruovJy3y4GnQJU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=D5c3ez3T+eAbK5FdlQUT0mu1UD+WuWSd275+SniA/A1gD7jfoDTpV8YkqPCP00Qc97piOdxlF+CzcG3j9pvzReAR+uQHBMvRj7x+61nffE75ui5b8CopWW6Fex8lqTVWqS1HsAD4m/rvfbYs4jWYRkDl5rg0APOKLy8Eqp3ST/s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-6153d343a4eso4413197b3.0 for ; Tue, 02 Apr 2024 08:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712070526; x=1712675326; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K6Rbb10qrCKdgvxrYsg01jRHtANl+ruovJy3y4GnQJU=; b=IVq4DLsj4pec1uwurgZwQpIjusmvKOKTiYizUvH70oYKUqcMeeRiOTPc1SRS2NO/6f 4gEQyhBJfdBrzpbonydSms20OtxMk/XaUUvllL9EXtbHaWlIGCPyvdfxto3TbdQhnNro WypT71TT+Zui3mvt5dyoYsEcOgsJvfzQS78puhz7+LV+PZl/bHx1Hr6Xbz/KdihdLUox NI/tsC+/se8o2lPAt8geuLUhjffAS7xy6/B7Sqkkq0FqHl78XogbTcKlv5VsNllLJP3y saiTMM23uaWWPf/2WvIcEu8TutfE6umqCSMd/1b6QcEKiAA3wL23UeHBp/RgOqv8kTe4 GXQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712070526; x=1712675326; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K6Rbb10qrCKdgvxrYsg01jRHtANl+ruovJy3y4GnQJU=; b=KlEOI1eayPK5T3Nk7v2exaMdoucU1aaw+mAFlf3HXXJPGimw9PhhB0KpzbHwUVW7wz PMRGbVheDS9fXrFiJ3kK0CHV0zxDY8YE+9DNKnST5G5wU8K3+NN932jH/YR2xEKQ/vBS 5VX8zwARcZFyPmJC/jCUu7JQxKEnQuM234zE6CPBK8f++tbmhTiDZeMX1RNA5bE/ZBDJ VYMQBHK3HJVYMm4CKXkcyEJconVzfYNVsJ+nLjxKtV5WqxuoQ3bZfctpsCHkvdch+oGm ba6/H5oiPY0AWpDlHiaWY4CcZ3mizwu+uGJV5s6zUWFM/LpauAleWAWOPaMToO7I2q2j ZZWg== X-Forwarded-Encrypted: i=1; AJvYcCVEtB9SuWVtds7P5kdbiNdKLbVVdTdLfRSvUU3SyuwAkMbtwcZK3VrusvUvy32S5AlGgU6da0hGDvq9ZD4JqKopDtgwtVMr9TCT X-Gm-Message-State: AOJu0Ywj7SvQbv6N+L9v9lYfng4kWyHxsC92b7VC3rgAjF/e9q8NuzT5 BHt9MGZhB88D3aevGXCmvc6CPijtxLFNtOvJFXHe7/Jwe+r1f2l1aTOrHLxbvSs2Vf8VuKKZ9UD MJiyEP+N9axr/HOmtJZDHvtXBqAU= X-Google-Smtp-Source: AGHT+IE96vrW6E+c5U+Bpxstw8qm5+tKT9PK2qEIzomuGs9J8YcCmTw8Bh885MNtxq3dPw28LbN8mO2QWfupY1qLvuQ= X-Received: by 2002:a0d:e906:0:b0:610:f586:2b42 with SMTP id s6-20020a0de906000000b00610f5862b42mr11159408ywe.46.1712070525749; Tue, 02 Apr 2024 08:08:45 -0700 (PDT) MIME-Version: 1.0 References: <1711806052-117857-1-git-send-email-xiaojiangfeng@huawei.com> <1711939509-1411-1-git-send-email-xiaojiangfeng@huawei.com> <3f6a6290-9136-4a72-a24b-7c6bb7965569@linaro.org> <0d0aaf71-4f20-0bc1-9ac7-f31f1b426398@huawei.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 2 Apr 2024 08:08:09 -0700 Message-ID: Subject: Re: [PATCH] elf: sanitize objname in _dl_signal_error To: Jiangfeng Xiao Cc: Adhemerval Zanella Netto , libc-alpha@sourceware.org, schwab@linux-m68k.org, nixiaoming@huawei.com, douzhaolei@huawei.com, wangbing6@huawei.com, wangfangpeng1@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 2, 2024 at 8:06=E2=80=AFAM Jiangfeng Xiao wrote: > > > > On 2024/4/2 23:00, H.J. Lu wrote: > > >>> > >> > >> Maybe. However, the glibc code may reference null pointers, > >> which should be fixed. > > > > Not if a null pointer should never happen. > > > If the fatal_error(0, NULL, NULL, NULL, "invalid mode parameter") Please open a glibc bug to track it. > code in the _dl_signal_error function will never be executed, > delete the redundant code. If it is possible, even if the > possibility is very low, it should be fixed. --=20 H.J.