From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 99DDD3857C5B for ; Fri, 5 Nov 2021 14:01:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99DDD3857C5B Received: by mail-pg1-x52f.google.com with SMTP id b4so8440129pgh.10 for ; Fri, 05 Nov 2021 07:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qIXKe2twjOZ67AfTtJxjpDJ0XIqscxJbUBxCiAPj9p0=; b=b5Kk5PaXVMy/8vFo1xRhe4LBEZWRwjixC/VPdxgpWmvV2JtK2iaMQ2/hj6b1vNnwgm bva4uERt7ZJMdfVU/CgL2Ge9N4h7uzfQFB4z09ZPIgYSxfcFOqxZhfMvLxPF8nwMm3To Ej9DaYk/92YzeFBFHJFmIU3np3WlwPl8tvPtDC0NTiXz4+w8PnDfUtknQEYUv6Ck50IB 8IEYpH9uSCkeu1aet4Ah1H+Iz1AlDIsEtXhH8Spe2G8gy2fa5ud+ikx1VQpGM9uo+SO4 buDUlgtp5uMvfbEDkTFwgwIZjZTb+weLGf96K6otMrcZLOUv9lXF+BSi54MZSuYghiXY Ahig== X-Gm-Message-State: AOAM53280XdDty5O1/E+RJJAoG9SEIQdTgky83ONdTdfMHyX3w9LuS7v /pUhC6t59GZot76gAr+kI2m18JHDruaxaKscV84dthGq X-Google-Smtp-Source: ABdhPJwkpWZkQbmaYvnbhTOOjj8uPwlWSR6BdzfWSmKHbMgXA6vfbqbCWetipgFebD38+DG5jwEDiczVCdRM/7FT/cw= X-Received: by 2002:a63:87c1:: with SMTP id i184mr27373156pge.75.1636120877651; Fri, 05 Nov 2021 07:01:17 -0700 (PDT) MIME-Version: 1.0 References: <20211021134122.3141-1-cltang@codesourcery.com> <87sfwavhne.fsf@oldenburg.str.redhat.com> In-Reply-To: <87sfwavhne.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Fri, 5 Nov 2021 07:00:41 -0700 Message-ID: Subject: Re: [PATCH v8 1/2] elf: Testing infrastructure for ld.so DSO sorting (BZ #17645) To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" , Chung-Lin Tang Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3023.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 14:01:24 -0000 On Fri, Nov 5, 2021 at 6:47 AM Florian Weimer wrote: > > * H. J. Lu via Libc-alpha: > > >> +# DSO sorting tests: > >> +# The dso-ordering-test.py script generates testcase source files in $(objpfx), > >> +# creating a $(objpfx)-dir for each testcase, and creates a > >> +# Makefile fragment to be included. > >> +define include_dsosort_tests > >> +$(objpfx)$(1).generated-makefile: $(1) > >> + $(PYTHON) $(..)scripts/dso-ordering-test.py \ > >> + --description-file $$< --objpfx $(objpfx) --output-makefile $$@ > >> +include $(objpfx)$(1).generated-makefile > >> +endef > >> + > >> +# Generate from each testcase description file > >> +$(eval $(call include_dsosort_tests,dso-sort-tests-1.def)) > >> +$(eval $(call include_dsosort_tests,dso-sort-tests-2.def)) > >> + > > > > I don't think it works with parallel build on many-core machines. > > I think it should be changed to use configure.ac or Makeconfig > > to generate these makefile fragments, similar to > > > > https://sourceware.org/git/?p=glibc.git;a=commit;h=d962cce139583c71fcbe9a05dc4c5fa68f72f655 > > > > I opened: > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=28550 > > Probably this needs to be: > > define include_dsosort_tests > $(objpfx)$(1).generated-makefile: $(1) > $(PYTHON) $(..)scripts/dso-ordering-test.py \ > --description-file $$< --objpfx $(objpfx) --output-makefile $$@T > mv $$@T $$@ > include $(objpfx)$(1).generated-makefile > endef > > So that make doesn't read a partial file. This may work. But using Makeconfig is safer. -- H.J.