On Thu, Oct 1, 2020 at 1:46 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
> > index dadec5d58f..65ab29123d 100644
> > --- a/sysdeps/x86/cacheinfo.c
> > +++ b/sysdeps/x86/cacheinfo.c
> > @@ -16,7 +16,9 @@
> >     License along with the GNU C Library; if not, see
> >     <https://www.gnu.org/licenses/>.  */
> >
> > -#if IS_IN (libc)
> > +/* NB: In libc.a, this file is included in libc-static.c.  In libc.so,
> > +   this file is standalone.  */
> > +#if IS_IN (libc) && (defined SHARED || defined _PRIVATE_CPU_FEATURES_H)
>
> libc-static.c should be libc-start.c, I believe.  The “defined
> _PRIVATE_CPU_FEATURES_H” part seems rather indirect.  What exactly are
> you trying to accomplish here?
>
> It looks to me as if this file should included in libc.so, but not
> pulled into ld.so via the rebuild, so maybe you can add an empty
> sysdeps/x86/rtld-cacheinfo.c file instead?
>

Here is the updated patch.   I also moved files around to prepare
for moving x86 processor cache info to cpu_features in ld.so to
support --list-tunables.


-- 
H.J.