From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by sourceware.org (Postfix) with ESMTPS id 0EE05385BF83 for ; Mon, 6 Apr 2020 18:40:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0EE05385BF83 Received: by mail-il1-x141.google.com with SMTP id j9so490839ilr.7 for ; Mon, 06 Apr 2020 11:40:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Miz1ChVXPk3VtltpoEKSAShURSDWe4FElpLNDo0eZYg=; b=LBDPkBqsV5XBfj4Yn380t4tcmuwqIuhM64C9FJP4yV+7uX8muspNI+Sv14xx1fjl/T hQue5BcPxEhOvBh6NH1UxQUX5FwfyTHImxIFWR5vquxPvGy3j+zDD7bHl1R2/LQvXtNn wU8ko1peT9maZrRcCEZ4sD7iwBy/T890tL8hhqZzIhPOp8CDphROMn339QGNEPK1S7WS N0dgQNnhsShyFS2R0O9kBqpj7N6seGm2LlCri+HX28IE7ZZwPgz2rz2JYxzzJqdGZZ7y SKQPLsium/P/OKHP/nO1FahwstjkUFSGKGJU5bnXVgGc8uRqhrVpjqv5i5L+WmTKW4yk wd1g== X-Gm-Message-State: AGi0PuaVrmiYXg0772Imv6lwYIngUwIr2FTquFdt3/VR3xREdTnBzFp5 DaIj5jdpdmmELEZnnQwyH4IMV5LPvCzmiPThSwLEw3si X-Google-Smtp-Source: APiQypKxtKCSYF7ghGSqtkQvoN/kxX37WemGDLv5ZqZW5okY2P6X1kqTYYWftHtLy3H18+qJnIPHvXDlCK3Su0z0rLs= X-Received: by 2002:a92:86da:: with SMTP id l87mr755721ilh.292.1586198430479; Mon, 06 Apr 2020 11:40:30 -0700 (PDT) MIME-Version: 1.0 References: <20200406144914.1640384-1-hjl.tools@gmail.com> <73030137-e19b-c532-49b7-f4679520fa38@linaro.org> In-Reply-To: <73030137-e19b-c532-49b7-f4679520fa38@linaro.org> From: "H.J. Lu" Date: Mon, 6 Apr 2020 11:39:54 -0700 Message-ID: Subject: V2 [PATCH] i386: Remove build support for GCC older than GCC 6 To: Adhemerval Zanella Cc: GNU C Library Content-Type: multipart/mixed; boundary="000000000000fe20d405a2a39965" X-Spam-Status: No, score=-18.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2020 18:40:33 -0000 --000000000000fe20d405a2a39965 Content-Type: text/plain; charset="UTF-8" On Mon, Apr 6, 2020 at 10:38 AM Adhemerval Zanella via Libc-alpha wrote: > > > > On 06/04/2020 11:49, H.J. Lu via Libc-alpha wrote: > > > diff --git a/sysdeps/unix/sysv/linux/i386/sysdep.h b/sysdeps/unix/sysv/linux/i386/sysdep.h > > index 6671afe65e..cfa562ecb0 100644 > > --- a/sysdeps/unix/sysv/linux/i386/sysdep.h > > +++ b/sysdeps/unix/sysv/linux/i386/sysdep.h > > @@ -43,15 +43,6 @@ > > # endif > > #endif > > > > -/* Since GCC 5 and above can properly spill %ebx with PIC when needed, > > - we can inline syscalls with 6 arguments if GCC 5 or above is used > > - to compile glibc. Disable GCC 5 optimization when compiling for > > - profiling or when -fno-omit-frame-pointer is used since asm ("ebp") > > - can't be used to put the 6th argument in %ebp for syscall. */ > > -#if __GNUC_PREREQ (5,0) && !defined PROF && CAN_USE_REGISTER_ASM_EBP > > -# define OPTIMIZE_FOR_GCC_5 > > -#endif > > - > > Unfortunately we can't remove the alternate syscall mechanism that is > usd for GCC older than 5, since it is used for -Os and > -fno-omit-frame-pointer (CAN_USE_REGISTER_ASM_EBP). Here is the updated patch to remove __GNUC_PREREQ (5,0). -- H.J. --000000000000fe20d405a2a39965 Content-Type: application/x-patch; name="0001-i386-Remove-build-support-for-GCC-older-than-GCC-6.patch" Content-Disposition: attachment; filename="0001-i386-Remove-build-support-for-GCC-older-than-GCC-6.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k8otjhod0 RnJvbSBjYmM1ODIxNDkyNWI5MmQ3NWQzNmIzOWQzMDNhZWU5N2E1OWQ0Mzc1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IE1vbiwgNiBBcHIgMjAyMCAwNzoxMjowMCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGkzODY6IFJl bW92ZSBidWlsZCBzdXBwb3J0IGZvciBHQ0Mgb2xkZXIgdGhhbiBHQ0MgNgoKU2luY2UgR0NDIDYu MiBvciBsYXRlciBpcyByZXF1aXJlZCB0byBidWlsZCBnbGliYywgcmVtb3ZlIGJ1aWxkIHN1cHBv cnQKZm9yIEdDQyBvbGRlciB0aGFuIEdDQyA2LgoKVGVzdGQgd2l0aCBHQ0MgNi40IGFuZCBHQ0Mg OS4zLgotLS0KIHN5c2RlcHMvaTM4Ni9zeXNkZXAuaCAgICAgICAgICAgICAgICAgfCAgMiAtLQog c3lzZGVwcy9pMzg2L3Rscy1tYWNyb3MuaCAgICAgICAgICAgICB8IDM3ICsrKy0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQogc3lzZGVwcy91bml4L3N5c3YvbGludXgvaTM4Ni9zeXNkZXAuaCB8IDE3 ICstLS0tLS0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDUyIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL3N5c2RlcHMvaTM4Ni9zeXNkZXAuaCBiL3N5c2RlcHMvaTM4 Ni9zeXNkZXAuaAppbmRleCA2MDk0YWY4ZmVjLi4yZjc4NmEyNTFiIDEwMDY0NAotLS0gYS9zeXNk ZXBzL2kzODYvc3lzZGVwLmgKKysrIGIvc3lzZGVwcy9pMzg2L3N5c2RlcC5oCkBAIC0xOCw4ICsx OCw2IEBACiAKICNpbmNsdWRlIDxzeXNkZXBzL3g4Ni9zeXNkZXAuaD4KIAotI2luY2x1ZGUgPGZl YXR1cmVzLmg+IC8qIEZvciBfX0dOVUNfUFJFUkVRLiAgKi8KLQogLyogSXQgaXMgZGVzaXJhYmxl IHRoYXQgdGhlIG5hbWVzIG9mIFBJQyB0aHVua3MgbWF0Y2ggdGhvc2UgdXNlZCBieQogICAgR0ND IHNvIHRoYXQgbXVsdGlwbGUgY29waWVzIGFyZSBlbGltaW5hdGVkIGJ5IHRoZSBsaW5rZXIuICBC ZWNhdXNlCiAgICBHQ0MgNC42IGFuZCBlYXJsaWVyIHVzZSBfX2k2ODYgaW4gdGhlIG5hbWVzLCBp dCBpcyBuZWNlc3NhcnkgdG8KZGlmZiAtLWdpdCBhL3N5c2RlcHMvaTM4Ni90bHMtbWFjcm9zLmgg Yi9zeXNkZXBzL2kzODYvdGxzLW1hY3Jvcy5oCmluZGV4IDA1M2NiYTA1ZDEuLjljMTMwM2RjNDUg MTAwNjQ0Ci0tLSBhL3N5c2RlcHMvaTM4Ni90bHMtbWFjcm9zLmgKKysrIGIvc3lzZGVwcy9pMzg2 L3Rscy1tYWNyb3MuaApAQCAtMSw1ICsxLDMgQEAKLSNpbmNsdWRlIDxmZWF0dXJlcy5oPiAvKiBG b3IgX19HTlVDX1BSRVJFUS4gICovCi0KICNkZWZpbmUgVExTX0xFKHgpIFwKICAgKHsgaW50ICpf X2w7CQkJCQkJCQkgICAgICBcCiAgICAgIGFzbSAoIm1vdmwgJSVnczowLCUwXG5cdCIJCQkJCQkg ICAgICBcCkBAIC03LDE1ICs1LDcgQEAKIAkgIDogIj1yIiAoX19sKSk7CQkJCQkJICAgICAgXAog ICAgICBfX2w7IH0pCiAKLSNpZiBkZWZpbmVkIFBJQyAmJiAhX19HTlVDX1BSRVJFUSAoNSwwKQot IyBkZWZpbmUgVExTX0lFKHgpIFwKLSAgKHsgaW50ICpfX2w7CQkJCQkJCQkgICAgICBcCi0gICAg IGFzbSAoIm1vdmwgJSVnczowLCUwXG5cdCIJCQkJCQkgICAgICBcCi0JICAic3VibCAiICN4ICJA Z290dHBvZmYoJSVlYngpLCUwIgkJCQkgICAgICBcCi0JICA6ICI9ciIgKF9fbCkpOwkJCQkJCSAg ICAgIFwKLSAgICAgX19sOyB9KQotI2Vsc2UKLSMgZGVmaW5lIFRMU19JRSh4KSBcCisjZGVmaW5l IFRMU19JRSh4KSBcCiAgICh7IGludCAqX19sLCBfX2I7CQkJCQkJCSAgICAgIFwKICAgICAgYXNt ICgiY2FsbCAxZlxuXHQiCQkJCQkJCSAgICAgIFwKIAkgICIuc3Vic2VjdGlvbiAxXG4iCQkJCQkJ ICAgICAgXApAQCAtMjcsMTggKzE3LDggQEAKIAkgICJzdWJsICIgI3ggIkBnb3R0cG9mZiglJWVi eCksJTAiCQkJCSAgICAgIFwKIAkgIDogIj1yIiAoX19sKSwgIj0mYiIgKF9fYikpOwkJCQkJICAg ICAgXAogICAgICBfX2w7IH0pCi0jZW5kaWYKIAotI2lmIGRlZmluZWQgUElDICYmICFfX0dOVUNf UFJFUkVRICg1LDApCi0jIGRlZmluZSBUTFNfTEQoeCkgXAotICAoeyBpbnQgKl9fbCwgX19jLCBf X2Q7CQkJCQkJICAgICAgXAotICAgICBhc20gKCJsZWFsICIgI3ggIkB0bHNsZG0oJSVlYngpLCUl ZWF4XG5cdCIJCQkJICAgICAgXAotCSAgImNhbGwgX19fdGxzX2dldF9hZGRyQHBsdFxuXHQiCQkJ CSAgICAgIFwKLQkgICJsZWFsICIgI3ggIkBkdHBvZmYoJSVlYXgpLCAlJWVheCIJCQkJICAgICAg XAotCSAgOiAiPWEiIChfX2wpLCAiPSZjIiAoX19jKSwgIj0mZCIgKF9fZCkpOwkJCSAgICAgIFwK LSAgICAgX19sOyB9KQotI2Vsc2UKLSMgZGVmaW5lIFRMU19MRCh4KSBcCisjZGVmaW5lIFRMU19M RCh4KSBcCiAgICh7IGludCAqX19sLCBfX2IsIF9fYywgX19kOwkJCQkJCSAgICAgIFwKICAgICAg YXNtICgiY2FsbCAxZlxuXHQiCQkJCQkJCSAgICAgIFwKIAkgICIuc3Vic2VjdGlvbiAxXG4iCQkJ CQkJICAgICAgXApAQCAtNTEsMTggKzMxLDggQEAKIAkgICJsZWFsICIgI3ggIkBkdHBvZmYoJSVl YXgpLCAlJWVheCIJCQkJICAgICAgXAogCSAgOiAiPWEiIChfX2wpLCAiPSZiIiAoX19iKSwgIj0m YyIgKF9fYyksICI9JmQiIChfX2QpKTsJCSAgICAgIFwKICAgICAgX19sOyB9KQotI2VuZGlmCiAK LSNpZiBkZWZpbmVkIFBJQyAmJiAhX19HTlVDX1BSRVJFUSAoNSwwKQotIyBkZWZpbmUgVExTX0dE KHgpIFwKLSAgKHsgaW50ICpfX2wsIF9fYywgX19kOwkJCQkJCSAgICAgIFwKLSAgICAgYXNtICgi bGVhbCAiICN4ICJAdGxzZ2QoJSVlYngpLCUlZWF4XG5cdCIJCQkJICAgICAgXAotCSAgImNhbGwg X19fdGxzX2dldF9hZGRyQHBsdFxuXHQiCQkJCSAgICAgIFwKLQkgICJub3AiCQkJCQkJCQkgICAg ICBcCi0JICA6ICI9YSIgKF9fbCksICI9JmMiIChfX2MpLCAiPSZkIiAoX19kKSk7CQkJICAgICAg XAotICAgICBfX2w7IH0pCi0jZWxzZQotIyBkZWZpbmUgVExTX0dEKHgpIFwKKyNkZWZpbmUgVExT X0dEKHgpIFwKICAgKHsgaW50ICpfX2wsIF9fYiwgX19jLCBfX2Q7CQkJCQkJICAgICAgXAogICAg ICBhc20gKCJjYWxsIDFmXG5cdCIJCQkJCQkJICAgICAgXAogCSAgIi5zdWJzZWN0aW9uIDFcbiIJ CQkJCQkgICAgICBcCkBAIC03NSw0ICs0NSwzIEBACiAJICAibm9wIgkJCQkJCQkJICAgICAgXAog CSAgOiAiPWEiIChfX2wpLCAiPSZiIiAoX19iKSwgIj0mYyIgKF9fYyksICI9JmQiIChfX2QpKTsJ CSAgICAgIFwKICAgICAgX19sOyB9KQotI2VuZGlmCmRpZmYgLS1naXQgYS9zeXNkZXBzL3VuaXgv c3lzdi9saW51eC9pMzg2L3N5c2RlcC5oIGIvc3lzZGVwcy91bml4L3N5c3YvbGludXgvaTM4Ni9z eXNkZXAuaAppbmRleCA2NjcxYWZlNjVlLi5mNjg0N2E2N2UzIDEwMDY0NAotLS0gYS9zeXNkZXBz L3VuaXgvc3lzdi9saW51eC9pMzg2L3N5c2RlcC5oCisrKyBiL3N5c2RlcHMvdW5peC9zeXN2L2xp bnV4L2kzODYvc3lzZGVwLmgKQEAgLTQ4LDcgKzQ4LDcgQEAKICAgIHRvIGNvbXBpbGUgZ2xpYmMu ICBEaXNhYmxlIEdDQyA1IG9wdGltaXphdGlvbiB3aGVuIGNvbXBpbGluZyBmb3IKICAgIHByb2Zp bGluZyBvciB3aGVuIC1mbm8tb21pdC1mcmFtZS1wb2ludGVyIGlzIHVzZWQgc2luY2UgYXNtICgi ZWJwIikKICAgIGNhbid0IGJlIHVzZWQgdG8gcHV0IHRoZSA2dGggYXJndW1lbnQgaW4gJWVicCBm b3Igc3lzY2FsbC4gICovCi0jaWYgX19HTlVDX1BSRVJFUSAoNSwwKSAmJiAhZGVmaW5lZCBQUk9G ICYmIENBTl9VU0VfUkVHSVNURVJfQVNNX0VCUAorI2lmICFkZWZpbmVkIFBST0YgJiYgQ0FOX1VT RV9SRUdJU1RFUl9BU01fRUJQCiAjIGRlZmluZSBPUFRJTUlaRV9GT1JfR0NDXzUKICNlbmRpZgog CkBAIC01ODAsMjEgKzU4MCw2IEBAIHN0cnVjdCBsaWJjX2RvX3N5c2NhbGxfYXJncwogIyBkZWZp bmUgRVhUUkFWQVJfNQogI2VuZGlmCiAKLS8qIENvbnNpc3RlbmN5IGNoZWNrIGZvciBwb3NpdGlv bi1pbmRlcGVuZGVudCBjb2RlLiAgRGlzYWJsZWQgZm9yIEdDQyA1Ci0gICBhbmQgYWJvdmUgc2lu Y2UgdGhlcmUgaXMgbm8gZml4ZWQgUElDIHJlZ2lzdGVyIGluIEdDQyA1IGFuZCBhYm92ZS4gICov Ci0jaWYgZGVmaW5lZCBfX1BJQ19fICYmICFfX0dOVUNfUFJFUkVRICg1LDApCi0jIGRlZmluZSBj aGVja19jb25zaXN0ZW5jeSgpCQkJCQkJICAgICAgXAotICAoeyBpbnQgX19yZXM7CQkJCQkJCQkg ICAgICBcCi0gICAgIF9fYXNtX18gX192b2xhdGlsZV9fCQkJCQkJICAgICAgXAotICAgICAgIChM T0FEX1BJQ19SRUdfU1RSIChjeCkgIjsiCQkJCQkgICAgICBcCi0JInN1YmwgJSVlYngsICUlZWN4 OyIJCQkJCQkgICAgICBcCi0JImplIDFmOyIJCQkJCQkJICAgICAgXAotCSJ1ZDI7IgkJCQkJCQkJ ICAgICAgXAotCSIxOlxuIgkJCQkJCQkJICAgICAgXAotCTogIj1jIiAoX19yZXMpKTsJCQkJCQkg ICAgICBcCi0gICAgIF9fcmVzOyB9KQotI2VuZGlmCi0KICNlbmRpZgkvKiBfX0FTU0VNQkxFUl9f ICovCiAKIAotLSAKMi4yNS4xCgo= --000000000000fe20d405a2a39965--