From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com
 [IPv6:2607:f8b0:4864:20::c2f])
 by sourceware.org (Postfix) with ESMTPS id DAE5F3861019
 for <libc-alpha@sourceware.org>; Tue, 23 Mar 2021 23:09:54 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DAE5F3861019
Received: by mail-oo1-xc2f.google.com with SMTP id
 i20-20020a4a8d940000b02901bc71746525so5358255ook.2
 for <libc-alpha@sourceware.org>; Tue, 23 Mar 2021 16:09:54 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=+P2E1cvlt44i2+Ccg2ayZHaG7VoixFznuh4lU0R6JBI=;
 b=tMgtYsM/17TPPWBe8IE3enwJB2Vs9nIlj/TLj7NY7p4egwCPx91ujQtTuDfBVP2KwK
 Yk+UNhmqwHEHJWSnE4LD0yah4++NnKJ9SE2wlbHpnpCqDkK+64TtqeKzI584cB4Pd7NA
 LurJBSm8874z4S3taVYQaXSJwMzYP+2Qhn9dgn/GUauTN8ar1QceFtDPwcX1Gns/DjDL
 Hi5++zK+NT6Ihvcx0OlWYcA58Yad2QRrvdwPQseOsDsxj/4c8oyj2pAHpj2Ewq+Dq0jq
 +tJ++w4sZIWi3LtiqR2ysopxnX9MbHwF4jWCPP7YzE3r8Hva8T5ThCnVnPildvMzB7jE
 MG5w==
X-Gm-Message-State: AOAM530jtDwiq2I0onJPQtGTiLdOaIx/Xy2GrMEWiw6hSgxufkIsXA8V
 ZQoQGbJ7Pdjk31ClQ/7m28awaXmVNlKSr6wqAeo=
X-Google-Smtp-Source: ABdhPJwZYS5l4GULyIqjss37Bd6zoUHgk1X2zXhTbO2Gv6x5xFfzYvkekFW34olXxipIJqA+RV6en4Qj+Gb4JcM+cQ4=
X-Received: by 2002:a4a:d1da:: with SMTP id a26mr239837oos.58.1616540994301;
 Tue, 23 Mar 2021 16:09:54 -0700 (PDT)
MIME-Version: 1.0
References: <20210323224853.322700-1-samuel.thibault@ens-lyon.org>
In-Reply-To: <20210323224853.322700-1-samuel.thibault@ens-lyon.org>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 23 Mar 2021 16:09:18 -0700
Message-ID: <CAMe9rOphm-Me7wBi5nNdEGG2OEhM+bd-+ZRoq9dQ=7o_DWYjXg@mail.gmail.com>
Subject: Re: [PATCH] x86: Fix tst-ifunc-isa-* build when gcc ifunc support is
 not enabled
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: GNU C Library <libc-alpha@sourceware.org>, commit-hurd@gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3035.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2021 23:09:56 -0000

On Tue, Mar 23, 2021 at 3:49 PM Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
>
> ---
>  sysdeps/x86/tst-ifunc-isa-1.c | 17 +++++++++++++++++
>  sysdeps/x86/tst-ifunc-isa-2.c | 17 +++++++++++++++++
>  2 files changed, 34 insertions(+)
>
> diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
> index 37d599210c..7a58591c79 100644
> --- a/sysdeps/x86/tst-ifunc-isa-1.c
> +++ b/sysdeps/x86/tst-ifunc-isa-1.c
> @@ -16,6 +16,10 @@
>     License along with the GNU C Library; if not, see
>     <https://www.gnu.org/licenses/>.  */
>
> +#include <config.h>
> +
> +#ifdef HAVE_GCC_IFUNC
> +
>  #include <stdlib.h>
>  #include "tst-ifunc-isa.h"
>
> @@ -27,4 +31,17 @@ do_test (void)
>    return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
>  }
>
> +#else  /* !HAVE_GCC_IFUNC */
> +
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> +  FAIL_UNSUPPORTED ("GCC does not support the ifunc attribute");
> +  return 1;                     /* Not reachable.  */
> +}
> +
> +#endif  /* !HAVE_GCC_IFUNC */
> +
>  #include <support/test-driver.c>

Can you add LIBC_CONFIG_VAR with have-gcc-ifunc to skip
these tests?


-- 
H.J.