From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by sourceware.org (Postfix) with ESMTPS id B178B3858C32 for ; Mon, 1 Apr 2024 14:17:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B178B3858C32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B178B3858C32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711981075; cv=none; b=gvNetoniZv0QttSIr4HhXZWmFpNDeftXUkJ6pF9tYAqB2u/Z7iS2R9gMDfqOcGXrseP8GsjEzkUW0vKkqtTUo6HzZwwHqW12PZ19URVu63/djKIeIw5ZPVqgI/R/Eui4kaItlnNkVAdWFe0Ij7IagJZoLeAwCy3XC2JsJIsWy2U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711981075; c=relaxed/simple; bh=UGh7jCYVWRKcnBUOnX/Kf/20yeE/EJumMfX3jDcpNx4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=A4/UwuevRQEF9iQ6wXCrcsJqPkGMS5dTZ8PauGtLzweaMcHD/DXVHbYJ/4sPZuDBrPHUrJPLvsi8TNnOjXa82kJVGE11sPTjGM7VEUkeGHmuSQAdNxU5y8JNrBMCgXy1c3S5VkStliH0Lbh7wA3M+dMNqZ9jv7gbTFckMe1H8To= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-61446b42423so28363017b3.1 for ; Mon, 01 Apr 2024 07:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711981068; x=1712585868; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=D4HeXwvJSRHeZgeutZtvISGyTzELwHCjFd3INAfBFEw=; b=J6/gkL20P1tJ1rMk2lwjBuozI57yBombBsZDji+dFv7ER2mYUeeB/qQDSmvY8rtHs1 6mko8VPAzEZwy7YaOr8gBpCdHar0yxDaBgDhGSjwRLmGxfE/78MktWUWNE9G9c9OnmVy rMhkUU/wHcTqdSSSeh/SLFoiHskvWxjyiwqCTNvuwZzvyww8jxa01jFePdz0In7Jsj+k 9T1B+bmCHNUFIESsGLJwCfL8GhZeCiJhqQhidRhKUEVgsugbqGz0PNJnW7bTP6cRKKfo 2LzfnIu1cIVDxHFCUgh8GjDhHIawsDirz6S0ySV15GvqaoiFrxLr62amX4xuRORLk6VA Y2KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711981068; x=1712585868; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D4HeXwvJSRHeZgeutZtvISGyTzELwHCjFd3INAfBFEw=; b=kNUJCJnrmTqs0sK0ECJSJ45J/xUKNaFZUxZ0C7Oh3HvuENDAwC6CHLsxT27TTe0TMQ hqJHWVJmtX2qIVpMFVB0LzPDc1N8pd8RldA9NG3MAvczc3yKbbyK4yknrtCP55egbapv hTx54901+Y5OeDM7BfiwJ4It88hgMkFU4EtrivPu+iGcL7RJ1HotssELuV71ypbp5nSF arLsHVA6iT8ET6pJYF7JwRp44q6qKVXQPU8Ft/R1HK5zSJlGo4V29jy2G+uSBuBX8wga CTD+ZdTcc85LLiJZNt/Cdw3FHaGzyQw0lNp5HfgEug7ZZa9/4c+M/DmDKLE2AGDFsYNv ryEg== X-Gm-Message-State: AOJu0YzqxTVbP6FM8O61JFJAcwHhpshyRtKLJoGmCM78fjf4BHHwS146 ql0AIsUVv1Yf7q7Hgq2PlywRYPE8Mkvb20DGiyL3Mfj6BYY2yqk4AMqcmgsU/TbYYIDyu2lq9pl cae9I66C8fSDZCBIvH2TcxcBlrNjuSQJw X-Google-Smtp-Source: AGHT+IF6ldo54ao8rsqgCDbglEYg8rrtUTYhAU5qKyQE5S8UtooQt4y86egoXRBwtBmsWS4LfcfKQRrT9LN6kr6fyBA= X-Received: by 2002:a81:4708:0:b0:611:6b6f:dba8 with SMTP id u8-20020a814708000000b006116b6fdba8mr8503929ywa.25.1711981067855; Mon, 01 Apr 2024 07:17:47 -0700 (PDT) MIME-Version: 1.0 References: <20231228172026.2013007-1-adhemerval.zanella@linaro.org> <20231228172026.2013007-13-adhemerval.zanella@linaro.org> In-Reply-To: <20231228172026.2013007-13-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Mon, 1 Apr 2024 07:17:11 -0700 Message-ID: Subject: Re: [PATCH 12/12] i386: Do not raise inexact exception on trunc/truncf To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3020.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 28, 2023 at 9:23=E2=80=AFAM Adhemerval Zanella wrote: > > It is not allowed anymore on ISO C23. > > Checked on x86_64-linux-gnu and i686-linux-gnu. > --- > sysdeps/i386/fpu/{s_trunc.S =3D> s_trunc.c} | 37 +++++++++++---------- > sysdeps/i386/fpu/{s_truncf.S =3D> s_truncf.c} | 37 +++++++++++---------- > 2 files changed, 38 insertions(+), 36 deletions(-) > rename sysdeps/i386/fpu/{s_trunc.S =3D> s_trunc.c} (61%) > rename sysdeps/i386/fpu/{s_truncf.S =3D> s_truncf.c} (61%) > > diff --git a/sysdeps/i386/fpu/s_trunc.S b/sysdeps/i386/fpu/s_trunc.c > similarity index 61% > rename from sysdeps/i386/fpu/s_trunc.S > rename to sysdeps/i386/fpu/s_trunc.c > index 145288bc8e..b071ad9750 100644 > --- a/sysdeps/i386/fpu/s_trunc.S > +++ b/sysdeps/i386/fpu/s_trunc.c > @@ -1,5 +1,5 @@ > -/* Truncate double value. > - Copyright (C) 1997-2023 Free Software Foundation, Inc. > +/* Round to integer, toward zero. i386 version. > + Copyright (C) 2023 Free Software Foundation, Inc. 2024. > This file is part of the GNU C Library. > > The GNU C Library is free software; you can redistribute it and/or > @@ -16,22 +16,23 @@ > License along with the GNU C Library; if not, see > . */ > > -#include > +#define NO_MATH_REDIRECT > +#include > +#include > #include > > -ENTRY(__trunc) > - fldl 4(%esp) > - subl $32, %esp > - cfi_adjust_cfa_offset (32) > - fnstenv 4(%esp) > - movl $0xc00, %edx > - orl 4(%esp), %edx > - movl %edx, (%esp) > - fldcw (%esp) > - frndint > - fldenv 4(%esp) > - addl $32, %esp > - cfi_adjust_cfa_offset (-32) > - ret > -END(__trunc) > +double > +__trunc (double x) > +{ > + fenv_t fenv; > + double r; > + > + libc_feholdexcept_setround_387 (&fenv, FE_TOWARDZERO); > + asm volatile ("frndint" : "=3Dt" (r) : "0" (x)); > + /* Preserve "invalid" exceptions from sNaN input. */ > + fenv.__status_word |=3D libc_fetestexcept_387 (FE_INVALID); > + libc_fesetenv_387 (&fenv); > + > + return r; > +} > libm_alias_double (__trunc, trunc) > diff --git a/sysdeps/i386/fpu/s_truncf.S b/sysdeps/i386/fpu/s_truncf.c > similarity index 61% > rename from sysdeps/i386/fpu/s_truncf.S > rename to sysdeps/i386/fpu/s_truncf.c > index 7bdf0e5111..86d46ff660 100644 > --- a/sysdeps/i386/fpu/s_truncf.S > +++ b/sysdeps/i386/fpu/s_truncf.c > @@ -1,5 +1,5 @@ > -/* Truncate float value. > - Copyright (C) 1997-2023 Free Software Foundation, Inc. > +/* Round to integer, toward zero. i386 version. > + Copyright (C) 2023 Free Software Foundation, Inc. 2024. > This file is part of the GNU C Library. > > The GNU C Library is free software; you can redistribute it and/or > @@ -16,22 +16,23 @@ > License along with the GNU C Library; if not, see > . */ > > -#include > +#define NO_MATH_REDIRECT > +#include > +#include > #include > > -ENTRY(__truncf) > - flds 4(%esp) > - subl $32, %esp > - cfi_adjust_cfa_offset (32) > - fnstenv 4(%esp) > - movl $0xc00, %edx > - orl 4(%esp), %edx > - movl %edx, (%esp) > - fldcw (%esp) > - frndint > - fldenv 4(%esp) > - addl $32, %esp > - cfi_adjust_cfa_offset (-32) > - ret > -END(__truncf) > +float > +__truncf (float x) > +{ > + fenv_t fenv; > + float r; > + > + libc_feholdexcept_setround_387 (&fenv, FE_TOWARDZERO); > + asm volatile ("frndint" : "=3Dt" (r) : "0" (x)); > + /* Preserve "invalid" exceptions from sNaN input. */ > + fenv.__status_word |=3D libc_fetestexcept_387 (FE_INVALID); > + libc_fesetenv_387 (&fenv); > + > + return r; > +} > libm_alias_float (__trunc, trunc) > -- > 2.34.1 > --=20 H.J.