From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by sourceware.org (Postfix) with ESMTPS id 3A4623858C31 for ; Mon, 20 May 2024 16:51:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A4623858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A4623858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716223920; cv=none; b=baNJL7bFenwR4i4S0lMQ5aLV+HHsJAIB6fwuZITgpvIswA/jtTMGA9e1VQ+hvGsxlM3qPur7IWRRVpOXznnsJ+NtzouGX/6wvLMx5YFWUQVDmXWWIM0nt5I8zKsu9/i1TEm+f14xK+R/1PZm3lrvha65PLTHOUAzCKqhIwbs0dg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716223920; c=relaxed/simple; bh=GcXpMdyiEJ6KUkS7BS0nErRRQVGqo/g3GzQwhD16R34=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=uAHmfduJWnIsto+h/qrk2dZXNZmOU3eG6RNKUCkcp053ylxRc79ZGYMgPQlVBwkJxXKCLtNJvk5rwUgfWBat1FC79RnJBJDnXJ7MLLLdERTQi4JHcn7fquDkatlLzrjaIwee6zOQgiAdZqwpfEC8IRZWbauf97bINKEIRB5tIiE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-622f5a0badcso29837807b3.2 for ; Mon, 20 May 2024 09:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716223915; x=1716828715; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/s7usd1jflOV+qVg8DNqk4Di6smSXfCYXWkgAyNZBm8=; b=ghr4e4rfqIwmowqIwNBG3rFNQDlAOlPWcisYORwt7/bFAg+SWekp7mxIw9gADLR0Pn dPm2blID1z4ZOsZj4Hs4uPrGNLmXTNGxX2aS+qMXRimFBpx5kskUQ/RxqDqqZr1RBhAJ 30lirKx2hBJ0wpfueKm860+gkF5WSC9YZRiWll+jrlfSvekOHCPWwxgkv6QSIZQ3T7Gb BhGLSci3XhaONgg0bRPlTlE+hFzD4+NazaYaybmpqnGdHcV1ZXHhr0jM3cOjCYaSNSCU 1GgwYlOd9uj6wq7y4dXN9mQbKzhKA5dbWNQ2/xxZMLkdK5Bf4oPyEkS78fPMscGs24F+ YoVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716223915; x=1716828715; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/s7usd1jflOV+qVg8DNqk4Di6smSXfCYXWkgAyNZBm8=; b=a4haA9bpCH9GxeEZIU8j4IAQaOChCWWJZA3OxDjESMnIj+YVnp5nEZ1slXnSa+09aW MVaO/yehRjeGh9RgfWiK4IbuBFYk5Lk+u4yr58catXk2bK6v9oyDC3yBvvT/i3ghLm9Y DtEbT1A4fvUh/0Jn1TmnpB1mp9/BIK5pM3lpYDdd85ydLrfIgd4Kmi1psLTWEHPTiOA1 2ClMIfy+hCEHX2TpIYvDcf0gmCL2HMI50kn9UqQWSS/53/2xSy0KZIC6a9PCNKRUns2b VNctsdXWERHy+qnp0CruzIVMoN4U1MxIf1+zR4OyXtln0WlB7llMoCIatoE9ulL/dNci 4sMQ== X-Gm-Message-State: AOJu0Yzrm2NFL4u2yXJxw5+Hp3crfFj2xVSdkq7g0nXfIBY2XkVgJaNr 8MwTZCf4+mgwnvNCLSD3kewEVaQKIpUJAvgfSJ/4C9a36pEjkXptvDvreUdV4j7u80pf/sA0EwP Bdo+u5fosGUs7A2F1sA/NFXQ38qA= X-Google-Smtp-Source: AGHT+IEdbnyD/8X1QyNWjqEAuISbuU59DXggItJ9bWSji6Zthmyd88c2k+eu+j6yeu+MFIzuXi3x+jlO10xHibcm79c= X-Received: by 2002:a0d:ea91:0:b0:627:8791:5b3 with SMTP id 00721157ae682-627879107camr85398537b3.44.1716223915532; Mon, 20 May 2024 09:51:55 -0700 (PDT) MIME-Version: 1.0 References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-5-adhemerval.zanella@linaro.org> In-Reply-To: <20240402140644.2172819-5-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Mon, 20 May 2024 09:51:19 -0700 Message-ID: Subject: Re: [PATCH v3 4/7] math: Fix isnanf128 static build To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 2, 2024 at 7:06=E2=80=AFAM Adhemerval Zanella wrote: > > Some static implementation of float128 routines might call __isnanf128, Which targets do this? > which is not provided by the static object. > > Checked on x86_64-linux-gnu. > --- > sysdeps/ieee754/float128/float128_private.h | 2 +- > sysdeps/ieee754/float128/s_isnanf128.c | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/sysdeps/ieee754/float128/float128_private.h b/sysdeps/ieee75= 4/float128/float128_private.h > index 38a8bdd0fe..672bf3cccf 100644 > --- a/sysdeps/ieee754/float128/float128_private.h > +++ b/sysdeps/ieee754/float128/float128_private.h > @@ -352,7 +352,7 @@ > #define frexpl frexpf128 > #define getpayloadl getpayloadf128 > #define isinfl isinff128_do_not_use > -#define isnanl isnanf128_do_not_use > +#define isnanl isnanf128 > #define ldexpl ldexpf128 > #define llrintl llrintf128 > #define llroundl llroundf128 > diff --git a/sysdeps/ieee754/float128/s_isnanf128.c b/sysdeps/ieee754/flo= at128/s_isnanf128.c > index 59f71533ce..b73a4e80d7 100644 > --- a/sysdeps/ieee754/float128/s_isnanf128.c > +++ b/sysdeps/ieee754/float128/s_isnanf128.c > @@ -11,7 +11,11 @@ > #include "../ldbl-128/s_isnanl.c" > #if !IS_IN (libm) > #include > +#ifdef SHARED > hidden_ver (__isnanf128_impl, __isnanf128) > +#else > +strong_alias (__isnanf128_impl, __isnanf128) > +#endif > _weak_alias (__isnanf128_impl, isnanl) > versioned_symbol (libc, __isnanf128_impl, __isnanf128, GLIBC_2_34); > #if (SHLIB_COMPAT (libc, FLOAT128_VERSION_M, GLIBC_2_34)) > -- > 2.34.1 > --=20 H.J.