From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by sourceware.org (Postfix) with ESMTPS id 3A8573858D1E for ; Thu, 1 Sep 2022 14:52:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3A8573858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x833.google.com with SMTP id a22so10892262qtw.10 for ; Thu, 01 Sep 2022 07:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=vAGB8+zZ+XF8UPr5uxXmSnyvzavZwQND7O1Y7vUDZn0=; b=CYorBI75NZ7VCxK4V3+lrC66idJrqXj7GT26kaGgUuA1mjmCnOhmkW43pMsr4PQ/Nl RpXSMAI97fEj8I0NW544tSnYamzbxPLlg2SKLGnzgDgpaZ+jpOKgEOnLio8BxtpsXSKP KCLaclpHe0J3mdqAf/RCBl22oPzokHaMY4YyL0v9Kt4zMnJouhBnyMymAD1kMZA1dATe XjnOUInnf2hn5R2dbCwrZGt8HMPdGofdvpGe3bVjTNQsy9dhHIS+/xxDNEEYwHpdLwus ZXsV42HUURid6v0iAbCOhqcGSfAyv0cj8zI2uhQHUwwY9Y3qBNnsBmbpfwmmk3ngDVB+ UepA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=vAGB8+zZ+XF8UPr5uxXmSnyvzavZwQND7O1Y7vUDZn0=; b=N/pypzDfkUogxMy1CL3F+LoPfXUsaMpw+iPJdoFnNue5ub6iMkkojdYKQJwdWMAmt2 3C5qqqd0WUorxsGCzitauc/P0m9/C8mek+fFd+cUhkSPaPbmey05pynokQ3Lq3khx1fG guumbeF5442YSbOBEbVsCInabBK0I+xaoF/RFVXB4pRTIuLW/W0NOOJqOg/slw4k4WbU CjYp98HGJnr1Ah5paflfTL/oqCEyUzYPyx0B1DDb0d1ipi9lxVQPtyRJHQ1tYwxlSNr+ g6DQ2ArpwikjQEVxtiMWzkUen9KxelYRNDXeNmuR9ZmeL6FSzknGDxx/zzDTWx4fwClj 6kcw== X-Gm-Message-State: ACgBeo18H2RbkYWvkXhLQbqme4GmlyHD0anZQm9L2klB1/meWVZYT6iP O0ZobCVXDMJzxeiQnTR9FT3jt0NajVmVHgZI5idfP6p8 X-Google-Smtp-Source: AA6agR6jOSpIhfRG82SKz8PM+E+D+HN9tveyicjMDBwmPocptV/+I+yQ6l/ZBjHsy4sUJk4BDyjxn3/ZsZHxp5aFsH0= X-Received: by 2002:ac8:7c56:0:b0:344:24c1:60ff with SMTP id o22-20020ac87c56000000b0034424c160ffmr23271045qtv.437.1662043947503; Thu, 01 Sep 2022 07:52:27 -0700 (PDT) MIME-Version: 1.0 References: <20220831181443.3875972-1-adhemerval.zanella@linaro.org> <612f2a05-2e13-007c-0168-7d6eb9559554@linaro.org> In-Reply-To: <612f2a05-2e13-007c-0168-7d6eb9559554@linaro.org> From: "H.J. Lu" Date: Thu, 1 Sep 2022 07:51:51 -0700 Message-ID: Subject: Re: [PATCH] math: x86: Remove extra '%' on FP_INIT_ROUNDMODE inline asm To: Adhemerval Zanella Netto Cc: joseph_myers@mentor.com, GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3023.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 1, 2022 at 6:01 AM Adhemerval Zanella Netto wrote: > > > > On 31/08/22 16:33, H.J. Lu wrote: > > On Wed, Aug 31, 2022 at 11:16 AM Adhemerval Zanella via Libc-alpha > > wrote: > >> > >> Checked on x86_64-linux-gnu. > >> --- > >> sysdeps/x86/fpu/sfp-machine.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/sysdeps/x86/fpu/sfp-machine.h b/sysdeps/x86/fpu/sfp-machine.h > >> index 5892f4f5fe..1cacdb4ebd 100644 > >> --- a/sysdeps/x86/fpu/sfp-machine.h > >> +++ b/sysdeps/x86/fpu/sfp-machine.h > >> @@ -41,7 +41,7 @@ typedef unsigned int UTItype __attribute__ ((mode (TI))); > >> > >> # define FP_INIT_ROUNDMODE \ > >> do { \ > >> - __asm__ __volatile__ ("%vstmxcsr\t%0" : "=m" (_fcw)); \ > >> + __asm__ __volatile__ ("vstmxcsr\t%0" : "=m" (_fcw)); \ > >> } while (0) > >> #else > >> # define _FP_W_TYPE_SIZE 32 > >> -- > >> 2.34.1 > >> > > > > The intention was to generate stmxcsr with SSE and vstmxcsr with > > AVX. I think we should define a special prefix, like AVX_INSN_PREFIX, > > which is 'v' if __AVX__ is defined and empty if __AVX__ isn't defined. > > > > Right, I was not aware of it. Is is documented on gcc inline assembly I need to take a look. > manual somewhere (I could not find it)? In any case I will follow your > suggestion. There is no need for it. %v is handled by compiler with an operand. -- H.J.