From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 26702384F4B0; Thu, 24 Nov 2022 03:12:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26702384F4B0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x333.google.com with SMTP id 46-20020a9d0631000000b00666823da25fso243932otn.0; Wed, 23 Nov 2022 19:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N0cvLoUJIyIysUplE5CgzN8oKus13OHfZtkKbVT2ZvQ=; b=PoRMzVZWsbbSs72bVxus95JvlGOqTYkGAeS4+XK8eI9HEYDyty9awtGy+3e8/XPc8Q 2hk8hn8XcSUB5AMoWMpec2/3VpywLw0eLbCxZRNVtMRnJ9na1pRtEHdM9mTyvDOyjI8c jJct+L99ENx8+QVaPjJ2RSgWFHDtXXI9PO/CMy1xF0uVIn1nDIe3uWgHbBTyrcgS6L/S 6Hnlz+FEyh0vzIkAsGhcNQXIi0G1ag+y1d6ecH3clPwlpSWDeqZoIszB2VO6FwWijXE2 XHb+FsJ/knKOo9JGE2CzzKWVJEP73CXGEYRWDZbrxJFi7f+SomTBj3iDxbB3fdG+c1Ld 0ngg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N0cvLoUJIyIysUplE5CgzN8oKus13OHfZtkKbVT2ZvQ=; b=EhItyKEIZnO5tSHJ30+A1qRbyx21L2MFifyr7pCd7Pv9efuHSUi5bGfXCMWyCLxvEA IkgYr2NGow1AeydAKWP/eMtWu3sEMiEDtEs+QPorkprHlpCMbhAUEJGBkaUxoitEx+vc Cz73yWzzy9YPNxUslBQyP0Vf8P5ehPl0MtWQkAFOR65BfKOU66Gul9F5dT92MaUW3T9Y wvy4VAxrF7Wbo+QBpcbL8Am5WM+86kxyyJ0eD31xqcbarUHAQRpI32eR4IbtrR9OYA1Y dPwg7b3QPUUwKGc4EgKM/crQZLoteXsuoKcqfKfzm342ZTcZ3l8yqV5haLa1qx7rh4AQ aTkQ== X-Gm-Message-State: ANoB5plQ6WbJtWoFwue6mB3TiklwJEy4m8EREzzgOBS/UVksGu5sKGVs B2tfHNHTg+fF3sndHaiB1HuZL8mVsJngAgYM4jo= X-Google-Smtp-Source: AA0mqf7mytDE9AvayVJBn9oLUtrev/nNCrs6EBMN4C6YfhLseshL0OaUxWEvlwXLYeSP+1d7nq0mkbe5kWTeI53Ey2s= X-Received: by 2002:a05:6830:201a:b0:66c:49e4:82f8 with SMTP id e26-20020a056830201a00b0066c49e482f8mr15966008otp.371.1669259572372; Wed, 23 Nov 2022 19:12:52 -0800 (PST) MIME-Version: 1.0 References: <20220921005804.7131-1-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 23 Nov 2022 19:12:16 -0800 Message-ID: Subject: Re: [PATCH v1] x86: Fix wcsnlen-avx2 page cross length comparison [BZ #29591] To: Sunil Pandey Cc: Libc-stable Mailing List , Noah Goldstein , libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 23, 2022 at 7:04 PM Sunil Pandey wrote: > > On Wed, Nov 23, 2022 at 4:23 PM H.J. Lu wrote: > > > > On Wed, Nov 23, 2022 at 2:21 PM Sunil Pandey wrote: > > > > > > On Wed, Sep 21, 2022 at 3:02 PM H.J. Lu via Libc-alpha > > > wrote: > > > > > > > > On Tue, Sep 20, 2022 at 5:58 PM Noah Goldstein wrote: > > > > > > > > > > Previous implementation was adjusting length (rsi) to match > > > > > bytes (eax), but since there is no bound to length this can cause > > > > > overflow. > > > > > > > > > > Fix is to just convert the byte-count (eax) to length by dividing by > > > > > sizeof (wchar_t) before the comparison. > > > > > > > > > > Full check passes on x86-64 and build succeeds w/ and w/o multiarch. > > > > > --- > > > > > string/test-strnlen.c | 70 +++++++++++++++----------- > > > > > sysdeps/x86_64/multiarch/strlen-avx2.S | 7 +-- > > > > > 2 files changed, 43 insertions(+), 34 deletions(-) > > > > > > > > > > diff --git a/string/test-strnlen.c b/string/test-strnlen.c > > > > > index 4a9375112a..5cbaf4b734 100644 > > > > > --- a/string/test-strnlen.c > > > > > +++ b/string/test-strnlen.c > > > > > @@ -73,7 +73,7 @@ do_test (size_t align, size_t len, size_t maxlen, int max_char) > > > > > { > > > > > size_t i; > > > > > > > > > > - align &= 63; > > > > > + align &= (getpagesize () / sizeof (CHAR) - 1); > > > > > if ((align + len) * sizeof (CHAR) >= page_size) > > > > > return; > > > > > > > > > > @@ -90,38 +90,50 @@ do_test (size_t align, size_t len, size_t maxlen, int max_char) > > > > > static void > > > > > do_overflow_tests (void) > > > > > { > > > > > - size_t i, j, len; > > > > > + size_t i, j, al_idx, repeats, len; > > > > > const size_t one = 1; > > > > > uintptr_t buf_addr = (uintptr_t) buf1; > > > > > + const size_t alignments[] = { 0, 1, 7, 9, 31, 33, 63, 65, 95, 97, 127, 129 }; > > > > > > > > > > - for (i = 0; i < 750; ++i) > > > > > + for (al_idx = 0; al_idx < sizeof (alignments) / sizeof (alignments[0]); > > > > > + al_idx++) > > > > > { > > > > > - do_test (1, i, SIZE_MAX, BIG_CHAR); > > > > > - > > > > > - do_test (0, i, SIZE_MAX - i, BIG_CHAR); > > > > > - do_test (0, i, i - buf_addr, BIG_CHAR); > > > > > - do_test (0, i, -buf_addr - i, BIG_CHAR); > > > > > - do_test (0, i, SIZE_MAX - buf_addr - i, BIG_CHAR); > > > > > - do_test (0, i, SIZE_MAX - buf_addr + i, BIG_CHAR); > > > > > - > > > > > - len = 0; > > > > > - for (j = 8 * sizeof(size_t) - 1; j ; --j) > > > > > - { > > > > > - len |= one << j; > > > > > - do_test (0, i, len - i, BIG_CHAR); > > > > > - do_test (0, i, len + i, BIG_CHAR); > > > > > - do_test (0, i, len - buf_addr - i, BIG_CHAR); > > > > > - do_test (0, i, len - buf_addr + i, BIG_CHAR); > > > > > - > > > > > - do_test (0, i, ~len - i, BIG_CHAR); > > > > > - do_test (0, i, ~len + i, BIG_CHAR); > > > > > - do_test (0, i, ~len - buf_addr - i, BIG_CHAR); > > > > > - do_test (0, i, ~len - buf_addr + i, BIG_CHAR); > > > > > - > > > > > - do_test (0, i, -buf_addr, BIG_CHAR); > > > > > - do_test (0, i, j - buf_addr, BIG_CHAR); > > > > > - do_test (0, i, -buf_addr - j, BIG_CHAR); > > > > > - } > > > > > + for (repeats = 0; repeats < 2; ++repeats) > > > > > + { > > > > > + size_t align = repeats ? (getpagesize () - alignments[al_idx]) > > > > > + : alignments[al_idx]; > > > > > + align /= sizeof (CHAR); > > > > > + for (i = 0; i < 750; ++i) > > > > > + { > > > > > + do_test (align, i, SIZE_MAX, BIG_CHAR); > > > > > + > > > > > + do_test (align, i, SIZE_MAX - i, BIG_CHAR); > > > > > + do_test (align, i, i - buf_addr, BIG_CHAR); > > > > > + do_test (align, i, -buf_addr - i, BIG_CHAR); > > > > > + do_test (align, i, SIZE_MAX - buf_addr - i, BIG_CHAR); > > > > > + do_test (align, i, SIZE_MAX - buf_addr + i, BIG_CHAR); > > > > > + > > > > > + len = 0; > > > > > + for (j = 8 * sizeof (size_t) - 1; j; --j) > > > > > + { > > > > > + len |= one << j; > > > > > + do_test (align, i, len, BIG_CHAR); > > > > > + do_test (align, i, len - i, BIG_CHAR); > > > > > + do_test (align, i, len + i, BIG_CHAR); > > > > > + do_test (align, i, len - buf_addr - i, BIG_CHAR); > > > > > + do_test (align, i, len - buf_addr + i, BIG_CHAR); > > > > > + > > > > > + do_test (align, i, ~len - i, BIG_CHAR); > > > > > + do_test (align, i, ~len + i, BIG_CHAR); > > > > > + do_test (align, i, ~len - buf_addr - i, BIG_CHAR); > > > > > + do_test (align, i, ~len - buf_addr + i, BIG_CHAR); > > > > > + > > > > > + do_test (align, i, -buf_addr, BIG_CHAR); > > > > > + do_test (align, i, j - buf_addr, BIG_CHAR); > > > > > + do_test (align, i, -buf_addr - j, BIG_CHAR); > > > > > + } > > > > > + } > > > > > + } > > > > > } > > > > > } > > > > > > > > > > diff --git a/sysdeps/x86_64/multiarch/strlen-avx2.S b/sysdeps/x86_64/multiarch/strlen-avx2.S > > > > > index 0593fb303b..b9b58ef599 100644 > > > > > --- a/sysdeps/x86_64/multiarch/strlen-avx2.S > > > > > +++ b/sysdeps/x86_64/multiarch/strlen-avx2.S > > > > > @@ -544,14 +544,11 @@ L(return_vzeroupper): > > > > > L(cross_page_less_vec): > > > > > tzcntl %eax, %eax > > > > > # ifdef USE_AS_WCSLEN > > > > > - /* NB: Multiply length by 4 to get byte count. */ > > > > > - sall $2, %esi > > > > > + /* NB: Divide by 4 to convert from byte-count to length. */ > > > > > + shrl $2, %eax > > > > > # endif > > > > > cmpq %rax, %rsi > > > > > cmovb %esi, %eax > > > > > -# ifdef USE_AS_WCSLEN > > > > > - shrl $2, %eax > > > > > -# endif > > > > > VZEROUPPER_RETURN > > > > > # endif > > > > > > > > > > -- > > > > > 2.34.1 > > > > > > > > > > > > > LGTM. > > > > > > > > Thanks. > > > > > > > > -- > > > > H.J. > > > > > > I would like to backport this patch to affected release branches from > > > 2.36 to 2.33. > > > > > > Any comments/suggestions or objections on this. > > > > > > > OK. > > > > Thanks. > > > > > > -- > > H.J. > > Just ran testing from 2.32 to 2.26. All of them have this issue. > > Ok for 2.32 to 2.26 branches? > > --Sunil Let's stop at 2.28. -- H.J.