From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by sourceware.org (Postfix) with ESMTPS id B13E23858D28 for ; Mon, 1 Apr 2024 14:17:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B13E23858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B13E23858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711981034; cv=none; b=nJdoW3/GhNIKUD/I1vIGlNCi/HxZO12ydyhrVf4oYs/I0+EiL9vlIxYDuG2IaujHm9tlG0X8MenRkXGuE6zH1Ly/HuxFoc8ET7KlQK2lUIfvn7Jdnyzy7sv0g/dAGlwV4qYqMSP46InxTbfXPFajip75zJ0LEUyY2XFAvqW5P/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711981034; c=relaxed/simple; bh=n2EmK7rXYOqrr2fFp9FlzQDGqkgupcEafu+wFnJ8GCg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=A/l4qVN2BFElSEOHSAYNRTy9MekC2Go9Tv3XgD34Fd4pj98hPO5A7/tG3wSMNRbIFQ8j8qq8mXqE8MGsCT74+VPTKmMgecwJ35xfXwYc7vqCTibV5iQGrLzyPpok3MmfqN6glKTknyg3eRLVs/gxI16/F8cDl+yMnuGRdG9iBOc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-dcbf82cdf05so3319846276.2 for ; Mon, 01 Apr 2024 07:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711981032; x=1712585832; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5HV/DV8SnBUyJLF5gs+Hwh+TaVxoNq8u113kN34Umc0=; b=dvWI5Mcyxav9hQdsFReFz9xpikxeirlDHsPLMoGVCSn3Kj+H/M7oaQ0inSDe8A+vdS /thoCDcBMMydkkVytQJSaBUc5vSGoXuEg0nNKKkMuh6n2HU5VMOYFHz/3WtHqI4PZ6nj IJ2mnOnA17/KNKDDM93t9sdhI8FfvlwbbnnL/o34JsIjSR5s9kYWS0lbx9Kd2QENQ0ec w6R6b3ho0DrIZgyawzPouXUADcXDKS+mITPVQpowyeI43HEbLvD3mKn2Lh9aD2K7V2h7 k4EssgvNXe3dpJ54HhYVtbZBgkdnBYfHGYdf123t6eIbrriZRyAgMVKjHCWxnhelmAK9 osHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711981032; x=1712585832; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HV/DV8SnBUyJLF5gs+Hwh+TaVxoNq8u113kN34Umc0=; b=h5Iz9ai/4DbuX0eh4BJcpnRCKGu/RvgzAJtL5KLbGdVPzwNpxWRtZT/pb07JzPI88Q M4QgjrsepNcBsUN6WRK/Tuxv/mZUCVdPbntdUOuB3wPtia03tXfpDUam4jdceAIIOkzv ZAcSTWjjLaUJYg5sqwWhsWXjU1uBaD/muI2S3fpDYFNukoskv7GHVRwYtwZtiC8O0S/+ x+a/PN8HZqMbS76zw6F/KjjBNGwV/8Ji6XAsgubl7mlEiz2wC5yzyUMkqjlv3/xeKcOh ZLnXb+s9MjwUOvKfSyT5oSkiXRIdk3rrb1u1poTNyXgMhH6o4m4UjCjxdpSs9tMMG1Rs 7w3Q== X-Gm-Message-State: AOJu0Yyky8ndBxHnLRSOqT41gIuTALrpi0fU/mjck9NKxN1BxUqU0cF8 35GuVoq+x6rXCvU+72ocleQ/+f1j5+Nvf/zG4cNILH05zJzl3CHZvAZHMRWliw2E99ZTa8mPFWF kH94+Yubh9ygoh4nPvRgjkLWaZD6piG3/ X-Google-Smtp-Source: AGHT+IF6eWg3qcpxUv9gTMjJeSio1SSwPpMLWeIXeH15upC2NKbgrhnCpSEfvyFTp4x21VP4BCT2KaaiNFWPjiYhfF4= X-Received: by 2002:a25:cd83:0:b0:dc7:4a05:ca33 with SMTP id d125-20020a25cd83000000b00dc74a05ca33mr5878312ybf.64.1711981030505; Mon, 01 Apr 2024 07:17:10 -0700 (PDT) MIME-Version: 1.0 References: <20231228172026.2013007-1-adhemerval.zanella@linaro.org> <20231228172026.2013007-12-adhemerval.zanella@linaro.org> In-Reply-To: <20231228172026.2013007-12-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Mon, 1 Apr 2024 07:16:34 -0700 Message-ID: Subject: Re: [PATCH 11/12] i386: Do not raise inexact exception on ceil/ceilf To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 28, 2023 at 9:25=E2=80=AFAM Adhemerval Zanella wrote: > > It is not allowed anymore on ISO C23. > > Checked on x86_64-linux-gnu and i686-linux-gnu. > --- > sysdeps/i386/fpu/s_ceil.S | 34 ---------------------------------- > sysdeps/i386/fpu/s_ceil.c | 38 ++++++++++++++++++++++++++++++++++++++ > sysdeps/i386/fpu/s_ceilf.S | 34 ---------------------------------- > sysdeps/i386/fpu/s_ceilf.c | 38 ++++++++++++++++++++++++++++++++++++++ > 4 files changed, 76 insertions(+), 68 deletions(-) > delete mode 100644 sysdeps/i386/fpu/s_ceil.S > create mode 100644 sysdeps/i386/fpu/s_ceil.c > delete mode 100644 sysdeps/i386/fpu/s_ceilf.S > create mode 100644 sysdeps/i386/fpu/s_ceilf.c > > diff --git a/sysdeps/i386/fpu/s_ceil.S b/sysdeps/i386/fpu/s_ceil.S > deleted file mode 100644 > index 99984f9b8d..0000000000 > --- a/sysdeps/i386/fpu/s_ceil.S > +++ /dev/null > @@ -1,34 +0,0 @@ > -/* > - * Public domain. > - */ > - > -#include > -#include > - > -RCSID("$NetBSD: s_ceil.S,v 1.4 1995/05/08 23:52:13 jtc Exp $") > - > -ENTRY(__ceil) > - fldl 4(%esp) > - subl $32,%esp > - cfi_adjust_cfa_offset (32) > - > - fnstenv 4(%esp) /* store fpu environment */ > - > - /* We use here %edx although only the low 1 bits are defined. > - But none of the operations should care and they are faster > - than the 16 bit operations. */ > - movl $0x0800,%edx /* round towards +oo */ > - orl 4(%esp),%edx > - andl $0xfbff,%edx > - movl %edx,(%esp) > - fldcw (%esp) /* load modified control word */ > - > - frndint /* round */ > - > - fldenv 4(%esp) /* restore original environment *= / > - > - addl $32,%esp > - cfi_adjust_cfa_offset (-32) > - ret > -END (__ceil) > -libm_alias_double (__ceil, ceil) > diff --git a/sysdeps/i386/fpu/s_ceil.c b/sysdeps/i386/fpu/s_ceil.c > new file mode 100644 > index 0000000000..ec948ef83f > --- /dev/null > +++ b/sysdeps/i386/fpu/s_ceil.c > @@ -0,0 +1,38 @@ > +/* Return smallest integral value not less than argument. i386 version. > + Copyright (C) 2023 Free Software Foundation, Inc. 2024. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#define NO_MATH_REDIRECT > +#include > +#include > +#include > + > +double > +__ceil (double x) > +{ > + fenv_t fenv; > + double r; > + > + libc_feholdexcept_setround_387 (&fenv, FE_UPWARD); > + asm volatile ("frndint" : "=3Dt" (r) : "0" (x)); > + /* Preserve "invalid" exceptions from sNaN input. */ > + fenv.__status_word |=3D libc_fetestexcept_387 (FE_INVALID); > + libc_fesetenv_387 (&fenv); > + > + return r; > +} > +libm_alias_double (__ceil, ceil) > diff --git a/sysdeps/i386/fpu/s_ceilf.S b/sysdeps/i386/fpu/s_ceilf.S > deleted file mode 100644 > index 03e8e22609..0000000000 > --- a/sysdeps/i386/fpu/s_ceilf.S > +++ /dev/null > @@ -1,34 +0,0 @@ > -/* > - * Public domain. > - */ > - > -#include > -#include > - > -RCSID("$NetBSD: s_ceilf.S,v 1.3 1995/05/08 23:52:44 jtc Exp $") > - > -ENTRY(__ceilf) > - flds 4(%esp) > - subl $32,%esp > - cfi_adjust_cfa_offset (32) > - > - fnstenv 4(%esp) /* store fpu environment */ > - > - /* We use here %edx although only the low 1 bits are defined. > - But none of the operations should care and they are faster > - than the 16 bit operations. */ > - movl $0x0800,%edx /* round towards +oo */ > - orl 4(%esp),%edx > - andl $0xfbff,%edx > - movl %edx,(%esp) > - fldcw (%esp) /* load modified control word */ > - > - frndint /* round */ > - > - fldenv 4(%esp) /* restore original environment *= / > - > - addl $32,%esp > - cfi_adjust_cfa_offset (-32) > - ret > -END (__ceilf) > -libm_alias_float (__ceil, ceil) > diff --git a/sysdeps/i386/fpu/s_ceilf.c b/sysdeps/i386/fpu/s_ceilf.c > new file mode 100644 > index 0000000000..36159610b2 > --- /dev/null > +++ b/sysdeps/i386/fpu/s_ceilf.c > @@ -0,0 +1,38 @@ > +/* Return largest integral value not less than argument. i386 version. > + Copyright (C) 2023 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#define NO_MATH_REDIRECT > +#include > +#include > +#include > + > +float > +__ceilf (float x) > +{ > + fenv_t fenv; > + float r; > + > + libc_feholdexcept_setround_387 (&fenv, FE_UPWARD); > + asm volatile ("frndint" : "=3Dt" (r) : "0" (x)); > + /* Preserve "invalid" exceptions from sNaN input. */ > + fenv.__status_word |=3D libc_fetestexcept_387 (FE_INVALID); > + libc_fesetenv_387 (&fenv); > + > + return r; > +} > +libm_alias_float (__ceil, ceil) > -- > 2.34.1 > --=20 H.J.