From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by sourceware.org (Postfix) with ESMTPS id 282433854572 for ; Wed, 14 Dec 2022 16:10:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 282433854572 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-12c8312131fso17188531fac.4 for ; Wed, 14 Dec 2022 08:10:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lh5vgDp9yJiQUOBNy9wqv195OrURHYX1nhtd2HKXv3U=; b=oT/K/GVORSXJiQSrdShgmgNh1+HbU850PBXzIxPXFY4AkFq9tn1x+xHAhTRWj8zw1M 46GXXdQwOFh4kqmYM2P21DzBwc1JujxHS+qfg6XsEfdpHX+L2S5SN0BDUOjphke+8uVh YFIRhCXWDXWkRsLzkv09Dm8KYQO+mKY/yPtcn21M0qZHRr6p8HD/bWWI9dgQx/rJ0EuI X/+CnTR2Tz6yiIDmP0KtciJ/m6CeN8SH7VzZgoKpNs9r6SRjgjfmzCvsrB2T2/sF9WW5 +7EpqDhBqQCaskZ/TDQF73Q4OLk8B/JhvcxL5LVkzjGA78g3qqPnB6btldfnOZcj6DGF cPZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lh5vgDp9yJiQUOBNy9wqv195OrURHYX1nhtd2HKXv3U=; b=DtqZmY8eMBIxOALjdGwEokUTIP8PshSQUy1tliV4c7AqqxVX84HksNR54AbvzP8AWa ni+YjMuyiiXN3bkWVSMMHp2R82X+6qBzrW/rTvj+YKKRWoo3JMu+HsKuDJdlvwAUfL6m /1gRZjZ9QufIjDa4FoBbxVBgeWBSgZS0nZPV7B/V+nhfYWnQ4lTiasPrM/d0Ojp0R4OF whj1Vv/6Su8TkVa6vs/qXs/Q/L8UUfw3DJCtLC9k9bkZzNl/5zgkynJVpicPvinXQYDy mGC2gRLlXqsNfhrbY/erG3HzzeiQrWGvUIoKsHzhWU9HsuChmqz2WneUm+sc6szKKy7/ AM0w== X-Gm-Message-State: AFqh2krz3DzWVaw6olBhymgiGZ0EhGBr/ijF50GmaPFjj1PGGbNDLsUD qOZpEmBHznJBM65AF/UoKyIe69qTHi5B+FVqYjy/Ju9X X-Google-Smtp-Source: AMrXdXsxrJpa0JLeOlwYME6uawV7iMdlvtd9aMNjd8M3P5mSiygBm0AX01XHxVmWNesHffVYy5X4m+dVB2zNYRd7M0g= X-Received: by 2002:a05:6870:698b:b0:148:2c02:5323 with SMTP id my11-20020a056870698b00b001482c025323mr398526oab.298.1671034218395; Wed, 14 Dec 2022 08:10:18 -0800 (PST) MIME-Version: 1.0 References: <20221214001147.2814047-1-goldstein.w.n@gmail.com> <20221214073633.2876766-1-goldstein.w.n@gmail.com> In-Reply-To: <20221214073633.2876766-1-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Wed, 14 Dec 2022 08:09:42 -0800 Message-ID: Subject: Re: [PATCH v3] x86: Prevent SIGSEGV in memcmp-sse2 when data is concurrently modified [BZ #29863] To: Noah Goldstein Cc: libc-alpha@sourceware.org, carlos@systemhalted.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3022.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 13, 2022 at 11:36 PM Noah Goldstein wrote: > > In the case of INCORRECT usage of `memcmp(a, b, N)` where `a` and `b` > are concurrently modified as `memcmp` runs, there can be a SIGSEGV > in `L(ret_nonzero_vec_end_0)` because the sequential logic > assumes that `(rdx - 32 + rax)` is a positive 32-bit integer. > > To be clear, this change does not mean the usage of `memcmp` is > supported. The program behaviour is undefined (UB) in the > presence of data races, and `memcmp` is incorrect when the values > of `a` and/or `b` are modified concurrently (data race). This UB > may manifest itself as a SIGSEGV. That being said, if we can > allow the idiomatic use cases, like those in yottadb with > opportunistic concurrency control (OCC), to execute without a > SIGSEGV, at no cost to regular use cases, then we can aim to > minimize harm to those existing users. > > The fix replaces a 32-bit `addl %edx, %eax` with the 64-bit variant > `addq %rdx, %rax`. The 1-extra byte of code size from using the > 64-bit instruction doesn't contribute to overall code size as the > next target is aligned and has multiple bytes of `nop` padding > before it. As well all the logic between the add and `ret` still > fits in the same fetch block, so the cost of this change is > basically zero. > > The relevant sequential logic can be seen in the following > pseudo-code: > ``` > /* > * rsi = a > * rdi = b > * rdx = len - 32 > */ > /* cmp a[0:15] and b[0:15]. Since length is known to be [17, 32] > in this case, this check is also assumed to cover a[0:(31 - len)] > and b[0:(31 - len)]. */ > movups (%rsi), %xmm0 > movups (%rdi), %xmm1 > PCMPEQ %xmm0, %xmm1 > pmovmskb %xmm1, %eax > subl %ecx, %eax > jnz L(END_NEQ) > > /* cmp a[len-16:len-1] and b[len-16:len-1]. */ > movups 16(%rsi, %rdx), %xmm0 > movups 16(%rdi, %rdx), %xmm1 > PCMPEQ %xmm0, %xmm1 > pmovmskb %xmm1, %eax > subl %ecx, %eax > jnz L(END_NEQ2) > ret > > L(END2): > /* Position first mismatch. */ > bsfl %eax, %eax > > /* The sequential version is able to assume this value is a > positive 32-bit value because the first check included bytes in > range a[0:(31 - len)] and b[0:(31 - len)] so `eax` must be > greater than `31 - len` so the minimum value of `edx` + `eax` is > `(len - 32) + (32 - len) >= 0`. In the concurrent case, however, > `a` or `b` could have been changed so a mismatch in `eax` less or > equal than `(31 - len)` is possible (the new low bound is `(16 - > len)`. This can result in a negative 32-bit signed integer, which > when zero extended to 64-bits is a random large value this out > out of bounds. */ > addl %edx, %eax > > /* Crash here because 32-bit negative number in `eax` zero > extends to out of bounds 64-bit offset. */ > movzbl 16(%rdi, %rax), %ecx > movzbl 16(%rsi, %rax), %eax > ``` > > This fix is quite simple, just make the `addl %edx, %eax` 64 bit (i.e > `addq %rdx, %rax`). This prevents the 32-bit zero extension > and since `eax` is still a low bound of `16 - len` the `rdx + rax` > is bound by `(len - 32) - (16 - len) >= -16`. Since we have a > fixed offset of `16` in the memory access this must be in bounds. > --- > sysdeps/x86_64/multiarch/memcmp-sse2.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/x86_64/multiarch/memcmp-sse2.S b/sysdeps/x86_64/multiarch/memcmp-sse2.S > index afd450d020..34e60e567d 100644 > --- a/sysdeps/x86_64/multiarch/memcmp-sse2.S > +++ b/sysdeps/x86_64/multiarch/memcmp-sse2.S > @@ -308,7 +308,7 @@ L(ret_nonzero_vec_end_0): > setg %dl > leal -1(%rdx, %rdx), %eax > # else > - addl %edx, %eax > + addq %rdx, %rax Please add some comments here and a testcase. > movzbl (VEC_SIZE * -1 + SIZE_OFFSET)(%rsi, %rax), %ecx > movzbl (VEC_SIZE * -1 + SIZE_OFFSET)(%rdi, %rax), %eax > subl %ecx, %eax > -- > 2.34.1 > -- H.J.