From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com
 [IPv6:2607:f8b0:4864:20::729])
 by sourceware.org (Postfix) with ESMTPS id 9040D385801E
 for <libc-alpha@sourceware.org>; Mon,  8 Aug 2022 14:22:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9040D385801E
Received: by mail-qk1-x729.google.com with SMTP id z7so1162128qki.11
 for <libc-alpha@sourceware.org>; Mon, 08 Aug 2022 07:22:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc;
 bh=P/kmRrmDwEsptziV6c4W6m+C+hMAEW1dAgu+WGSIjVk=;
 b=K2U+Jb+4ysR78o1IK1Fyz7VuW9j0AlCIdrtwowjoB/udHSKi0mxGnOx9DCSTTAr2me
 D8ZDgKRm111XrdjVLu+Ht9mGVv4UzDpzG2krqx8snB99iygr6fjzLVGa8Bc4I62pKDqq
 sdpY4dbheUe9QgHNd0PgloJNt+Fz8ZyyKnPHOSROwWe7HN8m5t8xUr+QNVtDmFw+IuKl
 vHe3+ahhcHxqucxnRsFcrquGOv2gI7rFXYxy+QemCdgV1sBLsnZB7KI2YH7D+SXfZaWV
 mPtb7bXDH0oj1iRYv8tQ4Er8cqCbRui7drmtSlZq2sCTECQ86iOG5XxTKFvTNdKQ0H4l
 9Q6g==
X-Gm-Message-State: ACgBeo2CjwNGNAqs7LrVDREPvSiA9GKLaIunTrI7UbxYyp0DHbAppEwM
 TE6gaWAqUfTP9OdJZX0Kq6eUqygQpckLCWBUNqU=
X-Google-Smtp-Source: AA6agR5kgOuQLzzbS1a4VF1g/LdSqb/JRdMiow8R/vQeKzzH/OVBP57CslBXBvofXJQQpk1PLpUlaK9/gJ2uinpyAUU=
X-Received: by 2002:a37:e20e:0:b0:6b6:1f7d:1c98 with SMTP id
 g14-20020a37e20e000000b006b61f7d1c98mr13876000qki.670.1659968552863; Mon, 08
 Aug 2022 07:22:32 -0700 (PDT)
MIME-Version: 1.0
References: <20220808032622.3804534-1-goldstein.w.n@gmail.com>
In-Reply-To: <20220808032622.3804534-1-goldstein.w.n@gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 8 Aug 2022 07:21:57 -0700
Message-ID: <CAMe9rOpxFQJ=QKh0-btUw+uWNeNvbMXf0P+wYXt_JwripdNOLQ@mail.gmail.com>
Subject: Re: [PATCH v1] x86: Fix `#define STRCPY` guard in strcpy-sse2.S
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 "Carlos O'Donell" <carlos@systemhalted.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2022 14:22:35 -0000

On Sun, Aug 7, 2022 at 8:26 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> `#ifndef STPCPY` is incorrect for checking if `STRCPY` is already
> defined.  It doesn't end up mattering as the whole check is
> guarded by `#if IS_IN (libc)` but is incorrect none the less.
> ---
>  sysdeps/x86_64/multiarch/strcpy-sse2.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcpy-sse2.S b/sysdeps/x86_64/multiarch/strcpy-sse2.S
> index e29b411314..d6b9bae5f8 100644
> --- a/sysdeps/x86_64/multiarch/strcpy-sse2.S
> +++ b/sysdeps/x86_64/multiarch/strcpy-sse2.S
> @@ -22,7 +22,7 @@
>
>  # include <sysdep.h>
>
> -# ifndef STPCPY
> +# ifndef STRCPY
>  #  define STRCPY __strcpy_sse2
>  # endif
>
> --
> 2.34.1
>

LGTM.

Thanks.

-- 
H.J.