From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 10AEA385AC1A for ; Tue, 1 Feb 2022 13:43:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 10AEA385AC1A Received: by mail-pf1-x42d.google.com with SMTP id e28so15924121pfj.5 for ; Tue, 01 Feb 2022 05:43:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yUqeUSbkpUC/K1jVUHr9grzD74Eb64cmWExDqN9Kmdc=; b=Jg31aY8vixgrDNZ3e5gYkPVcr2vBMga2Hsebe/6z11wUo8hGRrKP4ejTCvsJgBombS YyOYV6DnpT1Nqi3/yGu/OEOAdxbh8e3397EjysPZ9jaXoBy4rnZr+1j4JwzOMQ1TgR1I Oil3SeHQmYSl23qXkhFK6I/IXvLi5WkfQjPq7rQuhtzSLe/D3DHKnoIRV/RFJUh7wSh+ m1FWcs1CjtymutAPvWj+pmoNKi7nAPam9z5RCA/2pL9bt8nPhv+fPA0Ua7gyWQC+4Vtf Db6y4ZN+hc9Mb/mf7P2GTdTs2feRcdXMP+p9uqyHnI5eL5iJmRTEX2GEaRiktqcM91I2 nHvw== X-Gm-Message-State: AOAM533/7IcFsOPVT6z8q11biZWlDTR4m73762ZYNKJKKC5C/ktybzWk N6t/Cprb8Ijglx2mhpJqbQInGJ40qLrBSt277fk= X-Google-Smtp-Source: ABdhPJyD58tMgMyEXKY3zleV9fwkOhhWW3DqO2zpBhvxQcpFeztTOcd9Uaa/a+mEXAUut10R6fgEBCAspS9ZN+CeKMg= X-Received: by 2002:a63:f542:: with SMTP id e2mr20837815pgk.381.1643723022218; Tue, 01 Feb 2022 05:43:42 -0800 (PST) MIME-Version: 1.0 References: <20220126205119.2000487-1-hjl.tools@gmail.com> <60e40abc-136f-b09c-3c8d-dc35c01f967a@redhat.com> In-Reply-To: <60e40abc-136f-b09c-3c8d-dc35c01f967a@redhat.com> From: "H.J. Lu" Date: Tue, 1 Feb 2022 05:43:06 -0800 Message-ID: Subject: Re: [PATCH] x86: Use CHECK_FEATURE_PRESENT to check HLE [BZ #27398] To: "Carlos O'Donell" Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 13:43:44 -0000 On Wed, Jan 26, 2022 at 8:54 PM Carlos O'Donell wrote: > > On 1/26/22 15:51, H.J. Lu wrote: > > HLE is disabled on blacklisted CPUs. Use CHECK_FEATURE_PRESENT, instead > > of CHECK_FEATURE_ACTIVE, to check HLE. > > OK for glibc 2.35. Fixes the issue on my T590 with the resume issues. > > Reviewed-by: Carlos O'Donell > Tested-by: Carlos O'Donell > > > --- > > sysdeps/x86/tst-cpu-features-supports.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c > > index 46b2c7bf83..9f10f02954 100644 > > --- a/sysdeps/x86/tst-cpu-features-supports.c > > +++ b/sysdeps/x86/tst-cpu-features-supports.c > > @@ -130,7 +130,7 @@ do_test (int argc, char **argv) > > fails += CHECK_FEATURE_ACTIVE (gfni, GFNI); > > #endif > > #if __GNUC_PREREQ (11, 0) > > - fails += CHECK_FEATURE_ACTIVE (hle, HLE); > > + fails += CHECK_FEATURE_PRESENT (hle, HLE); > > fails += CHECK_FEATURE_PRESENT (ibt, IBT); > > fails += CHECK_FEATURE_ACTIVE (lahf_lm, LAHF64_SAHF64); > > fails += CHECK_FEATURE_PRESENT (lm, LM); > > > -- > Cheers, > Carlos. > I am backporting this to release branches. -- H.J.