From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 2E0833858410 for ; Thu, 28 Oct 2021 21:14:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E0833858410 Received: by mail-pf1-x42b.google.com with SMTP id 187so7132606pfc.10 for ; Thu, 28 Oct 2021 14:14:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZVd3BK0IGUEYQjNCV6Q7w189GSXrGru6Hpv/SegB/yw=; b=67JL4AD0lIiVZIg4uPKqvl6mvn3McRe+e6O1cDPgBYBreG2449jkgexc2KOkDhznPN xN4qMe90nmfBs9Yf/vEniGzkrhD5/M5zJSfwp9UoqsHodl1q+F96ozYZ0Ods+MnA3+Ax twkGVphs5HCO7mXg7TlHEiUKuXZnyYzo7x3eW/Io5VLEyWO/w4YDdlgOP8RO7SmWsBM3 1T34Q2P+m6+1x2CMTI7HpmP+pJhj5y+Pya/GRzlCh4sLISwxqhvCncihAeTxhdyKgfDr l6oKmHlLYk/SivX7wLvxWhNZgxbShu4UzXSfn5dANxNtarS9/AS0rnUCDPKOPKV6r2y2 eTbQ== X-Gm-Message-State: AOAM531ytGFX+jAja+2AXyt+2kPc2Yy0Fvh1sRIb61i45b9XACI06Ujo jL6lD9/DqJx91ETA0MUv9bs3apClj99z282dSIo7WSWS6Xg= X-Google-Smtp-Source: ABdhPJx9ypW678OAyo7a2+sfp4gwGMoni5UAuqFTqBqgbuv1TgFAwTDlXNJnugl+bYKc/1AG1EKMGP0XH06J56SZC+g= X-Received: by 2002:a05:6a00:2351:b0:47b:d092:d2e4 with SMTP id j17-20020a056a00235100b0047bd092d2e4mr6475982pfj.76.1635455688299; Thu, 28 Oct 2021 14:14:48 -0700 (PDT) MIME-Version: 1.0 References: <20211028194738.82344-1-goldstein.w.n@gmail.com> <20211028211026.2430103-1-goldstein.w.n@gmail.com> In-Reply-To: <20211028211026.2430103-1-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Thu, 28 Oct 2021 14:14:12 -0700 Message-ID: Subject: Re: [PATCH v2] x86_64: Add memcmpeq.S to fix disable-multi-arch build To: Noah Goldstein Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2021 21:14:50 -0000 On Thu, Oct 28, 2021 at 2:10 PM Noah Goldstein via Libc-alpha wrote: > > The following commit: > > commit cf4fd28ea453d1a9cec93939bc88b58ccef5437a > Author: Noah Goldstein > Date: Tue Oct 26 19:43:18 2021 -0500 > > Broke --disable-multi-arch build for x86_64 because x86_64/memcmpeq.S > was not defined outside of multiarch and the alias for __memcmpeq in > x86_64/memcmp.S was removed. > > This commit fixes that issue by adding x86_64/memcmpeq.S. > > make xcheck passes on x86_64 with and without --disable-multi-arch > --- > sysdeps/x86_64/memcmpeq.S | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 sysdeps/x86_64/memcmpeq.S > > diff --git a/sysdeps/x86_64/memcmpeq.S b/sysdeps/x86_64/memcmpeq.S > new file mode 100644 > index 0000000000..db1756915d > --- /dev/null > +++ b/sysdeps/x86_64/memcmpeq.S > @@ -0,0 +1,21 @@ > +/* __memcmpeq optimized with SSE2. > + Copyright (C) 2017-2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#define memcmp __memcmpeq > +#define USE_AS_MEMCMPEQ 1 > +#include "multiarch/memcmp-sse2.S" > -- > 2.25.1 > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.